Re: [PATCH hglib RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

[Long Vu]

On 2017-04-03 05:03 PM, Matt Mackall wrote:

On Fri, 2017-03-24 at 10:05 -0400, Long Vu wrote:

# HG changeset patch
# User Long Vu 
# Date 1490322881 14400
#  Thu Mar 23 22:34:41 2017 -0400
# Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
# Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
hglib: fix hg clone --uncompressed option typo (issue5458)


I've pushed this and made a 2.4 release, thanks.



Thanks Matt for also creating a release to PyPI.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH hglib RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

[Matt Mackall]

On Fri, 2017-03-24 at 10:05 -0400, Long Vu wrote:
> # HG changeset patch
> # User Long Vu 
> # Date 1490322881 14400
> #  Thu Mar 23 22:34:41 2017 -0400
> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
> hglib: fix hg clone --uncompressed option typo (issue5458)

I've pushed this and made a 2.4 release, thanks.

-- 
Mathematics is the supreme nostalgia of our time.



___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH hglib RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

[Augie Fackler]

On Mon, Apr 03, 2017 at 11:47:07AM -0400, Long Vu wrote:
> On Wed, Mar 29, 2017 at 6:25 AM, Ryan McElroy  wrote:
> > This patch looks like a pretty clear fix of a typo... should be
> > straightforward to review. It's already been marked pre-reviewed.
> >
> > However, I don't see mpm in the cc list? So adding him direct to:
> >
>
> Looks like Matt is on vacation?
>
> Can someone else than him pull my very simple patch to
> https://selenic.com/repo/python-hglib?

Only mpm has access to selenic.com - we'll need him to either push the
patch or set up a redirect so that we can move that repository to live
in mercurial-scm.org.

>
> I will be using hglib for a go-live and I'd much prefer to pull from
> the official repo.

I understand and sympathize, but I can't help without mpm's help. :)

>
> Thanks.
>
>
> > ~Ryan
> >
> >
> >
> > On 3/28/17 9:08 PM, Kevin Bullock wrote:
> >>
> >> Adding Matt to direct Cc:, who I think is still the sole maintainer of
> >> python-hglib (though that's still on our list to change, I think).
> >>
> >> pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
> >> Kevin R. Bullock
> >>
> >>> On Mar 24, 2017, at 09:05, Long Vu  wrote:
> >>>
> >>> # HG changeset patch
> >>> # User Long Vu 
> >>> # Date 1490322881 14400
> >>> #  Thu Mar 23 22:34:41 2017 -0400
> >>> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
> >>> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
> >>> hglib: fix hg clone --uncompressed option typo (issue5458)
> >>>
> >>> Was getting error.CommandError
> >>> "hg clone: option --uncompresses not recognized".
> >>>
> >>> diff --git a/hglib/__init__.py b/hglib/__init__.py
> >>> --- a/hglib/__init__.py
> >>> +++ b/hglib/__init__.py
> >>> @@ -28,7 +28,7 @@
> >>>insecure=False, encoding=None, configs=None):
> >>>  args = util.cmdbuilder('clone', source, dest, noupdate=noupdate,
> >>> updaterev=updaterev, rev=rev, branch=branch,
> >>> -   pull=pull, uncompresses=uncompressed,
> >>> +   pull=pull, uncompressed=uncompressed,
> >>> e=ssh, remotecmd=remotecmd,
> >>> insecure=insecure)
> >>>
> >>>  args.insert(0, HGPATH)
> >>> diff --git a/tests/test-clone.py b/tests/test-clone.py
> >>> --- a/tests/test-clone.py
> >>> +++ b/tests/test-clone.py
> >>> @@ -11,3 +11,6 @@
> >>>  self.assertRaises(ValueError, cloned.log)
> >>>  cloned.open()
> >>>  self.assertEquals(self.client.log(), cloned.log())
> >>> +
> >>> +def test_clone_uncompressed(self):
> >>> +hglib.clone(b('.'), b('cloned'), uncompressed=True)
> >>>
> >
> > ___
> > Mercurial-devel mailing list
> > Mercurial-devel@mercurial-scm.org
> > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
>
>
> --
> Long Vu | Build Controller | Intelerad | +1-514-931-6222 ext. 7743
>
> --
>
> This email or any attachments may contain confidential or legally
> privileged information intended for the sole use of the addressees. Any
> use, redistribution, disclosure, or reproduction of this information,
> except as intended, is prohibited. If you received this email in error,
> please notify the sender and remove all copies of the message, including
> any attachments.
>
> ___
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH hglib RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

[Long Vu]

On Wed, Mar 29, 2017 at 6:25 AM, Ryan McElroy  wrote:
> This patch looks like a pretty clear fix of a typo... should be
> straightforward to review. It's already been marked pre-reviewed.
>
> However, I don't see mpm in the cc list? So adding him direct to:
>

Looks like Matt is on vacation?

Can someone else than him pull my very simple patch to
https://selenic.com/repo/python-hglib?

I will be using hglib for a go-live and I'd much prefer to pull from
the official repo.

Thanks.


> ~Ryan
>
>
>
> On 3/28/17 9:08 PM, Kevin Bullock wrote:
>>
>> Adding Matt to direct Cc:, who I think is still the sole maintainer of
>> python-hglib (though that's still on our list to change, I think).
>>
>> pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
>> Kevin R. Bullock
>>
>>> On Mar 24, 2017, at 09:05, Long Vu  wrote:
>>>
>>> # HG changeset patch
>>> # User Long Vu 
>>> # Date 1490322881 14400
>>> #  Thu Mar 23 22:34:41 2017 -0400
>>> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
>>> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
>>> hglib: fix hg clone --uncompressed option typo (issue5458)
>>>
>>> Was getting error.CommandError
>>> "hg clone: option --uncompresses not recognized".
>>>
>>> diff --git a/hglib/__init__.py b/hglib/__init__.py
>>> --- a/hglib/__init__.py
>>> +++ b/hglib/__init__.py
>>> @@ -28,7 +28,7 @@
>>>insecure=False, encoding=None, configs=None):
>>>  args = util.cmdbuilder('clone', source, dest, noupdate=noupdate,
>>> updaterev=updaterev, rev=rev, branch=branch,
>>> -   pull=pull, uncompresses=uncompressed,
>>> +   pull=pull, uncompressed=uncompressed,
>>> e=ssh, remotecmd=remotecmd,
>>> insecure=insecure)
>>>
>>>  args.insert(0, HGPATH)
>>> diff --git a/tests/test-clone.py b/tests/test-clone.py
>>> --- a/tests/test-clone.py
>>> +++ b/tests/test-clone.py
>>> @@ -11,3 +11,6 @@
>>>  self.assertRaises(ValueError, cloned.log)
>>>  cloned.open()
>>>  self.assertEquals(self.client.log(), cloned.log())
>>> +
>>> +def test_clone_uncompressed(self):
>>> +hglib.clone(b('.'), b('cloned'), uncompressed=True)
>>>
>
> ___
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel



-- 
Long Vu | Build Controller | Intelerad | +1-514-931-6222 ext. 7743

-- 

This email or any attachments may contain confidential or legally 
privileged information intended for the sole use of the addressees. Any 
use, redistribution, disclosure, or reproduction of this information, 
except as intended, is prohibited. If you received this email in error, 
please notify the sender and remove all copies of the message, including 
any attachments.

___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH hglib RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

[Ryan McElroy]

This patch looks like a pretty clear fix of a typo... should be 
straightforward to review. It's already been marked pre-reviewed.


However, I don't see mpm in the cc list? So adding him direct to:

~Ryan


On 3/28/17 9:08 PM, Kevin Bullock wrote:

Adding Matt to direct Cc:, who I think is still the sole maintainer of 
python-hglib (though that's still on our list to change, I think).

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock


On Mar 24, 2017, at 09:05, Long Vu  wrote:

# HG changeset patch
# User Long Vu 
# Date 1490322881 14400
#  Thu Mar 23 22:34:41 2017 -0400
# Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
# Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
hglib: fix hg clone --uncompressed option typo (issue5458)

Was getting error.CommandError
"hg clone: option --uncompresses not recognized".

diff --git a/hglib/__init__.py b/hglib/__init__.py
--- a/hglib/__init__.py
+++ b/hglib/__init__.py
@@ -28,7 +28,7 @@
   insecure=False, encoding=None, configs=None):
 args = util.cmdbuilder('clone', source, dest, noupdate=noupdate,
updaterev=updaterev, rev=rev, branch=branch,
-   pull=pull, uncompresses=uncompressed,
+   pull=pull, uncompressed=uncompressed,
e=ssh, remotecmd=remotecmd, insecure=insecure)

 args.insert(0, HGPATH)
diff --git a/tests/test-clone.py b/tests/test-clone.py
--- a/tests/test-clone.py
+++ b/tests/test-clone.py
@@ -11,3 +11,6 @@
 self.assertRaises(ValueError, cloned.log)
 cloned.open()
 self.assertEquals(self.client.log(), cloned.log())
+
+def test_clone_uncompressed(self):
+hglib.clone(b('.'), b('cloned'), uncompressed=True)



___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH hglib RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

[Long Vu]

On Sat, Mar 25, 2017 at 12:39 AM, Yuya Nishihara  wrote:
> On Fri, 24 Mar 2017 10:05:25 -0400, Long Vu wrote:
>> # HG changeset patch
>> # User Long Vu 
>> # Date 1490322881 14400
>> #  Thu Mar 23 22:34:41 2017 -0400
>> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
>> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
>> hglib: fix hg clone --uncompressed option typo (issue5458)
>
> This looks good to me.

Sorry for asking, how long before this patch will land into
https://selenic.com/repo/python-hglib?

I need to go-live soon with this patch and I'd much prefer to pull it
from the canonical source than from my personal repo.

Thanks.

-- 
Long Vu | Build Controller | Intelerad | +1-514-931-6222 ext. 7743

-- 

This email or any attachments may contain confidential or legally 
privileged information intended for the sole use of the addressees. Any 
use, redistribution, disclosure, or reproduction of this information, 
except as intended, is prohibited. If you received this email in error, 
please notify the sender and remove all copies of the message, including 
any attachments.

___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH hglib RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

[Long Vu]

# HG changeset patch
# User Long Vu 
# Date 1490322881 14400
#  Thu Mar 23 22:34:41 2017 -0400
# Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
# Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
hglib: fix hg clone --uncompressed option typo (issue5458)

Was getting error.CommandError
"hg clone: option --uncompresses not recognized".

diff --git a/hglib/__init__.py b/hglib/__init__.py
--- a/hglib/__init__.py
+++ b/hglib/__init__.py
@@ -28,7 +28,7 @@
   insecure=False, encoding=None, configs=None):
 args = util.cmdbuilder('clone', source, dest, noupdate=noupdate,
updaterev=updaterev, rev=rev, branch=branch,
-   pull=pull, uncompresses=uncompressed,
+   pull=pull, uncompressed=uncompressed,
e=ssh, remotecmd=remotecmd, insecure=insecure)
 
 args.insert(0, HGPATH)
diff --git a/tests/test-clone.py b/tests/test-clone.py
--- a/tests/test-clone.py
+++ b/tests/test-clone.py
@@ -11,3 +11,6 @@
 self.assertRaises(ValueError, cloned.log)
 cloned.open()
 self.assertEquals(self.client.log(), cloned.log())
+
+def test_clone_uncompressed(self):
+hglib.clone(b('.'), b('cloned'), uncompressed=True)
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel