D1301: py3: handle keyword arguments in hgext/extdiff.py

2017-11-04 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa8bc191fee5a: py3: handle keyword arguments in 
hgext/extdiff.py (authored by pulkit, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1301?vs=3238=3275

REVISION DETAIL
  https://phab.mercurial-scm.org/D1301

AFFECTED FILES
  hgext/extdiff.py

CHANGE DETAILS

diff --git a/hgext/extdiff.py b/hgext/extdiff.py
--- a/hgext/extdiff.py
+++ b/hgext/extdiff.py
@@ -338,6 +338,7 @@
 that revision is compared to the working directory, and, when no
 revisions are specified, the working directory files are compared
 to its parent.'''
+opts = pycompat.byteskwargs(opts)
 program = opts.get('program')
 option = opts.get('option')
 if not program:
@@ -369,6 +370,7 @@
 self._cmdline = cmdline
 
 def __call__(self, ui, repo, *pats, **opts):
+opts = pycompat.byteskwargs(opts)
 options = ' '.join(map(util.shellquote, opts['option']))
 if options:
 options = ' ' + options



To: pulkit, #hg-reviewers, yuja
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


D1301: py3: handle keyword arguments in hgext/extdiff.py

2017-11-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1301

AFFECTED FILES
  hgext/extdiff.py

CHANGE DETAILS

diff --git a/hgext/extdiff.py b/hgext/extdiff.py
--- a/hgext/extdiff.py
+++ b/hgext/extdiff.py
@@ -338,6 +338,7 @@
 that revision is compared to the working directory, and, when no
 revisions are specified, the working directory files are compared
 to its parent.'''
+opts = pycompat.byteskwargs(opts)
 program = opts.get('program')
 option = opts.get('option')
 if not program:
@@ -369,6 +370,7 @@
 self._cmdline = cmdline
 
 def __call__(self, ui, repo, *pats, **opts):
+opts = pycompat.byteskwargs(opts)
 options = ' '.join(map(util.shellquote, opts['option']))
 if options:
 options = ' ' + options



To: pulkit, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel