D1855: explicitly kill server processes
joerg.sonnenberger added a comment. It was preparation for more tests here. Since I am moving them to a separate file now, I'm not really attached to it at all. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1855 To: joerg.sonnenberger, #hg-reviewers, indygreg Cc: martinvonz, yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1855: explicitly kill server processes
martinvonz added a comment. In https://phab.mercurial-scm.org/D1855#31684, @martinvonz wrote: > In https://phab.mercurial-scm.org/D1855#31400, @yuja wrote: > > > Just for the record, explicit killdaemon isn't needed unless you want > > to do something (e.g. checking server logs) after that. Daemons are > > kill by the test runner. > > > So what was the reason for this patch? I found https://phab.mercurial-scm.org/rHGbc7377160fa732f4c22682bc98c09b76490ca137 that adds this line and a comment saying "Explicitly kill daemons to let the test exit on Windows". Unfortunately, it doesn't explain any more than that. Is Joerg also running on Windows and maybe had the same problem (that the test doesn't exit, whatever that means)? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1855 To: joerg.sonnenberger, #hg-reviewers, indygreg Cc: martinvonz, yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1855: explicitly kill server processes
martinvonz added a comment. In https://phab.mercurial-scm.org/D1855#31400, @yuja wrote: > Just for the record, explicit killdaemon isn't needed unless you want > to do something (e.g. checking server logs) after that. Daemons are > kill by the test runner. So what was the reason for this patch? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1855 To: joerg.sonnenberger, #hg-reviewers, indygreg Cc: martinvonz, yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1855: explicitly kill server processes
yuja added a comment. Just for the record, explicit killdaemon isn't needed unless you want to do something (e.g. checking server logs) after that. Daemons are kill by the test runner. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1855 To: joerg.sonnenberger, #hg-reviewers, indygreg Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1855: explicitly kill server processes
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5bda7bd29688: explicitly kill server processes (authored by joerg.sonnenberger, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1855?vs=4809&id=4814 REVISION DETAIL https://phab.mercurial-scm.org/D1855 AFFECTED FILES tests/test-pull-r.t CHANGE DETAILS diff --git a/tests/test-pull-r.t b/tests/test-pull-r.t --- a/tests/test-pull-r.t +++ b/tests/test-pull-r.t @@ -144,3 +144,4 @@ $ cd .. + $ killdaemons.py To: joerg.sonnenberger, #hg-reviewers, indygreg Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1855: explicitly kill server processes
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1855 AFFECTED FILES tests/test-pull-r.t CHANGE DETAILS diff --git a/tests/test-pull-r.t b/tests/test-pull-r.t --- a/tests/test-pull-r.t +++ b/tests/test-pull-r.t @@ -144,3 +144,4 @@ $ cd .. + $ killdaemons.py To: joerg.sonnenberger, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
