D2992: infinitepush: don't force ipv6 while connecting to mysql server
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc1fac3878196: infinitepush: don't force ipv6 while connecting to mysql server (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2992?vs=7459&id=7469#toc REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2992?vs=7459&id=7469 REVISION DETAIL https://phab.mercurial-scm.org/D2992 AFFECTED FILES hgext/infinitepush/sqlindexapi.py CHANGE DETAILS diff --git a/hgext/infinitepush/sqlindexapi.py b/hgext/infinitepush/sqlindexapi.py --- a/hgext/infinitepush/sqlindexapi.py +++ b/hgext/infinitepush/sqlindexapi.py @@ -60,8 +60,7 @@ retry = 3 while True: try: -self.sqlconn = mysql.connector.connect( -force_ipv6=True, **self.sqlargs) +self.sqlconn = mysql.connector.connect(**self.sqlargs) # Code is copy-pasted from hgsql. Bug fixes need to be # back-ported! To: pulkit, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2992: infinitepush: don't force ipv6 while connecting to mysql server
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I'm assuming we can drop the argument completely. So I'll do that in flight. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2992 To: pulkit, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2992: infinitepush: don't force ipv6 while connecting to mysql server
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Facebook internally enforces this but looks like we can't force this for pur users. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2992 AFFECTED FILES hgext/infinitepush/sqlindexapi.py CHANGE DETAILS diff --git a/hgext/infinitepush/sqlindexapi.py b/hgext/infinitepush/sqlindexapi.py --- a/hgext/infinitepush/sqlindexapi.py +++ b/hgext/infinitepush/sqlindexapi.py @@ -61,7 +61,7 @@ while True: try: self.sqlconn = mysql.connector.connect( -force_ipv6=True, **self.sqlargs) +force_ipv6=False, **self.sqlargs) # Code is copy-pasted from hgsql. Bug fixes need to be # back-ported! To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
