D3127: py3: return bytes from util.removeauth()
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb23e3cc1afd4: py3: return bytes from util.removeauth() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3127?vs=7710=7725 REVISION DETAIL https://phab.mercurial-scm.org/D3127 AFFECTED FILES mercurial/util.py CHANGE DETAILS diff --git a/mercurial/util.py b/mercurial/util.py --- a/mercurial/util.py +++ b/mercurial/util.py @@ -2864,7 +2864,7 @@ '''remove all authentication information from a url string''' u = url(u) u.user = u.passwd = None -return str(u) +return bytes(u) timecount = unitcountfn( (1, 1e3, _('%.0f s')), To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D3127: py3: return bytes from util.removeauth()
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY util.hidepassword() also returns bytes and we should deal in bytes as much as possible. This makes test-logexchange.t pass on Python 3.5 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3127 AFFECTED FILES mercurial/util.py CHANGE DETAILS diff --git a/mercurial/util.py b/mercurial/util.py --- a/mercurial/util.py +++ b/mercurial/util.py @@ -2864,7 +2864,7 @@ '''remove all authentication information from a url string''' u = url(u) u.user = u.passwd = None -return str(u) +return bytes(u) timecount = unitcountfn( (1, 1e3, _('%.0f s')), To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel