D322: fsmonitor: correct an error message

2017-08-10 Thread quark (Jun Wu) 
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Without the change, the error looks like:
  
warning: Watchman unavailable: "watchman" executable not in PATH (%s),
while executing [Errno 2] No such file or directory
  
  With the change, it now looks like:
  
warning: Watchman unavailable: "watchman" executable not in PATH
([Errno 2] No such file or directory)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D322

AFFECTED FILES
  hgext/fsmonitor/pywatchman/__init__.py

CHANGE DETAILS

diff --git a/hgext/fsmonitor/pywatchman/__init__.py 
b/hgext/fsmonitor/pywatchman/__init__.py
--- a/hgext/fsmonitor/pywatchman/__init__.py
+++ b/hgext/fsmonitor/pywatchman/__init__.py
@@ -825,7 +825,7 @@
 p = subprocess.Popen(cmd, **args)
 
 except OSError as e:
-raise WatchmanError('"watchman" executable not in PATH (%s)', e)
+raise WatchmanError('"watchman" executable not in PATH (%s)' % e)
 
 stdout, stderr = p.communicate()
 exitcode = p.poll()



To: quark, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D322: fsmonitor: correct an error message

2017-08-10 Thread lothiraldan (Boris Feld) 
lothiraldan accepted this revision.
lothiraldan added a comment.


  LGTM, we don't have a test for it?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D322

To: quark, #hg-reviewers, lothiraldan
Cc: lothiraldan, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D322: fsmonitor: correct an error message

2017-08-11 Thread quark (Jun Wu) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdd35abc409ee: fsmonitor: correct an error message (authored 
by quark).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D322?vs=738&id=796

REVISION DETAIL
  https://phab.mercurial-scm.org/D322

AFFECTED FILES
  hgext/fsmonitor/pywatchman/__init__.py

CHANGE DETAILS

diff --git a/hgext/fsmonitor/pywatchman/__init__.py 
b/hgext/fsmonitor/pywatchman/__init__.py
--- a/hgext/fsmonitor/pywatchman/__init__.py
+++ b/hgext/fsmonitor/pywatchman/__init__.py
@@ -825,7 +825,7 @@
 p = subprocess.Popen(cmd, **args)
 
 except OSError as e:
-raise WatchmanError('"watchman" executable not in PATH (%s)', e)
+raise WatchmanError('"watchman" executable not in PATH (%s)' % e)
 
 stdout, stderr = p.communicate()
 exitcode = p.poll()



To: quark, #hg-reviewers, lothiraldan
Cc: lothiraldan, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel