D3635: py3: add support for NoneType in stringutil.pprint()
yuja added a comment. >> --- a/mercurial/utils/stringutil.py > > +++ b/mercurial/utils/stringutil.py > > @@ -29,6 +29,8 @@ > > if bprefix: > > return "b'%s'" % escapestr(o) > > return "'%s'" % escapestr(o) > > +elif o is None: > > +return 'None' > > Should be handled by `b'%r' % o`. Dropped this patch from hg-committed before sinking deep. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3635 To: pulkit, #hg-reviewers, indygreg Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: D3635: py3: add support for NoneType in stringutil.pprint()
> > --- a/mercurial/utils/stringutil.py > > +++ b/mercurial/utils/stringutil.py > > @@ -29,6 +29,8 @@ > > if bprefix: > > return "b'%s'" % escapestr(o) > > return "'%s'" % escapestr(o) > > +elif o is None: > > +return 'None' > > Should be handled by `b'%r' % o`. Dropped this patch from hg-committed before sinking deep. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: D3635: py3: add support for NoneType in stringutil.pprint()
> --- a/mercurial/utils/stringutil.py > +++ b/mercurial/utils/stringutil.py > @@ -29,6 +29,8 @@ > if bprefix: > return "b'%s'" % escapestr(o) > return "'%s'" % escapestr(o) > +elif o is None: > +return 'None' Should be handled by `b'%r' % o`. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D3635: py3: add support for NoneType in stringutil.pprint()
yuja added a comment. > - a/mercurial/utils/stringutil.py +++ b/mercurial/utils/stringutil.py @@ -29,6 +29,8 @@ if bprefix: return "b'%s'" % escapestr(o) return "'%s'" % escapestr(o) +elif o is None: +return 'None' Should be handled by `b'%r' % o`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3635 To: pulkit, #hg-reviewers, indygreg Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D3635: py3: add support for NoneType in stringutil.pprint()
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7aeb8aa262eb: py3: add support for NoneType in stringutil.pprint() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3635?vs=8843=8860 REVISION DETAIL https://phab.mercurial-scm.org/D3635 AFFECTED FILES mercurial/utils/stringutil.py CHANGE DETAILS diff --git a/mercurial/utils/stringutil.py b/mercurial/utils/stringutil.py --- a/mercurial/utils/stringutil.py +++ b/mercurial/utils/stringutil.py @@ -29,6 +29,8 @@ if bprefix: return "b'%s'" % escapestr(o) return "'%s'" % escapestr(o) +elif o is None: +return 'None' elif isinstance(o, bytearray): # codecs.escape_encode() can't handle bytearray, so escapestr fails # without coercion. To: pulkit, #hg-reviewers, indygreg Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D3635: py3: add support for NoneType in stringutil.pprint()
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are some places in codebase where we try to print the value None, however `'%s' % None` is invalid on Python 3. So it will be good to have support in stringutil.pprint() REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3635 AFFECTED FILES mercurial/utils/stringutil.py CHANGE DETAILS diff --git a/mercurial/utils/stringutil.py b/mercurial/utils/stringutil.py --- a/mercurial/utils/stringutil.py +++ b/mercurial/utils/stringutil.py @@ -29,6 +29,8 @@ if bprefix: return "b'%s'" % escapestr(o) return "'%s'" % escapestr(o) +elif o is None: +return 'None' elif isinstance(o, bytearray): # codecs.escape_encode() can't handle bytearray, so escapestr fails # without coercion. To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
