D3641: state: temporary silence pyflakes warning by removing variable assignment
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb7e5c53a779e: state: temporary silence pyflakes warning by removing variable assignment (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3641?vs=8863=8870 REVISION DETAIL https://phab.mercurial-scm.org/D3641 AFFECTED FILES mercurial/state.py CHANGE DETAILS diff --git a/mercurial/state.py b/mercurial/state.py --- a/mercurial/state.py +++ b/mercurial/state.py @@ -70,7 +70,7 @@ data in the same format as it was before storing""" with self._repo.vfs(self.fname, 'rb') as fp: try: -version = int(fp.readline()) +int(fp.readline()) except ValueError: raise error.ProgrammingError("unknown version of state file" " found") To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D3641: state: temporary silence pyflakes warning by removing variable assignment
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The variable 'version' is going to be used in upcoming series where we will be using the version number to read a certain state file. However currently, pyflakes fails because of the variable not being used. Let's remove the assignment temporarily so that buildbots and test-suite is happy until I iterate over remaining part of the series. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3641 AFFECTED FILES mercurial/state.py CHANGE DETAILS diff --git a/mercurial/state.py b/mercurial/state.py --- a/mercurial/state.py +++ b/mercurial/state.py @@ -70,7 +70,7 @@ data in the same format as it was before storing""" with self._repo.vfs(self.fname, 'rb') as fp: try: -version = int(fp.readline()) +int(fp.readline()) except ValueError: raise error.ProgrammingError("unknown version of state file" " found") To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel