D7385: debugcommands: suppress import errors for pytype

2019-11-18 Thread durin42 (Augie Fackler) 
Closed by commit rHGa9b14ef701d1: debugcommands: suppress import errors for 
pytype (authored by durin42).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7385?vs=18157=18226

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7385/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7385

AFFECTED FILES
  mercurial/debugcommands.py

CHANGE DETAILS

diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py
--- a/mercurial/debugcommands.py
+++ b/mercurial/debugcommands.py
@@ -1561,7 +1561,7 @@
 err = None
 try:
 if cext:
-from .cext import (
+from .cext import (  # pytype: disable=import-error
 base85,
 bdiff,
 mpatch,
@@ -1571,7 +1571,7 @@
 # quiet pyflakes
 dir(bdiff), dir(mpatch), dir(base85), dir(osutil)
 if rustext:
-from .rustext import (
+from .rustext import (  # pytype: disable=import-error
 ancestor,
 dirstate,
 )



To: durin42, #hg-reviewers, dlax, indygreg
Cc: dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7385: debugcommands: suppress import errors for pytype

2019-11-15 Thread durin42 (Augie Fackler) 
durin42 updated this revision to Diff 18157.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7385?vs=18073=18157

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7385/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7385

AFFECTED FILES
  mercurial/debugcommands.py

CHANGE DETAILS

diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py
--- a/mercurial/debugcommands.py
+++ b/mercurial/debugcommands.py
@@ -1544,7 +1544,7 @@
 err = None
 try:
 if cext:
-from .cext import (
+from .cext import (  # pytype: disable=import-error
 base85,
 bdiff,
 mpatch,
@@ -1554,7 +1554,7 @@
 # quiet pyflakes
 dir(bdiff), dir(mpatch), dir(base85), dir(osutil)
 if rustext:
-from .rustext import (
+from .rustext import (  # pytype: disable=import-error
 ancestor,
 dirstate,
 )



To: durin42, #hg-reviewers, dlax
Cc: dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7385: debugcommands: suppress import errors for pytype

2019-11-14 Thread durin42 (Augie Fackler) 
durin42 added a comment.


  In D7385#108592 , @dlax wrote:
  
  > I wonder if using `importlib.import_module()` wouldn't help. Or is it 
something we avoid in Mercurial?
  
  We use it in other places. I have no idea the extent to which it'd help.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7385/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7385

To: durin42, #hg-reviewers, dlax
Cc: dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7385: debugcommands: suppress import errors for pytype

2019-11-14 Thread dlax (Denis Laxalde) 
dlax added a comment.
dlax accepted this revision.


  I wonder if using `importlib.import_module()` wouldn't help. Or is it 
something we avoid in Mercurial?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7385/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7385

To: durin42, #hg-reviewers, dlax
Cc: dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7385: debugcommands: suppress import errors for pytype

2019-11-13 Thread durin42 (Augie Fackler) 
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7385

AFFECTED FILES
  mercurial/debugcommands.py

CHANGE DETAILS

diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py
--- a/mercurial/debugcommands.py
+++ b/mercurial/debugcommands.py
@@ -1543,7 +1543,7 @@
 err = None
 try:
 if cext:
-from .cext import (
+from .cext import (  # pytype: disable=import-error
 base85,
 bdiff,
 mpatch,
@@ -1553,7 +1553,7 @@
 # quiet pyflakes
 dir(bdiff), dir(mpatch), dir(base85), dir(osutil)
 if rustext:
-from .rustext import (
+from .rustext import (  # pytype: disable=import-error
 ancestor,
 dirstate,
 )



To: durin42, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel