D7964: cext: change two more vars to Py_ssize_t in manifest.c

[durin42 (Augie Fackler)]

durin42 added a comment.


  Yes, I'll move this to stable.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7964/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7964

To: spectral, #hg-reviewers
Cc: pulkit, durin42, martinvonz, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7964: cext: change two more vars to Py_ssize_t in manifest.c

[pulkit (Pulkit Goyal)]

pulkit added a comment.
pulkit added subscribers: martinvonz, durin42, pulkit.


  This should go to stable branch right?
  cc: @martinvonz @durin42

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7964/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7964

To: spectral, #hg-reviewers
Cc: pulkit, durin42, martinvonz, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7964: cext: change two more vars to Py_ssize_t in manifest.c

[spectral (Kyle Lippincott)]

Closed by commit rHG0e198f1f276a: cext: change two more vars to Py_ssize_t in 
manifest.c (authored by spectral).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs 
Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7964?vs=19498=19501

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7964/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7964

AFFECTED FILES
  mercurial/cext/manifest.c

CHANGE DETAILS

diff --git a/mercurial/cext/manifest.c b/mercurial/cext/manifest.c
--- a/mercurial/cext/manifest.c
+++ b/mercurial/cext/manifest.c
@@ -80,7 +80,7 @@
PyObject *hash = nodeof(l);
 
/* 40 for hash, 1 for null byte, 1 for newline */
-   size_t hplen = plen + 42;
+   Py_ssize_t hplen = plen + 42;
Py_ssize_t flen = l->len - hplen;
PyObject *flags;
PyObject *tup;
@@ -525,7 +525,7 @@
PyObject *pyflags;
char *flags;
Py_ssize_t flen;
-   size_t dlen;
+   Py_ssize_t dlen;
char *dest;
int i;
line new;



To: spectral, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7964: cext: change two more vars to Py_ssize_t in manifest.c

[spectral (Kyle Lippincott)]

spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  D7913  fixed a compiler warning with a 
signedness conflict in a ternary operator
  by changing the types of some variables to be Py_ssize_t instead of size_t or
  int. That commit missed these two cases since they aren't warned about (at 
least
  on my compiler).
  
  Both of these variables are produced by operations on variables that are
  themselves Py_ssize_t now/already, so they should keep the same type.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7964

AFFECTED FILES
  mercurial/cext/manifest.c

CHANGE DETAILS

diff --git a/mercurial/cext/manifest.c b/mercurial/cext/manifest.c
--- a/mercurial/cext/manifest.c
+++ b/mercurial/cext/manifest.c
@@ -80,7 +80,7 @@
PyObject *hash = nodeof(l);
 
/* 40 for hash, 1 for null byte, 1 for newline */
-   size_t hplen = plen + 42;
+   Py_ssize_t hplen = plen + 42;
Py_ssize_t flen = l->len - hplen;
PyObject *flags;
PyObject *tup;
@@ -525,7 +525,7 @@
PyObject *pyflags;
char *flags;
Py_ssize_t flen;
-   size_t dlen;
+   Py_ssize_t dlen;
char *dest;
int i;
line new;



To: spectral, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel