D917: eol: make [eol] config section sensitive for chg confighash

2017-10-05 Thread quark (Jun Wu) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG37b7581e5737: eol: make [eol] config section sensitive for 
chg confighash (authored by quark, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D917?vs=2453=2463

REVISION DETAIL
  https://phab.mercurial-scm.org/D917

AFFECTED FILES
  mercurial/chgserver.py

CHANGE DETAILS

diff --git a/mercurial/chgserver.py b/mercurial/chgserver.py
--- a/mercurial/chgserver.py
+++ b/mercurial/chgserver.py
@@ -68,6 +68,7 @@
 # sensitive config sections affecting confighash
 _configsections = [
 'alias',  # affects global state commands.table
+'eol',# uses setconfig('eol', ...)
 'extdiff',  # uisetup will register new commands
 'extensions',
 ]



To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D917: eol: make [eol] config section sensitive for chg confighash

2017-10-04 Thread quark (Jun Wu) 
quark updated this revision to Diff 2453.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D917?vs=2372=2453

REVISION DETAIL
  https://phab.mercurial-scm.org/D917

AFFECTED FILES
  mercurial/chgserver.py

CHANGE DETAILS

diff --git a/mercurial/chgserver.py b/mercurial/chgserver.py
--- a/mercurial/chgserver.py
+++ b/mercurial/chgserver.py
@@ -68,6 +68,7 @@
 # sensitive config sections affecting confighash
 _configsections = [
 'alias',  # affects global state commands.table
+'eol',# uses setconfig('eol', ...)
 'extdiff',  # uisetup will register new commands
 'extensions',
 ]



To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D917: eol: make [eol] config section sensitive for chg confighash

2017-10-04 Thread yuja (Yuya Nishihara) 
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  It's a core extension. Let's simply add it to chgserver.py.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D917

To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D917: eol: make [eol] config section sensitive for chg confighash

2017-10-02 Thread quark (Jun Wu) 
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The eol extension may mangle the [eol] config section and that means chg is
  unable to detect config file change (because it re-applies setconfig
  changes).
  
  This makes test-eol.t pass with chg.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D917

AFFECTED FILES
  hgext/eol.py

CHANGE DETAILS

diff --git a/hgext/eol.py b/hgext/eol.py
--- a/hgext/eol.py
+++ b/hgext/eol.py
@@ -97,6 +97,7 @@
 import re
 from mercurial.i18n import _
 from mercurial import (
+chgserver,
 config,
 error as errormod,
 extensions,
@@ -295,7 +296,8 @@
   "win32text extension\n"))
 except KeyError:
 pass
-
+# make [eol] sensitive for chg confighash
+chgserver._configsections.append('eol')
 
 def reposetup(ui, repo):
 uisetup(repo.ui)



To: quark, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel