Re: [PATCH] help: backout the boolean flag marking in the help for now

2016-10-09 Thread Kevin Bullock 
> On Oct 9, 2016, at 14:06, Pierre-Yves David  
> wrote:
> 
> # HG changeset patch
> # User Pierre-Yves David 
> # Date 1475975478 -7200
> #  Sun Oct 09 03:11:18 2016 +0200
> # Node ID ae009a7425ca52fdffa451506c0e47ff3750a895
> # Parent  dbcef8918bbdd8a64d9f79a37bcfa284a26f3a39
> # EXP-Topic flag.bool
> help: backout the boolean flag marking in the help for now
> 
[...]
> diff --git a/tests/test-extension.t b/tests/test-extension.t
> --- a/tests/test-extension.t
> +++ b/tests/test-extension.t
> @@ -530,19 +530,19 @@ hide outer repo
>   --cwd DIR   change working directory
>-y --noninteractivedo not prompt, automatically pick the first choice 
> for
>   all prompts
> -   -q --[no-]quietsuppress output
> -   -v --[no-]verbose  enable additional output
> +   -q --quiet suppress output
> +   -v --verbose   enable additional output

Why are these showing up in the backout? I thought the final patch that landed 
already skipped these flags--is that not true?

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] help: backout the boolean flag marking in the help for now

2016-10-09 Thread Pierre-Yves David 



On 10/09/2016 02:11 PM, Kevin Bullock wrote:

On Oct 9, 2016, at 14:06, Pierre-Yves David  
wrote:

# HG changeset patch
# User Pierre-Yves David 
# Date 1475975478 -7200
#  Sun Oct 09 03:11:18 2016 +0200
# Node ID ae009a7425ca52fdffa451506c0e47ff3750a895
# Parent  dbcef8918bbdd8a64d9f79a37bcfa284a26f3a39
# EXP-Topic flag.bool
help: backout the boolean flag marking in the help for now


[...]

diff --git a/tests/test-extension.t b/tests/test-extension.t
--- a/tests/test-extension.t
+++ b/tests/test-extension.t
@@ -530,19 +530,19 @@ hide outer repo
  --cwd DIR   change working directory
   -y --noninteractivedo not prompt, automatically pick the first choice for
  all prompts
-   -q --[no-]quietsuppress output
-   -v --[no-]verbose  enable additional output
+   -q --quiet suppress output
+   -v --verbose   enable additional output


Why are these showing up in the backout? I thought the final patch that landed 
already skipped these flags--is that not true?


The initial changeset is f3c4edfd35e1 (this fell of the description 
during the edition :-/) that changeset contains such line. I'm not sure 
why they end up being there. Does that answer your question ?


We should probably reintroduce the original hash in the description.

--
Pierre-Yves David
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] help: backout the boolean flag marking in the help for now

2016-10-13 Thread Kevin Bullock 
> On Oct 9, 2016, at 14:33, Pierre-Yves David  
> wrote:
> 
> On 10/09/2016 02:11 PM, Kevin Bullock wrote:
>>> On Oct 9, 2016, at 14:06, Pierre-Yves David 
>>>  wrote:
>>> 
>>> # HG changeset patch
>>> # User Pierre-Yves David 
>>> # Date 1475975478 -7200
>>> #  Sun Oct 09 03:11:18 2016 +0200
>>> # Node ID ae009a7425ca52fdffa451506c0e47ff3750a895
>>> # Parent  dbcef8918bbdd8a64d9f79a37bcfa284a26f3a39
>>> # EXP-Topic flag.bool
>>> help: backout the boolean flag marking in the help for now
>>> 
>> [...]
>>> diff --git a/tests/test-extension.t b/tests/test-extension.t
>>> --- a/tests/test-extension.t
>>> +++ b/tests/test-extension.t
>>> @@ -530,19 +530,19 @@ hide outer repo
>>>  --cwd DIR   change working directory
>>>   -y --noninteractivedo not prompt, automatically pick the first choice 
>>> for
>>>  all prompts
>>> -   -q --[no-]quietsuppress output
>>> -   -v --[no-]verbose  enable additional output
>>> +   -q --quiet suppress output
>>> +   -v --verbose   enable additional output
>> 
>> Why are these showing up in the backout? I thought the final patch that 
>> landed already skipped these flags--is that not true?
> 
> The initial changeset is f3c4edfd35e1 (this fell of the description during 
> the edition :-/) that changeset contains such line. I'm not sure why they end 
> up being there. Does that answer your question ?

That and looking back at  answered my 
question. It was only --help, --version, and --noninteractive that we banned 
from having a --no- variant.

> We should probably reintroduce the original hash in the description.

Yep. Queued with that fix.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel