Re: [PATCH] histedit: Show file names in multiple line format
On Sun, May 5, 2019 at 1:05 PM Feng Yu wrote: > Thanks for looking into this. > > Is there anything that I shall do from my end? > No, I don't think so. > > - Yu > > On Thu, May 2, 2019 at 7:21 PM Jordi Gutiérrez Hermoso > wrote: > >> On Thu, 2019-05-02 at 16:51 -0700, Martin von Zweigbergk wrote: >> > I've queued these mostly bases on Jordi's review. Thanks to both of you! >> >> Wait wait, I had stylistic complaints, but I couldn't get to them! Ah, >> well, I'll submit follow-ups. These patches are definite improvements. >> > ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH] histedit: Show file names in multiple line format
Thanks for looking into this. Is there anything that I shall do from my end? - Yu On Thu, May 2, 2019 at 7:21 PM Jordi Gutiérrez Hermoso wrote: > On Thu, 2019-05-02 at 16:51 -0700, Martin von Zweigbergk wrote: > > I've queued these mostly bases on Jordi's review. Thanks to both of you! > > Wait wait, I had stylistic complaints, but I couldn't get to them! Ah, > well, I'll submit follow-ups. These patches are definite improvements. > ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH] histedit: Show file names in multiple line format
On Thu, 2019-05-02 at 16:51 -0700, Martin von Zweigbergk wrote: > I've queued these mostly bases on Jordi's review. Thanks to both of you! Wait wait, I had stylistic complaints, but I couldn't get to them! Ah, well, I'll submit follow-ups. These patches are definite improvements. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH] histedit: Show file names in multiple line format
I've queued these mostly bases on Jordi's review. Thanks to both of you! On Thu, Apr 25, 2019 at 8:44 PM Yu Feng wrote: > diff --git a/hgext/histedit.py b/hgext/histedit.py > --- a/hgext/histedit.py > +++ b/hgext/histedit.py > @@ -1227,6 +1227,13 @@ def addln(win, y, x, line, color=None): > else: > win.addstr(y, x, line) > > +def _trunc_head(line, n): > +if len(line) <= n: return line > +return '> ' + line[-(n - 2):] > +def _trunc_tail(line, n): > +if len(line) <= n: return line > +return line[:n - 2] + ' >' > test-check-pylint.t points out that the lines should be broken after the colons (please install pylint to run that test in the future). I've added newlines after the colons above in flight this time. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
