[Mesa-dev] [PATCH] gm107/ir: avoid combining geometry shader stores at 0x60
This corresponds to gl_PrimitiveID and gl_Layer. When both of these are stored in a single AST.64 or AST.128 operation, then it appears as though the whole store fails. Fixes the recently extended glsl-1.50-transform-feedback-builtins piglit, and also gtf30.GL3Tests.transform_feedback.transform_feedback_builtins. The issue was reproduced on GM107 and GP108. Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index 673fcd187ca..2f46b0e886a 100644 --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp @@ -2804,6 +2804,16 @@ MemoryOpt::combineSt(Record *rec, Instruction *st) if (prog->getType() == Program::TYPE_COMPUTE && rec->rel[0]) return false; + // There's really no great place to put this in a generic manner. Seemingly + // wide stores at 0x60 don't work in GS shaders on SM50+. Don't combine + // those. + if (prog->getTarget()->getChipset() >= NVISA_GM107_CHIPSET && + prog->getType() == Program::TYPE_GEOMETRY && + st->getSrc(0)->reg.file == FILE_SHADER_OUTPUT && + rec->rel[0] == NULL && + MIN2(offRc, offSt) == 0x60) + return false; + // remove any existing load/store records for the store being merged into // the existing record. purgeRecords(st, DATA_FILE_COUNT); -- 2.24.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
Thanks Michel. I could able to submit new merge request. On 1/6/2020 2:01 PM, Michel Dänzer wrote: [CAUTION: External Email] On 2020-01-06 6:14 a.m., Sahu, Satyajit wrote: Hi Michel, I tried with git push. It is failing with below error remote: You are not allowed to push code to this project. fatal: unable to access 'https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa.git%2Fdata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=697khejIBws9CYeSvWQACsxx7oJUmOHoEkz19%2BtHSrU%3Dreserved=0': The requested URL returned error: 403 That's the main Mesa repository. You need to push to your forked repository[0] instead: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=s9U8FDMRTIvASG8bResXNrT75EHRIKCgX70o3hpiZ4c%3Dreserved=0/mesa.git [0] Make sure you did create a forked repository using the "Fork" button on https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesadata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=TXEoJ6pv6dQFHR%2Fp2XaLuarvbS7yjGgcA9KdqJk3ims%3Dreserved=0 before trying this, otherwise git push will create a non-forked project on the fly, which won't work for making MRs. -- Earthling Michel Dänzer | https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.comdata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=Pal4%2FSJHOor6d%2Bzz0eDLExbbVvmrX7Stvni3WTm9hv4%3Dreserved=0 Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
On 2020-01-06 6:14 a.m., Sahu, Satyajit wrote: > Hi Michel, > > I tried with git push. It is failing with below error > > remote: You are not allowed to push code to this project. > fatal: unable to access 'https://gitlab.freedesktop.org/mesa/mesa.git/': > The requested URL returned error: 403 That's the main Mesa repository. You need to push to your forked repository[0] instead: https://gitlab.freedesktop.org//mesa.git [0] Make sure you did create a forked repository using the "Fork" button on https://gitlab.freedesktop.org/mesa/mesa before trying this, otherwise git push will create a non-forked project on the fly, which won't work for making MRs. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
