Re: [Mesa-dev] Implementation of VK extensions for i965

[Александр Бесчасный]

Many thanks!

24.06.2018, 04:50, "Jason Ekstrand" :
> Yes, we already have support for VK_EXT_shader_viewport_index_layer.  For 
> VK_EXT_vertex_attribute_divisor, it should be trivial and I'm happy to do so 
> but there are currently no tests for it and, up until this email, we haven't 
> had any call for that.  We'll try to bump it up the priority list.
>
> --Jason
>
> On June 23, 2018 20:22:10 Александр Бесчасный  wrote:
>> I have latest available version of Mesa - 18.1.2, Vulkan - 1.1.0.
>> Can I check available extensions VK for my version?
>>
>> 24.06.2018, 03:35, "Bas Nieuwenhuizen" :
>>> Not sure about the other extension, but the latest version of the
>>> intel driver should support VK_EXT_shader_viewport_index_layer
>>> already.
>>>
>>> On Sun, Jun 24, 2018 at 1:13 AM, Александр Бесчасный  
>>> wrote:
>>>>  Hello, can I ask if it is planned to implement VK extensions for i965:
>>>>  - VK_EXT_shader_viewport_index_layer
>>>>  -
>>>>  The new version of DXVK 0.60 requires their availability.
>>>>
>>>>  ___
>>>>  mesa-dev mailing list
>>>>  mesa-dev@lists.freedesktop.org
>>>>  https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>> --
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Implementation of VK extensions for i965

[Александр Бесчасный]

I have latest available version of Mesa - 18.1.2, Vulkan - 1.1.0.Can I check available extensions VK for my version? 24.06.2018, 03:35, "Bas Nieuwenhuizen" :Not sure about the other extension, but the latest version of theintel driver should support VK_EXT_shader_viewport_index_layeralready.On Sun, Jun 24, 2018 at 1:13 AM, Александр Бесчасный <mrche...@yandex.ru> wrote: Hello, can I ask if it is planned to implement VK extensions for i965: - VK_EXT_shader_viewport_index_layer - VK_EXT_vertex_attribute_divisor The new version of DXVK 0.60 requires their availability. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev   --  ___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Implementation of VK extensions for i965

[Александр Бесчасный]

Hello, can I ask if it is planned to implement VK extensions for i965:- VK_EXT_shader_viewport_index_layer- VK_EXT_vertex_attribute_divisorThe new version of DXVK 0.60 requires their availability.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Release previous context's display

[Александр]

On 11.08.2016 11:43, Nicolas Boichat wrote:

eglMakeCurrent can also be used to change the active display. In that
case, we need to decrement ref_count of the previous display (possibly
destroying it), and increment it on the next display.

Also, old_dsurf/old_rsurf cannot be non-NULL if old_ctx is NULL, so
we only need to test if old_ctx is non-NULL.

v2: Save the old display before destroying the context.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97214
Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display)
Cc: "12.0" 
Reported-by: Alexandr Zelinsky 
Tested-by: Alexandr Zelinsky 
Signed-off-by: Nicolas Boichat 
---

Alexandr: Can you give this one another try? Thanks!

  src/egl/drivers/dri2/egl_dri2.c | 9 +
  1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 1ad6855..dde9804 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
+++ b/src/egl/drivers/dri2/egl_dri2.c
@@ -1269,13 +1269,14 @@ dri2_make_current(_EGLDriver *drv, _EGLDisplay *disp, 
_EGLSurface *dsurf,
   drv->API.DestroySurface(drv, disp, old_dsurf);
if (old_rsurf)
   drv->API.DestroySurface(drv, disp, old_rsurf);
-  if (old_ctx)
- drv->API.DestroyContext(drv, disp, old_ctx);
  
if (!unbind)

   dri2_dpy->ref_count++;
-  if (old_dsurf || old_rsurf || old_ctx)
- dri2_display_release(disp);
+  if (old_ctx) {
+ EGLDisplay old_disp = _eglGetDisplayHandle(old_ctx->Resource.Display);
+ drv->API.DestroyContext(drv, disp, old_ctx);
+ dri2_display_release(old_disp);
+  }
  
return EGL_TRUE;

 } else {

works
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Release previous context's display

[Александр]

On 10.08.2016 10:44, Michel Dänzer wrote:

On 10/08/16 03:00 PM, Nicolas Boichat wrote:

eglMakeCurrent can also be used to change the active display. In that
case, we need to decrement ref_count of the previous display (possibly
destroying it), and increment it on the next display.

Also, old_dsurf/old_rsurf cannot be non-NULL if old_ctx is NULL, so
we only need to test if old_ctx is non-NULL.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97214
Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display)
Cc: "12.0" 
Reported-by: Alexandr Zelinsky 
Tested-by: Alexandr Zelinsky 
Signed-off-by: Nicolas Boichat 
---
  src/egl/drivers/dri2/egl_dri2.c | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 3205a36..701e42a 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
+++ b/src/egl/drivers/dri2/egl_dri2.c
@@ -1285,8 +1285,10 @@ dri2_make_current(_EGLDriver *drv, _EGLDisplay *disp, 
_EGLSurface *dsurf,
  
if (!unbind)

   dri2_dpy->ref_count++;
-  if (old_dsurf || old_rsurf || old_ctx)
- dri2_display_release(disp);
+  if (old_ctx) {
+ EGLDisplay old_disp = _eglGetDisplayHandle(old_ctx->Resource.Display);
+ dri2_display_release(old_disp);
+  }

Unfortunately, this change breaks the piglit test "spec@egl
1.4@eglterminate then unbind context", because old_ctx != NULL but
old_ctx->Resource.Display == NULL. Modifying the test to

   if (old_ctx && old_ctx->Resource.Display) {

fixes the regression and doesn't seem to cause any other problems.
Alexandr, does the patch still fix your problem with that modification?


Nicolas, this regression is also reproducible with
LIBGL_ALWAYS_SOFTWARE=1 . Please get used to testing your changes like
that and only send out changes for review which don't cause any regressions.



yesstill fix the problem
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev