Re: [Mesa-dev] [PATCH][mesa-demos] configure.ac: fix AC_WITH(glut) so that --without-glut works

2015-12-07 Thread Burton, Ross
On 6 December 2015 at 13:21, Andreas Boll 
wrote:

> Do you need someone to push this for you?
>

I do, yes. Much appreciated!

Ross
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary

2013-08-06 Thread Burton, Ross
On 6 August 2013 18:23, Matt Turner  wrote:
> Use $(MKDIR_P), as previously suggested (like other Makefile.ams do).

Agreed, not sure how I forgot that variable existed.

Ross
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] build: fix out-of-tree builds in gallium/auxiliary

2013-08-06 Thread Burton, Ross
On 6 August 2013 15:35, Jonathan Gray  wrote:
> The problems with the build system are bad enough without
> depending on non posix gnu only options.
>
> This should be mkdir -p

I wish the GNU tools would say what options are POSIX :(.  V2 coming.

Ross
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary

2013-06-28 Thread Burton, Ross
On 28 June 2013 14:57, Andreas Boll  wrote:
> There is an open bug report about this issue:
> https://bugs.freedesktop.org/show_bug.cgi?id=60197
>
> Matt, could you take a look at this?
> Which patch do you prefer?

Quentin's patch is more generic as it uses $(dir), so merge that one.

Ross
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] build: fix out-of-tree builds in gallium/auxiliary

2013-06-28 Thread Burton, Ross
Hi Andreas,

Both good points, V2 sent.

Ross
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] Build fails without X11 present

2013-06-26 Thread Burton, Ross
Hi,

I'm routinely building Mesa and Weston in an environment without X11,
and currently both Mesa and Weston are failing to build for the same
reason: eglplatform.h is attempting to include X11/Xlib.h.

There was a patch last year that attempted to solve the Mesa part of this:

http://lists.freedesktop.org/archives/mesa-dev/2012-February/019554.html
(follow-up thread at
http://lists.freedesktop.org/archives/mesa-dev/2012-March/019640.html)

It had outstanding feedback and doesn't apply to master, but something
like this handles the feedback and appears to work:

--- a/configure.ac
+++ b/configure.ac
@@ -1486,6 +1486,10 @@ AM_CONDITIONAL(HAVE_EGL_PLATFORM_NULL, echo
"$egl_platforms" | grep 'null' >/dev
 AM_CONDITIONAL(HAVE_EGL_DRIVER_DRI2, test "x$HAVE_EGL_DRIVER_DRI2" != "x")
 AM_CONDITIONAL(HAVE_EGL_DRIVER_GLX, test "x$HAVE_EGL_DRIVER_GLX" != "x")

+if ! echo "$egl_platforms" | grep -q 'x11'; then
+   DEFINES="$DEFINES -DMESA_EGL_NO_X11_HEADERS"
+fi
+

--- a/include/EGL/eglplatform.h
+++ b/include/EGL/eglplatform.h
@@ -109,8 +109,8 @@ typedef void*EGLNativeDisplayType;
 #ifdef MESA_EGL_NO_X11_HEADERS

 typedef void*EGLNativeDisplayType;
-typedef khronos_uint32_t EGLNativePixmapType;
-typedef khronos_uint32_t EGLNativeWindowType;
+typedef khronos_uintptr_t EGLNativePixmapType;
+typedef khronos_uintptr_t EGLNativeWindowType;

That is, if we don't have the X11 EGL platform, when compiling Mesa
itself set MESA_EGL_NO_X11_HEADERS.  The generic types are changed
from uint32 to pointers because as Chad pointed out[1] on 64-bit
systems you'll get different pointer sizes.  If this looks right I can
send a proper patch, but I'm no expert on the details of Mesa's insane
configure.ac so this may be missing some details I'm not seeing.

Cheers,
Ross

[1] http://lists.freedesktop.org/archives/mesa-dev/2012-March/019726.html
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] build: fix --without-glut

2012-11-21 Thread Burton, Ross
On 21 November 2012 08:27, Matt Turner  wrote:
> To be clear, Mesa's GLU was a thing, but it is not this thing:
> http://cgit.freedesktop.org/mesa/glu
>
> That's SGI's GLU. I hope you're not using Mesa's GLU.

Ah, thanks.  Yes, I'm using that repository.

Ross
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] build: fix --without-glut

2012-11-20 Thread Burton, Ross
On 14 November 2012 15:38, Dan Nicholson  wrote:
> This looks pretty good except that I think you need to temporarily add
> GLUT_CFLAGS to CFLAGS and GLUT_LIBS to LIBS so that the user specified
> prefix works for AC_CHECK*. On the other hand, at least mesa glut has a
> pkg-config file, so it might be easier to just require a glut with glut.pc.
> Not sure about the other gluts though.

Yes, I think you're right about AC_CHECK, I'll fix that.

FreeGLUT at least doesn't ship glut.pc.  We could drop freeglut for
mesa/glut but then it's had commits in the last three years, unlike
mesa/glut...  Undecided.

Ross
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev