Re: [Mesa-dev] ?= [PATCH] android:=?utf-8?q? virgl: fix libmesa_virgil_common build and dependencies

2019-06-20 Thread Clayton Craft

On Thu, Jun 20, 2019 at 08:20:12AM +0100, Alexandros Frantzis wrote:

On Saturday, June 15, 2019 06:39 BST, Mauro Rossi  wrote:


Fixes the following building errors and resolves Bug 110922
Fixes gallium_dri target missing symbols at linking.


Thanks for the fix. I wonder what would be involved in adding an Android
build job in the gitlab CI. It would be nice to have a build sanity
check for people who are not set up to build for Android, and could help
avoid regressions such as this one.


The Intel Mesa CI does an android build test, that's how this issue was found :)

https://mesa-ci.01.org/mesa_master/builds/16747/group/63a9f0ea7bb98050796b649e85481845

If you'd like me to set up the CI to test a branch for you before you
push to the Mesa master branch, I just need to know:

1) Your Mesa repo location
2) Branch in repo you want CI to monitor for pushes
3) Email you want CI notifications to be sent to

-Clayton


Thanks,
Alexandros

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] ?= [PATCH] android:=?utf-8?q? virgl: fix libmesa_virgil_common build and dependencies

2019-06-20 Thread Michel Dänzer
On 2019-06-20 9:20 a.m., Alexandros Frantzis wrote:
> 
> I wonder what would be involved in adding an Android build job in the
> gitlab CI.

In a nutshell:

You'd need to add a build+test stage job for the Android build.

For the docker image used by that job, there are multiple options:

1. Maybe there's an existing official Android docker image which works
   out of the box? (Though even in that case, it might be safer to use a
   local copy of that image, in which case it becomes a simple variant
   of option 3)

2. Maybe the same Debian based image used by other jobs can be used, by
   adding the required Android build environment to it using Debian
   packages and/or more manual steps.

3. Add a containers-build stage job which checks that the docker image
   exists, and if not, generates it. Bonus points for extending
   https://gitlab.freedesktop.org/wayland/ci-templates as needed and
   using that.


-- 
Earthling Michel Dänzer   |  https://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev