[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

Brad King  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #20 from Brad King  ---
The VTK test suite passes again since these two patches were merged.  Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #19 from Bruce Cherniak  ---
The swr driver patch has been committed, as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #18 from Brian Paul  ---
The state tracker patch has been committed.
I'll leave the swr driver patch to Bruce.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #17 from Brad King  ---
After applying the two patches I can confirm that the VTK test I used to
produce the apitrace now passes again.  Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #16 from Bruce Cherniak  ---
Created attachment 133732
  --> https://bugs.freedesktop.org/attachment.cgi?id=133732=edit
Updated swr patch to fix msaa once new_patch_to_try has been applied.

Here's a patch that fixes the MSAA override validation.  "new-msaa-swr.patch"
should be included along with the "new_patch_to_try".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

Bruce Cherniak  changed:

   What|Removed |Added

 Attachment #133726|0   |1
is obsolete||

--- Comment #15 from Bruce Cherniak  ---
Comment on attachment 133726
  --> https://bugs.freedesktop.org/attachment.cgi?id=133726
Patch to fix swr after "new patch to try"

Nevermind that patch, I found a bug in validating MSAA override value. 
Updating with a new version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #14 from Bruce Cherniak  ---
Created attachment 133726
  --> https://bugs.freedesktop.org/attachment.cgi?id=133726=edit
Patch to fix swr after "new patch to try"

Hi Brian,

I found the reason that swr starts failing with your patch.  I was treating any
num_samples > 0 as msaa and turning off the fake_msaa cap.  The attached (in
conjunction with you patch) works correctly.

If this makes sense to you, will you please include it with your patch so that
we don't end up with a regression?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #13 from Bruce Cherniak  ---
Hi Brian,

This appears to fix VTK tests on llvmpipe.  However, it breaks SWR.  Please let
me see what's going on there before submitting this patch for review.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

Brian Paul  changed:

   What|Removed |Added

 Attachment #133654|0   |1
is obsolete||

--- Comment #12 from Brian Paul  ---
Created attachment 133687
  --> https://bugs.freedesktop.org/attachment.cgi?id=133687=edit
new patch to try.

Hi Bruce, here's another patch to try.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #11 from Bruce Cherniak  ---
Created attachment 133661
  --> https://bugs.freedesktop.org/attachment.cgi?id=133661=edit
simple-msaa.c

Hi Brian,

This simple msaa sample fails in the same way when run with "sample-msaa 1".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #10 from Bruce Cherniak  ---
For llvmpipe, this fails in the same way as before.  Unless
llvmpipe_is_format_supported is changed in the same way that you modified
svga_is_format_supported:

-   if (sample_count > 1)
+   if (sample_count > 0)

However, this is the change that Roland has issue with.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #9 from Brian Paul  ---
Created attachment 133654
  --> https://bugs.freedesktop.org/attachment.cgi?id=133654=edit
proposed patch

Bruce, can you try the attached patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #8 from Bruce Cherniak  ---
Roland, you are correct, VTK is trying to use msaa surfaces with just one
sample.

Here's what's happening:

The rendertarget color buffer is being created by:
st_api_make_current
  st_framebuffer_validate
xmesa_st_frambuffer_validate_textures
  llvmpipe_resource_create
with nr_samples = 1

Then later in st_framebuffer_validate "changed" is set when the surface is
created.  This causes the following:

_mesa_resize_framebuffer  (loops until it gets to the depth attachment)
  st_renderbuffer_alloc_storage

until we get to:
160├──> if (rb->NumSamples > 0) {
161│   unsigned i;
162│
163│   for (i = MAX2(2, rb->NumSamples); i <= ctx->Const.MaxSamples; i++) {
164│  format = st_choose_renderbuffer_format(st, internalFormat, i);
165│
166│  if (format != PIPE_FORMAT_NONE) {
167│ rb->NumSamples = i;
168│ break;
169│  }
170│   }
171│} else {
172│   format = st_choose_renderbuffer_format(st, internalFormat, 0);
173│}
174│
175│/* Not setting gl_renderbuffer::Format here will cause
176│ * FRAMEBUFFER_UNSUPPORTED and ValidateFramebuffer will not be called.
177│ */
178|if (format == PIPE_FORMAT_NONE) {
179│   return GL_TRUE;
180│}

rb->NumSamples = 1, but ctx->Const.MaxSamples = 0 so the loop @ 163 is skipped
and format remains  PIPE_FORMAT_NONE.  Because to this, we don't allocate a
depth buffer and boom.

But, this works:
-   if (rb->NumSamples > 0) {
+   if (rb->NumSamples > 1) {
   unsigned i;

   for (i = MAX2(2, rb->NumSamples); i <= ctx->Const.MaxSamples; i++) {
@@ -169,7 +170,7 @@ st_renderbuffer_alloc_storage(struct gl_context * ctx,
  }
   }
} else {
-  format = st_choose_renderbuffer_format(st, internalFormat, 0);
+  format = st_choose_renderbuffer_format(st, internalFormat,
rb->NumSamples);
}

I'm not sure if it honors the original intent.  But, in addition to fixing the
VTK tests ext_framebuffer_multisample-blit-mismatched-formats now passes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #7 from Bruce Cherniak  ---
I understand that this isn't a solution, but it points to where things go
wrong.  I'll keep digging for the correct fix.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #6 from Roland Scheidegger  ---
(In reply to Bruce Cherniak from comment #5)
> Looks like a problem in llvmpipe_is_format_supported.  If should be
> returning false for all "sample_count > 0", not 1.
No, not really. In gallium there's no distinction between sample count 0 and 1
- there are no surfaces with no samples, after all. (Ordinary surfaces should
actually always have 1 sample, that 0 is allowed to is more of a historical
accident.)

Maybe VTK is trying to use msaa surfaces with just one sample, despite that the
max sample count supported we announce is 0.
Albeit I'm thinking we should have refused that configuration earlier
somewhere, if the sample_count gets upgraded later...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #5 from Bruce Cherniak  ---
Looks like a problem in llvmpipe_is_format_supported.  If should be returning
false for all "sample_count > 0", not 1.

That works for me, at least.  I'm running all VTK tests against it right now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #4 from Bruce Cherniak  ---
I was able to reproduce, but not through the trace.  It runs fine.  And, only
on llvmpipe, the swr driver doesn't fail.

Running VTK test "ctest -R TestGL2PSBillboardTextActor3D" I get a backtrace
like Brad's.

I'll dig a little deeper.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #3 from Brian Paul  ---
OK, with a patch from Bruce, swr is working for me, but I can't repro this
assertion.  Are you still seeing it, Brad?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #2 from Brian Paul  ---
Hmm, swr isn't working at all for me.  It's hanging in a swr_fence_finish()
call with everything I've tried.  Even glxinfo hangs (but elsewhere).

Maybe one of the swr developers can take a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

--- Comment #1 from Brian Paul  ---
Sorry for the breakage, Brad.

I'll try to investigate ASAP, but I'm about to leave town for a week.

I can't repro with llmvpipe, fwiw.  I suspect it may be an issue in the swr
driver.  I'm building it now, but may run out of time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102038

Bug ID: 102038
   Summary: assertion failure in update_framebuffer_size
   Product: Mesa
   Version: git
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/Gallium/swr
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: brad.k...@kitware.com
QA Contact: mesa-dev@lists.freedesktop.org

Created attachment 133247
  --> https://bugs.freedesktop.org/attachment.cgi?id=133247=edit
apitrace of test that crashes

Since commit 6839d33699 (st/mesa: fix handling of NumSamples=1 (v2),
2017-08-01) many of VTK's tests crash with Mesa with an assertion failure. 
I've attached an apitrace of one of the tests.

The test aborts with an assertion failure:

```
state_tracker/st_atom_framebuffer.c:62: update_framebuffer_size: Assertion
`surface' failed.
```

The backtrace in gdb is

```
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x77a6e3fa in __GI_abort () at abort.c:89
#2  0x77a65e37 in __assert_fail_base (fmt=, 
assertion=assertion@entry=0x7fffec7516a4 "surface", 
file=file@entry=0x7fffec751680 "state_tracker/st_atom_framebuffer.c", 
line=line@entry=62, 
function=function@entry=0x7fffec7517a0 <__PRETTY_FUNCTION__.39021>
"update_framebuffer_size") at assert.c:92
#3  0x77a65ee2 in __GI___assert_fail (
assertion=0x7fffec7516a4 "surface", 
file=0x7fffec751680 "state_tracker/st_atom_framebuffer.c", line=62, 
function=0x7fffec7517a0 <__PRETTY_FUNCTION__.39021>
"update_framebuffer_size") at assert.c:101
#4  0x7fffec336bad in update_framebuffer_size (framebuffer=0x7fffce70, 
surface=0x0) at state_tracker/st_atom_framebuffer.c:62
#5  0x7fffec336f3e in st_update_framebuffer_state (st=0x55ae3b90)
at state_tracker/st_atom_framebuffer.c:181
#6  0x7fffec33538c in st_validate_state (st=0x55ae3b90, 
pipeline=ST_PIPELINE_CLEAR) at state_tracker/st_atom.c:251
#7  0x7fffec3428ea in st_Clear (ctx=0x55abeb30, mask=18)
at state_tracker/st_cb_clear.c:411
#8  0x7fffec0a2b4a in clear (no_error=false, mask=16640,
ctx=0x55abeb30)
at main/clear.c:221
#9  _mesa_Clear (mask=16640) at main/clear.c:242
...(vtk code)...
```

For reference, I'm building Mesa as follows:

./autogen.sh \
  --prefix="$prefix" \
  --enable-debug \
  --disable-dri \
  --disable-egl \
  --disable-gbm \
  --disable-gles1 \
  --disable-gles2 \
  --disable-shared-glapi \
  --with-platforms=x11 \
  --enable-glx=gallium-xlib \
  --enable-gallium-osmesa \
  --with-gallium-drivers=swrast \
  --enable-gallium-llvm=yes \
LLVM_CONFIG=/usr/bin/llvm-config-3.8 \
  --enable-llvm-shared-libs \
  --with-gl-lib-name=MesaGL \
  --with-osmesa-lib-name=MesaOSMesa

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev