[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

Nanley Chery  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Nanley Chery  ---
This issue has been fixed by the following commit:

commit b7f493e3a60baddfcf8003a326a31f6b8be2d4ca
Author: Danylo Piliaiev 
Date:   Mon Jul 23 15:13:34 2018 +0300

arb_shader_image_load_store: Test format incompatible texture buffer

Test for the regression which happened when GL_TEXTURE_BUFFER was
allowed to have incompatible format.

v2: Removed unnecessary code duplication - use upload_image instead
 of init_level. (Francisco Jerez)
v3: Removed upload_image call because image is already called
 by init_image. (Francisco Jerez)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106465

Signed-off-by: Danylo Piliaiev 
Reviewed-by: Francisco Jerez 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

--- Comment #5 from Nanley Chery  ---
(In reply to Andrés Gómez García from comment #4)
> (In reply to Andrés Gómez García from comment #3)
> > Curro, is this fixed by?
> 
> [...]
> 
> My bad, I just realized that the report is about a missing piglit test.
> 
> In that case, shouldn't we move this report to the "piglit" product?

I'm not sure. I could see an argument for either product. 

Sometimes when fixing bugs in Mesa, we'd open reports against Mesa and require
a fix and (sometimes) a test to close the issue. In this case the fix was
already created when the bug was filed, so I just filed the issue about the
missing test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

--- Comment #4 from Andrés Gómez García  ---
(In reply to Andrés Gómez García from comment #3)
> Curro, is this fixed by?

[...]

My bad, I just realized that the report is about a missing piglit test.

In that case, shouldn't we move this report to the "piglit" product?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

Andrés Gómez García  changed:

   What|Removed |Added

 CC||ago...@igalia.com,
   ||curroje...@riseup.net

--- Comment #3 from Andrés Gómez García  ---
Curro, is this fixed by?

commit 5a6814780322988a7adee525899bca8a83907ab7
Author: Francisco Jerez 
Date:   Fri Mar 16 13:43:27 2018 -0700

Revert "mesa: simplify _mesa_is_image_unit_valid for buffers"

This reverts commit c0ed52f6146c7e24e1275451773bd47c1eda3145.  It was
preventing the image format validation from being done on buffer
textures, which is required to ensure that the application doesn't
attempt to bind a buffer texture with an internal format incompatible
with the image unit format (e.g. of different texel size), which is
not allowed by the spec (it's not allowed for *any* texture target,
whether or not there is spec wording restricting this behavior
specifically for buffer textures) and will cause the driver to
calculate texel bounds incorrectly and potentially crash instead of
the expected behavior.

Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Marek Olšák 
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106465
Reviewed-by: Nanley Chery 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

Danylo  changed:

   What|Removed |Added

 CC||danylo.pilia...@gmail.com

--- Comment #2 from Danylo  ---
Sent the test catch the problem -
https://patchwork.freedesktop.org/patch/239424/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

--- Comment #1 from Francisco Jerez  ---
It should be trivial to extend the arb_shader_image_load_store-invalid piglit
test (which already checks a similar condition for other texture targets) to
catch this problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106465

Bug ID: 106465
   Summary: No test for Image Load/Store on format-incompatible
texture buffer
   Product: Mesa
   Version: git
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Mesa core
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: nanleych...@gmail.com
QA Contact: mesa-dev@lists.freedesktop.org

>From the ARB_shader_image_load_store spec:

   If the individual texel identified for an image load, store, or atomic
   operation doesn't exist, the access is treated as invalid.  Invalid image
   loads will return zero.  Invalid image stores will have no effect.
   Invalid image atomics will not update any texture bound to the image unit
   and will return zero.  An access is considered invalid if:

 [...]

 * the internal format of the texture bound to the image unit is
   incompatible with the specified  according to Table X.3;

Mesa does not validate the format of texture buffers to ensure this behavior.
This bug is fixed with this patch:
https://patchwork.freedesktop.org/patch/211340/

There currently isn't a test in the CTS or in piglit which catches this error.
One should be written to prevent this issue from appearing in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev