[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots
https://bugs.freedesktop.org/show_bug.cgi?id=107146 GitLab Migration User changed: What|Removed |Added Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #4 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/196. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots
https://bugs.freedesktop.org/show_bug.cgi?id=107146 --- Comment #3 from Alok Hota --- (In reply to Bernhard Rosenkraenzer from comment #0) > createInstructionSimplifierPass() has been removed in LLVM. This is used in > a few places in SWR; looks like this can safely be removed because it is > always preceded by createInstructionCombiningPass() which seems to be a > superset of what createInstructionSimplifierPass() used to do. > > Fixing this just unmasks another problem though - > Intrinsic::x86_fma_vfmadd_ps_256 is gone. Not sure how to replace that > properly. I can confirm we're seeing this issue as well. (In reply to Philip Meulengracht from comment #2) > Created attachment 140731 [details] [review] > proposed patch > > See my attachment for a proposed patch - I encounted this error too and > removed the references to the vfmaddps, and I removed the SimplePass's due > to them being unnecessary. Please feel free to correct me or the patch if > it's wrong. > > Instead of the vfmaddps it will use mul add. Thanks for the patch! I'm looking into this now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots
https://bugs.freedesktop.org/show_bug.cgi?id=107146 --- Comment #2 from Philip Meulengracht --- Created attachment 140731 --> https://bugs.freedesktop.org/attachment.cgi?id=140731=edit proposed patch See my attachment for a proposed patch - I encounted this error too and removed the references to the vfmaddps, and I removed the SimplePass's due to them being unnecessary. Please feel free to correct me or the patch if it's wrong. Instead of the vfmaddps it will use mul add. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots
https://bugs.freedesktop.org/show_bug.cgi?id=107146 --- Comment #1 from Roland Scheidegger --- (In reply to Bernhard Rosenkraenzer from comment #0) > createInstructionSimplifierPass() has been removed in LLVM. This is used in > a few places in SWR; looks like this can safely be removed because it is > always preceded by createInstructionCombiningPass() which seems to be a > superset of what createInstructionSimplifierPass() used to do. > > Fixing this just unmasks another problem though - > Intrinsic::x86_fma_vfmadd_ps_256 is gone. Not sure how to replace that > properly. I believe the caller doesn't actually care if it's fma or fmul/fadd combo. In this case it should just be replaced with llvm.fmuladd - this works will all (supported by swr) llvm versions, and you don't need to distinguish in the caller if the cpu supports fma or not, llvm will automatically emit either fma or fmul/fadd. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 107146] swr doesn't compile with current LLVM 7.0 snapshots
https://bugs.freedesktop.org/show_bug.cgi?id=107146 Bug ID: 107146 Summary: swr doesn't compile with current LLVM 7.0 snapshots Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/swr Assignee: mesa-dev@lists.freedesktop.org Reporter: b...@lindev.ch QA Contact: mesa-dev@lists.freedesktop.org createInstructionSimplifierPass() has been removed in LLVM. This is used in a few places in SWR; looks like this can safely be removed because it is always preceded by createInstructionCombiningPass() which seems to be a superset of what createInstructionSimplifierPass() used to do. Fixing this just unmasks another problem though - Intrinsic::x86_fma_vfmadd_ps_256 is gone. Not sure how to replace that properly. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
