[Mesa-dev] [Bug 107275] NIR segfaults after spirv-opt

2018-08-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107275

Dylan Baker  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Dylan Baker  ---
The patch for this was merged, this should be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 107275] NIR segfaults after spirv-opt

2018-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107275

--- Comment #3 from mais...@archlinux.us ---
Yes, doesn't segfault now. Seems to work as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 107275] NIR segfaults after spirv-opt

2018-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107275

--- Comment #2 from Bas Nieuwenhuizen  ---
Does 

https://patchwork.freedesktop.org/patch/238923/

fix this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 107275] NIR segfaults after spirv-opt

2018-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107275

--- Comment #1 from mais...@archlinux.us ---
n->next is NULL here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 107275] NIR segfaults after spirv-opt

2018-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107275

Bug ID: 107275
   Summary: NIR segfaults after spirv-opt
   Product: Mesa
   Version: git
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/Vulkan/Common
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: mais...@archlinux.us
CC: airl...@freedesktop.org, chadvers...@chromium.org,
dan...@fooishbar.org, ja...@jlekstrand.net

Created attachment 140687
  --> https://bugs.freedesktop.org/attachment.cgi?id=140687&action=edit
Repro dump

I get a segfault when trying to compile a compute SPIR-V with a particular
pattern.

Repro:
git clone git://github.com/Themaister/Fossilize
cd Fossilize
git submodule update --init
mkdir build
cd build
cmake ..
make -j8
./cli/fossilize-replay fossilize.json

# Disasm
./cli/fossilize-disasm /tmp/fossilize.json --compute-pipeline 2 --target glsl
./cli/fossilize-disasm /tmp/fossilize.json --compute-pipeline 2 --target asm


Backtrace:
Fossilize INFO: Creating render pass #0
Fossilize INFO:  ... Succeeded!
Fossilize INFO: Creating compute pipeline #0
Fossilize INFO:  ... Succeeded!
Fossilize INFO: Creating compute pipeline #1
Fossilize INFO:  ... Succeeded!
Fossilize INFO: Creating compute pipeline #2

Thread 1 "fossilize-repla" received signal SIGSEGV, Segmentation fault.
0x766ed5e0 in exec_node_insert_after (n=0x56a6eb10,
after=0x56a531d0) at ../../src/compiler/glsl/list.h:164
164n->next->prev = after;
(gdb) bt
#0  0x766ed5e0 in exec_node_insert_after (n=0x56a6eb10,
after=0x56a531d0) at ../../src/compiler/glsl/list.h:164
#1  0x766ee77a in split_block_end (block=0x56a6eb10) at
nir/nir_control_flow.c:340
#2  0x766ee8ca in split_block_cursor (cursor=...,
_before=0x7fffd158, _after=0x7fffd160) at nir/nir_control_flow.c:392
#3  0x766ef39b in nir_cf_reinsert (cf_list=0x7fffd270, cursor=...)
at nir/nir_control_flow.c:716
#4  0x767219e6 in opt_peel_loop_initial_if (loop=0x569dbe60) at
nir/nir_opt_if.c:198
#5  0x7672207d in opt_if_cf_list (b=0x7fffd330,
cf_list=0x569890f8) at nir/nir_opt_if.c:372
#6  0x76722121 in nir_opt_if (shader=0x569d29a0) at
nir/nir_opt_if.c:396
#7  0x7666857b in radv_optimize_nir (shader=0x569d29a0,
optimize_conservatively=false) at radv_shader.c:143
#8  0x7666a250 in radv_shader_compile_to_nir (device=0x55a4c940,
module=0x56a68860, entrypoint_name=0x56ab7ad0 "main", 
stage=MESA_SHADER_COMPUTE, spec_info=0x0, flags=0) at radv_shader.c:318
#9  0x76660e9d in radv_create_shaders (pipeline=0x569f60a0,
device=0x55a4c940, cache=0x0, key=..., pStages=0x7fffde80, flags=0)
at radv_pipeline.c:2025
#10 0x76665160 in radv_compute_pipeline_create (_device=0x55a4c940,
_cache=0x0, pCreateInfo=0x56ab7a50, pAllocator=0x0, 
pPipeline=0x5686de20) at radv_pipeline.c:3639
#11 0x766652e5 in radv_CreateComputePipelines (_device=0x55a4c940,
pipelineCache=0x0, count=1, pCreateInfos=0x56ab7a50, pAllocator=0x0, 
pPipelines=0x5686de20) at radv_pipeline.c:3669
#12 0x7f0d in
DumbReplayer::enqueue_create_compute_pipeline(unsigned long, unsigned int,
VkComputePipelineCreateInfo const*, VkPipeline_T**) ()
#13 0x55564cfb in
Fossilize::StateReplayer::Impl::parse_compute_pipelines(Fossilize::StateCreatorInterface&,
rapidjson::GenericValue,
rapidjson::MemoryPoolAllocator > const&) ()
#14 0x55573452 in
Fossilize::StateReplayer::Impl::parse(Fossilize::StateCreatorInterface&, void
const*, unsigned long) ()
#15 0x6530 in main ()

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev