[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96517

Roland Scheidegger  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Roland Scheidegger  ---
Fixed by f4184d5450c12e107d3e41ae29e5927c75543259.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96517

--- Comment #4 from Ilia Mirkin  ---
\(In reply to Roland Scheidegger from comment #2)
> (In reply to Ilia Mirkin from comment #1)
> > This is a llvmpipe bug, see discussion starting with
> > 
> > https://lists.freedesktop.org/archives/mesa-dev/2016-June/119829.html
> 
> Well technically it's not a llvmpipe bug since the state tracker violates
> the bind flag contract. Albeit that might be hair splitting since the state

Right, all the other driver backends cope with the reality that
pipe_resource->bind is only there to lull the backend author into a false sense
of comfort, while llvmpipe drank the blue pill :)

In any case, my change is not wrong, it merely stopped dirtying constbufs when
they weren't dirty. There were plenty of ways to hit this issue without my
change. In this case, dirtying array buffers (with piglit_draw_rect) caused the
constbufs to also be marked dirty, which happened to work out in this case.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96517

--- Comment #3 from Roland Scheidegger  ---
(In reply to Roland Scheidegger from comment #2)
> tracker never did and other state trackers have to cope with it too.
Sorry, that should have been drivers here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96517

--- Comment #2 from Roland Scheidegger  ---
(In reply to Ilia Mirkin from comment #1)
> This is a llvmpipe bug, see discussion starting with
> 
> https://lists.freedesktop.org/archives/mesa-dev/2016-June/119829.html

Well technically it's not a llvmpipe bug since the state tracker violates the
bind flag contract. Albeit that might be hair splitting since the state tracker
never did and other state trackers have to cope with it too.
In any case, a fix (more a workaround) is proposed here:
https://lists.freedesktop.org/archives/mesa-dev/2016-June/120299.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96517

Ilia Mirkin  changed:

   What|Removed |Added

 CC|imir...@alum.mit.edu|

--- Comment #1 from Ilia Mirkin  ---
This is a llvmpipe bug, see discussion starting with

https://lists.freedesktop.org/archives/mesa-dev/2016-June/119829.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96517

Bug ID: 96517
   Summary: [llvmpipe] piglit
arb_uniform_buffer_object-rendering-dsa regression
   Product: Mesa
   Version: git
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
  Keywords: bisected, regression
  Severity: normal
  Priority: medium
 Component: Mesa core
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: v...@freedesktop.org
QA Contact: mesa-dev@lists.freedesktop.org
CC: imir...@alum.mit.edu, prefe...@gmx.net

mesa: 4825264f75c83576f251290547f121f066b46a70 (master 12.1.0-devel)


$ ./bin/arb_uniform_buffer_object-rendering-dsa -auto
GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT = 16
UBO ub_pos_size: index = 1, size = 16
UBO ub_color: index = 2, size = 32
UBO ub_rot: index = 0, size = 16
Probe color at (120,40)
  Expected: 0.00 1.00 0.00 0.25
  Observed: 1.00 0.00 0.00 0.501961
Probe color at (40,120)
  Expected: 0.00 0.00 1.00 0.20
  Observed: 1.00 0.00 0.00 0.501961
Probe color at (120,120)
  Expected: 1.00 1.00 1.00 1.00
  Observed: 1.00 0.00 0.00 0.501961
PIGLIT: {"result": "fail" }


6e6fd911da8a1d9cd62fe0a8a4cc0fb7bdccfe02 is the first bad commit
commit 6e6fd911da8a1d9cd62fe0a8a4cc0fb7bdccfe02
Author: Ilia Mirkin 
Date:   Sat Jun 4 13:26:46 2016 -0400

st/mesa: use buffer usage history to set dirty flags for revalidation

We were previously unconditionally doing this for arrays and ubo's, and
ignoring texture/storage/atomic buffers. Instead use the usage history
to determine which atoms need to be revalidated.

Signed-off-by: Ilia Mirkin 
Reviewed-by: Nicolai Hähnle 
Cc: "12.0" 

:04 04 8376e8592f88901d5100ed9cea8ee9d38162bbca
09bc7466f259ab6c0094f1368660f6b9ef25c481 M  src
bisect run success

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev