[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

Brian Paul  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Brian Paul  ---
Verified.  Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #9 from Mathias Fröhlich  ---
I have verified 0ad with the provided trace here, updated as requested and
pushed.
Thanks for testing and review on your side.

I assume the originator verifies and closes the bug?

Mathias

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #8 from Brian Paul  ---
(In reply to Mathias Fröhlich from comment #6)
> Created attachment 125255 [details] [review]
> Fix for an other assert in immediate mode rendering with the linux turbine
> 
> Brian,
> 
> I tried to reproduce the described problem with the linux demo and stepped
> ontpo an other assert in vbo_exec_vtx_wrap(). This assert may be related to
> the one you mentioned. With this patch applied the linux turbine demo runs
> fine on i965.
> Can you check if the windows demo gets fixed by this patch too?

Yeah, your patch seems to fix things.  Thanks!

Tested-by: Brian Paul 

As for the patch itself, I think we want to s/boolean/bool/ and maybe #include
 just to be safe.

Otherwise, Reviewed-by: Brian Paul 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #7 from Rob Clark  ---
(In reply to Mathias Fröhlich from comment #6)
> Created attachment 125255 [details] [review]
> Fix for an other assert in immediate mode rendering with the linux turbine
> 
> Rob,
> 
> The patch fixes the problem you observed with 0ad in a different way. Can
> you check if this approach also fixes your problem?

it does not seem to regress 0ad..

fwiw, if you are curious, this should reproduce my original problem (if you
revert my earlier fix and don't apply your patch)

https://people.freedesktop.org/~robclark/0ad-cycladic-archipelago.trace.xz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

Mathias Fröhlich  changed:

   What|Removed |Added

 Attachment #125104|0   |1
is obsolete||

--- Comment #6 from Mathias Fröhlich  ---
Created attachment 125255
  --> https://bugs.freedesktop.org/attachment.cgi?id=125255=edit
Fix for an other assert in immediate mode rendering with the linux turbine

Brian,

I tried to reproduce the described problem with the linux demo and stepped
ontpo an other assert in vbo_exec_vtx_wrap(). This assert may be related to the
one you mentioned. With this patch applied the linux turbine demo runs fine on
i965.
Can you check if the windows demo gets fixed by this patch too?

Rob,

The patch fixes the problem you observed with 0ad in a different way. Can you
check if this approach also fixes your problem?

Thanks

Mathias

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #5 from Mathias Fröhlich  ---
Or Can you provide an apitrace?
I have no such system to reproduce at hands.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #4 from Mathias Fröhlich  ---
The remaining thing that I could see to get into this situation would be that 
newSize is equal to zero on entry to in vbo_exec_wrap_upgrade_vertex.
The only case where I could not rule out newSize being zero just now is with
evaluators.
If this is our problem, the attached patch may bring us to a backtrace that
matters.
Can you help me verify that the above thought heads into the right direction?

Mathias

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #3 from Mathias Fröhlich  ---
Created attachment 125104
  --> https://bugs.freedesktop.org/attachment.cgi?id=125104=edit
Patch for debugging

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #2 from Brian Paul  ---
(In reply to Rob Clark from comment #1)
> Do you still see the issue after 64d35f81 "vbo: fix attr reset"?

Yes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

--- Comment #1 from Rob Clark  ---
Do you still see the issue after 64d35f81 "vbo: fix attr reset"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

Rob Clark  changed:

   What|Removed |Added

 CC||robcl...@freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

Brian Paul  changed:

   What|Removed |Added

 CC||mathias.froehl...@web.de

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=96950

Bug ID: 96950
   Summary: Another regression from bc4e0c486: vbo: Use a bitmask
to track the active arrays in vbo_exec*.
   Product: Mesa
   Version: unspecified
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Mesa core
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: bri...@vmware.com
QA Contact: mesa-dev@lists.freedesktop.org

I'm seeing a failed assertion at vbo_exec_api.c:183 that started with commit
bc4e0c486.  It occurs with Redway3D's Turbine demo (I think it's Windows only).

I've taken a quick look but haven't found the cause.  I may take a look in a
week when I'm back from vacation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev