Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
Am Freitag, den 07.11.2014, 01:19 -0800 schrieb Matt Turner: On Fri, Nov 7, 2014 at 1:07 AM, Thierry Vignaud thierry.vign...@gmail.com wrote: On 5 November 2014 04:44, Matt Turner matts...@gmail.com wrote: I tried to reproduce this today and couldn't. (...) Thanks. Maybe you could give a little more information, like an error message or something? Same error as Thierry reported in this thread in August: Unfortunately Thierry's was from a re-run of make, so it wasn't useful. No It wasn't a re-run! It was a clean build in our build system with make -jXX with XX auto set to the number of cores and is always reproducable given enough cores Oh, weird. I've gone over this all and can't spot the problem. The dependencies look fine. I tried automake-1.13 and 1.14, and make-3.82 and 4.0. Maybe I'll have more luck on a 40 core system. As already explained, in order to be able to reproduce, you must either have a large system or force make -j to a high value (eg: -j24) Did you see the rest of the thread where I said I couldn't reproduce on a 40 core system? Perhaps someone who can reproduce could try to take a look? Ok, here is what happens: This failure is only reproducible with the following config options: --disable-shared-glapi --disable-gles1 --disable-gles2 Which makes it pretty obvious what is to be blamed here. With those options set no installable libraries will be build below src/mapi, the only target is a static glapi.la. As lib_LTLIBRARIES is empty in that case the install-mesa-links target has no dependencies and gets executed immediately. This fails as it races with the compilation to create the .libs dir. As the install-mesa-links target works perfectly fine with an empty lib_LTLIBRARIES the fix is simply to not depends on the .libs directory for the state file of this target. A patch is on the list. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Thu, Feb 19, 2015 at 5:53 AM, Lucas Stach l.st...@pengutronix.de wrote: Am Freitag, den 07.11.2014, 01:19 -0800 schrieb Matt Turner: On Fri, Nov 7, 2014 at 1:07 AM, Thierry Vignaud thierry.vign...@gmail.com wrote: On 5 November 2014 04:44, Matt Turner matts...@gmail.com wrote: I tried to reproduce this today and couldn't. (...) Thanks. Maybe you could give a little more information, like an error message or something? Same error as Thierry reported in this thread in August: Unfortunately Thierry's was from a re-run of make, so it wasn't useful. No It wasn't a re-run! It was a clean build in our build system with make -jXX with XX auto set to the number of cores and is always reproducable given enough cores Oh, weird. I've gone over this all and can't spot the problem. The dependencies look fine. I tried automake-1.13 and 1.14, and make-3.82 and 4.0. Maybe I'll have more luck on a 40 core system. As already explained, in order to be able to reproduce, you must either have a large system or force make -j to a high value (eg: -j24) Did you see the rest of the thread where I said I couldn't reproduce on a 40 core system? Perhaps someone who can reproduce could try to take a look? Ok, here is what happens: This failure is only reproducible with the following config options: --disable-shared-glapi --disable-gles1 --disable-gles2 Which makes it pretty obvious what is to be blamed here. With those options set no installable libraries will be build below src/mapi, the only target is a static glapi.la. As lib_LTLIBRARIES is empty in that case the install-mesa-links target has no dependencies and gets executed immediately. This fails as it races with the compilation to create the .libs dir. As the install-mesa-links target works perfectly fine with an empty lib_LTLIBRARIES the fix is simply to not depends on the .libs directory for the state file of this target. A patch is on the list. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | Thanks Lucas. That makes a lot of sense. I never suspected that the reporters were using non-default options and forgot to say so. I'll take a look at the patch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Fri, Nov 7, 2014 at 1:07 AM, Thierry Vignaud thierry.vign...@gmail.com wrote: On 5 November 2014 04:44, Matt Turner matts...@gmail.com wrote: I tried to reproduce this today and couldn't. (...) Thanks. Maybe you could give a little more information, like an error message or something? Same error as Thierry reported in this thread in August: Unfortunately Thierry's was from a re-run of make, so it wasn't useful. No It wasn't a re-run! It was a clean build in our build system with make -jXX with XX auto set to the number of cores and is always reproducable given enough cores Oh, weird. I've gone over this all and can't spot the problem. The dependencies look fine. I tried automake-1.13 and 1.14, and make-3.82 and 4.0. Maybe I'll have more luck on a 40 core system. As already explained, in order to be able to reproduce, you must either have a large system or force make -j to a high value (eg: -j24) Did you see the rest of the thread where I said I couldn't reproduce on a 40 core system? Perhaps someone who can reproduce could try to take a look? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On 5 November 2014 04:44, Matt Turner matts...@gmail.com wrote: I tried to reproduce this today and couldn't. (...) Thanks. Maybe you could give a little more information, like an error message or something? Same error as Thierry reported in this thread in August: Unfortunately Thierry's was from a re-run of make, so it wasn't useful. No It wasn't a re-run! It was a clean build in our build system with make -jXX with XX auto set to the number of cores and is always reproducable given enough cores I've gone over this all and can't spot the problem. The dependencies look fine. I tried automake-1.13 and 1.14, and make-3.82 and 4.0. Maybe I'll have more luck on a 40 core system. As already explained, in order to be able to reproduce, you must either have a large system or force make -j to a high value (eg: -j24) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Tue, Nov 4, 2014 at 7:44 PM, Matt Turner matts...@gmail.com wrote: On Tue, Nov 4, 2014 at 8:35 AM, Ausmus, James james.aus...@intel.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Matt Turner matts...@gmail.com wrote: On Mon, Nov 3, 2014 at 7:35 PM, Ausmus, James james.aus...@intel.com wrote: I am able to reproduce this consistently with -j40 - it bisects to: Thanks. Maybe you could give a little more information, like an error message or something? Same error as Thierry reported in this thread in August: Unfortunately Thierry's was from a re-run of make, so it wasn't useful. make[4]: Entering directory `/build/x86-alex/tmp/portage/media-libs/mesa-/work/Mesa-/src/mapi' CC glapi_libglapi_la-glapi_gentable.lo CC glapi_libglapi_la-glapi_dispatch.lo CC glapi_libglapi_la-glapi_entrypoint.lo CC glapi_libglapi_la-glapi_getproc.lo CC glapi_libglapi_la-glapi_nop.lo CC glapi_libglapi_la-glapi.lo CC glapi_libglapi_la-u_current.lo CC glapi_libglapi_la-u_execmem.lo GEN.libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory make[4]: *** [.libs/install-mesa-links] Error 1 Thanks, this is perfect. I think I see what's going on now. I think the problem is related to the fact that these .la files are put into subdirectories' .libs directories, rather than into src/mapi/.libs, which we try to create a file in. The .o files are put into src/mapi/.libs, so I suspect that it's a race between writing the first one of those, and touching .libs/install-mesa-links. In install-lib-links.mk we specify the dependency of all-local : .libs/install-mesa-links to prevent us from recreating the links, and while all-local must run after all, I guess there's nothing preventing its dependencies from running before all has completed. But we do specify the dependency .libs/install-mesa-links : $(lib_LTLIBRARIES), and since those require the .lo files which must have created .libs -- it's not clear why it's not working out. It seems like this dependency isn't working. On my system, lib_LTLIBRARIES are always built before .libs/install-mesa-links, so it appears to work locally. I've gone over this all and can't spot the problem. The dependencies look fine. I tried automake-1.13 and 1.14, and make-3.82 and 4.0. Maybe I'll have more luck on a 40 core system. Even on a 40 core system it looks right and works for me: CC shared_glapi_libglapi_la-entry.lo CC shared_glapi_libglapi_la-mapi_glapi.lo CC shared_glapi_libglapi_la-stub.lo CC shared_glapi_libglapi_la-u_current.lo CC shared_glapi_libglapi_la-u_execmem.lo CC shared_glapi_libglapi_la-table.lo CC glapi_libglapi_la-glapi_gentable.lo CC glapi_libglapi_la-entry.lo CCLD shared-glapi/libglapi.la GEN .libs/install-mesa-links In any case, I'll send a patch to not put install-mesa-links in .libs, or maybe actually make the links rule depend on the links themselves if I can figure out how. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Mon, Nov 3, 2014 at 8:12 PM, Matt Turner matts...@gmail.com wrote: On Mon, Nov 3, 2014 at 7:35 PM, Ausmus, James james.aus...@intel.com wrote: I am able to reproduce this consistently with -j40 - it bisects to: Thanks. Maybe you could give a little more information, like an error message or something? Same error as Thierry reported in this thread in August: make[4]: Entering directory `/build/x86-alex/tmp/portage/media-libs/mesa-/work/Mesa-/src/mapi' CC glapi_libglapi_la-glapi_gentable.lo CC glapi_libglapi_la-glapi_dispatch.lo CC glapi_libglapi_la-glapi_entrypoint.lo CC glapi_libglapi_la-glapi_getproc.lo CC glapi_libglapi_la-glapi_nop.lo CC glapi_libglapi_la-glapi.lo CC glapi_libglapi_la-u_current.lo CC glapi_libglapi_la-u_execmem.lo GEN.libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory make[4]: *** [.libs/install-mesa-links] Error 1 make[4]: *** Waiting for unfinished jobs make[4]: Leaving directory `/build/x86-alex/tmp/portage/media-libs/mesa-/work/Mesa-/src/mapi' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/build/x86-alex/tmp/portage/media-libs/mesa-/work/Mesa-/src/mapi' make[2]: *** [all] Error 2 make[2]: Leaving directory `/build/x86-alex/tmp/portage/media-libs/mesa-/work/Mesa-/src/mapi' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/build/x86-alex/tmp/portage/media-libs/mesa-/work/Mesa-/src' make: *** [all-recursive] Error 1 -- James Ausmus Sr. Software Engineer SSG-OTC ChromeOS Integration ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Tue, Nov 4, 2014 at 8:35 AM, Ausmus, James james.aus...@intel.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Matt Turner matts...@gmail.com wrote: On Mon, Nov 3, 2014 at 7:35 PM, Ausmus, James james.aus...@intel.com wrote: I am able to reproduce this consistently with -j40 - it bisects to: Thanks. Maybe you could give a little more information, like an error message or something? Same error as Thierry reported in this thread in August: Unfortunately Thierry's was from a re-run of make, so it wasn't useful. make[4]: Entering directory `/build/x86-alex/tmp/portage/media-libs/mesa-/work/Mesa-/src/mapi' CC glapi_libglapi_la-glapi_gentable.lo CC glapi_libglapi_la-glapi_dispatch.lo CC glapi_libglapi_la-glapi_entrypoint.lo CC glapi_libglapi_la-glapi_getproc.lo CC glapi_libglapi_la-glapi_nop.lo CC glapi_libglapi_la-glapi.lo CC glapi_libglapi_la-u_current.lo CC glapi_libglapi_la-u_execmem.lo GEN.libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory make[4]: *** [.libs/install-mesa-links] Error 1 Thanks, this is perfect. I think I see what's going on now. I think the problem is related to the fact that these .la files are put into subdirectories' .libs directories, rather than into src/mapi/.libs, which we try to create a file in. The .o files are put into src/mapi/.libs, so I suspect that it's a race between writing the first one of those, and touching .libs/install-mesa-links. In install-lib-links.mk we specify the dependency of all-local : .libs/install-mesa-links to prevent us from recreating the links, and while all-local must run after all, I guess there's nothing preventing its dependencies from running before all has completed. But we do specify the dependency .libs/install-mesa-links : $(lib_LTLIBRARIES), and since those require the .lo files which must have created .libs -- it's not clear why it's not working out. It seems like this dependency isn't working. On my system, lib_LTLIBRARIES are always built before .libs/install-mesa-links, so it appears to work locally. I've gone over this all and can't spot the problem. The dependencies look fine. I tried automake-1.13 and 1.14, and make-3.82 and 4.0. Maybe I'll have more luck on a 40 core system. It's probably simple enough to put the 'install-mesa-links' file in the current directory, rather than in .libs since we're relying on libtool to create that. But I would like to understand what the heck is going on. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Thu, Oct 23, 2014 at 11:35 AM, Matt Turner matts...@gmail.com wrote: On Sun, Aug 24, 2014 at 11:51 PM, Thierry Vignaud thierry.vign...@gmail.com wrote: On 21 August 2014 17:54, Carl Worth cwo...@cworth.org wrote: I have verified building from the .tar.bz2 file by doing the following on a Debian (unstable) system: tar xjf MesaLib-10.3.0-rc1.tar.bz2 cd Mesa-10.3.0-rc1 ./configure --enable-gallium-llvm make -j6 make install Unlike previous releases, it builds smoothly with -j4 but fails with -j24: gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' GEN ../../../../src/glx/indirect_size.h gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake all-am gmake[5]: Nothing to be done for 'all-am'. Making all in . gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi' GEN .libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory Makefile:2109: recipe for target '.libs/install-mesa-links' failed gmake[4]: *** [.libs/install-mesa-links] Error 1 You've missing deps in make rules that show up when using quite a lot of cores I tried to reproduce this today and couldn't. I am able to reproduce this consistently with -j40 - it bisects to: commit c3ce1a942f90843ba637e558e990275bc742571c Author: Matt Turner matts...@gmail.com Date: Thu Aug 14 12:20:12 2014 -0700 mapi: Inline shared-glapi/Makefile. But that doesn't revert cleanly on master or the 10.3 branch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- James Ausmus Sr. Software Engineer SSG-OTC ChromeOS Integration ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Mon, Nov 3, 2014 at 7:35 PM, Ausmus, James james.aus...@intel.com wrote: I am able to reproduce this consistently with -j40 - it bisects to: Thanks. Maybe you could give a little more information, like an error message or something? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Sun, Aug 24, 2014 at 11:51 PM, Thierry Vignaud thierry.vign...@gmail.com wrote: On 21 August 2014 17:54, Carl Worth cwo...@cworth.org wrote: I have verified building from the .tar.bz2 file by doing the following on a Debian (unstable) system: tar xjf MesaLib-10.3.0-rc1.tar.bz2 cd Mesa-10.3.0-rc1 ./configure --enable-gallium-llvm make -j6 make install Unlike previous releases, it builds smoothly with -j4 but fails with -j24: gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' GEN ../../../../src/glx/indirect_size.h gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake all-am gmake[5]: Nothing to be done for 'all-am'. Making all in . gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi' GEN .libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory Makefile:2109: recipe for target '.libs/install-mesa-links' failed gmake[4]: *** [.libs/install-mesa-links] Error 1 You've missing deps in make rules that show up when using quite a lot of cores I tried to reproduce this today and couldn't. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On 25/08/14 07:51, Thierry Vignaud wrote: On 21 August 2014 17:54, Carl Worth cwo...@cworth.org wrote: I have verified building from the .tar.bz2 file by doing the following on a Debian (unstable) system: tar xjf MesaLib-10.3.0-rc1.tar.bz2 cd Mesa-10.3.0-rc1 ./configure --enable-gallium-llvm make -j6 make install Unlike previous releases, it builds smoothly with -j4 but fails with -j24: gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' GEN ../../../../src/glx/indirect_size.h gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake all-am gmake[5]: Nothing to be done for 'all-am'. Making all in . gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi' GEN .libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory Makefile:2109: recipe for target '.libs/install-mesa-links' failed gmake[4]: *** [.libs/install-mesa-links] Error 1 You've missing deps in make rules that show up when using quite a lot of cores Matt it seems like doing the right thing does not always pay-off :\ Can you take a look at this when you have the chance, pretty please ? -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On Tue, Aug 26, 2014 at 3:37 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 25/08/14 07:51, Thierry Vignaud wrote: On 21 August 2014 17:54, Carl Worth cwo...@cworth.org wrote: I have verified building from the .tar.bz2 file by doing the following on a Debian (unstable) system: tar xjf MesaLib-10.3.0-rc1.tar.bz2 cd Mesa-10.3.0-rc1 ./configure --enable-gallium-llvm make -j6 make install Unlike previous releases, it builds smoothly with -j4 but fails with -j24: gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' GEN ../../../../src/glx/indirect_size.h gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake all-am gmake[5]: Nothing to be done for 'all-am'. Making all in . gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi' GEN .libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory Makefile:2109: recipe for target '.libs/install-mesa-links' failed gmake[4]: *** [.libs/install-mesa-links] Error 1 You've missing deps in make rules that show up when using quite a lot of cores Matt it seems like doing the right thing does not always pay-off :\ Can you take a look at this when you have the chance, pretty please ? -Emil Perfect. I've needed a reason for my manager to get me a 24-core box for a while. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-announce] Mesa 10.3 release candidate 1
On 21 August 2014 17:54, Carl Worth cwo...@cworth.org wrote: I have verified building from the .tar.bz2 file by doing the following on a Debian (unstable) system: tar xjf MesaLib-10.3.0-rc1.tar.bz2 cd Mesa-10.3.0-rc1 ./configure --enable-gallium-llvm make -j6 make install Unlike previous releases, it builds smoothly with -j4 but fails with -j24: gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' GEN ../../../../src/glx/indirect_size.h gmake[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi/glapi/gen' gmake all-am gmake[5]: Nothing to be done for 'all-am'. Making all in . gmake[4]: Entering directory '/home/iurt/rpmbuild/BUILD/Mesa-10.3.0-rc1/build-osmesa/src/mapi' GEN .libs/install-mesa-links touch: cannot touch '.libs/install-mesa-links': No such file or directory Makefile:2109: recipe for target '.libs/install-mesa-links' failed gmake[4]: *** [.libs/install-mesa-links] Error 1 You've missing deps in make rules that show up when using quite a lot of cores ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
