Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-05-05 Thread Emil Velikov 
Hi all,

On 16 April 2015 at 21:06, Daniel Stone dan...@fooishbar.org wrote:
 Hi,

 On 9 April 2015 at 17:20, Kristian Høgsberg k...@bitplanet.net wrote:
 On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov emil.l.veli...@gmail.com 
 wrote:
 Hi all,

 Can we get a pair of eyes on this patch please ?

 Reviewed-by: Kristian Høgsberg k...@bitplanet.net

 Thanks for the reminder.

 Mind you, this does break 75b7e1df13, which explicitly removes them in
 order to 'fix' (scare quotes in original) a conformance test. That
 commit also made our lives harder with
 https://bugs.freedesktop.org/show_bug.cgi?id=67676 for which the
 suggested fix was a separate EGL_XXX_transparent_alpha extension, but
 between the two of these, it does seem like a more nuanced fix might
 be in order.

 Not being able to choose between XRGB and ARGB formats in the GBM
 backend does actually impair our ability to hoist ARGB content to
 planes, so at the very least, we'd need to duplicate ARGB
 driver_configs in the EGLConfig list: one for an ARGB native visual
 ID, and one for XRGB.

 Any thoughts?

 Cheers,
 Daniel

 Kristian


 Boyan
 For the future can you please include the CC mesa-stable line in the
 commit message. It will make things a bit more obvious as I'm pursing
 through the list :-)

 Thanks
 Emil

 On 25 March 2015 at 11:36, Boyan Ding boyan.j.d...@gmail.com wrote:
 Some application, such as drm backend of weston, uses XRGB config as
 default. i965 doesn't provide this format, but before commit 65c8965d,
 the drm platform of EGL takes ARGB as XRGB. Now that commit
 65c8965d makes EGL recognize format correctly so weston won't start
 because it can't find XRGB. Add XRGB format to i965 just as
 other drivers do.

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
 Signed-off-by: Boyan Ding boyan.j.d...@gmail.com
 ---
  src/mesa/drivers/dri/i965/intel_screen.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

 diff --git a/src/mesa/drivers/dri/i965/intel_screen.c 
 b/src/mesa/drivers/dri/i965/intel_screen.c
 index 3640b67..2b82c33 100644
 --- a/src/mesa/drivers/dri/i965/intel_screen.c
 +++ b/src/mesa/drivers/dri/i965/intel_screen.c
 @@ -1126,7 +1126,8 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
  {
 static const mesa_format formats[] = {
MESA_FORMAT_B5G6R5_UNORM,
 -  MESA_FORMAT_B8G8R8A8_UNORM
 +  MESA_FORMAT_B8G8R8A8_UNORM,
 +  MESA_FORMAT_B8G8R8X8_UNORM
 };

 /* GLX_SWAP_COPY_OML is not supported due to page flipping. */
 --
 2.3.3


I've pushed the patch with Kristian's review. Hopefully this won't
cause any regressions in the conformance tests, considering the driver
has seen many improvements since commit 75b7e1df13 (back in 2013).
Alternatively one with access to the test suite can take a closer
look.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-04-27 Thread Pekka Paalanen 
On Thu, 16 Apr 2015 21:06:27 +0100
Daniel Stone dan...@fooishbar.org wrote:

 Hi,
 
 On 9 April 2015 at 17:20, Kristian Høgsberg k...@bitplanet.net wrote:
  On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov emil.l.veli...@gmail.com 
  wrote:
  Hi all,
 
  Can we get a pair of eyes on this patch please ?
 
  Reviewed-by: Kristian Høgsberg k...@bitplanet.net
 
  Thanks for the reminder.
 
 Mind you, this does break 75b7e1df13, which explicitly removes them in
 order to 'fix' (scare quotes in original) a conformance test. That
 commit also made our lives harder with
 https://bugs.freedesktop.org/show_bug.cgi?id=67676 for which the
 suggested fix was a separate EGL_XXX_transparent_alpha extension, but
 between the two of these, it does seem like a more nuanced fix might
 be in order.
 
 Not being able to choose between XRGB and ARGB formats in the GBM
 backend does actually impair our ability to hoist ARGB content to
 planes, so at the very least, we'd need to duplicate ARGB
 driver_configs in the EGLConfig list: one for an ARGB native visual
 ID, and one for XRGB.
 
 Any thoughts?

Dear Intel developers,

humble ping? Any advice on what the proper course of action is?

To me it seems like the issue still exists; not being able to run
Weston/DRM on Intel would be a bit awkward.


Thanks,
pq

  Boyan
  For the future can you please include the CC mesa-stable line in the
  commit message. It will make things a bit more obvious as I'm pursing
  through the list :-)
 
  Thanks
  Emil
 
  On 25 March 2015 at 11:36, Boyan Ding boyan.j.d...@gmail.com wrote:
  Some application, such as drm backend of weston, uses XRGB config as
  default. i965 doesn't provide this format, but before commit 65c8965d,
  the drm platform of EGL takes ARGB as XRGB. Now that commit
  65c8965d makes EGL recognize format correctly so weston won't start
  because it can't find XRGB. Add XRGB format to i965 just as
  other drivers do.
 
  Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
  Signed-off-by: Boyan Ding boyan.j.d...@gmail.com
  ---
   src/mesa/drivers/dri/i965/intel_screen.c | 3 ++-
   1 file changed, 2 insertions(+), 1 deletion(-)
 
  diff --git a/src/mesa/drivers/dri/i965/intel_screen.c 
  b/src/mesa/drivers/dri/i965/intel_screen.c
  index 3640b67..2b82c33 100644
  --- a/src/mesa/drivers/dri/i965/intel_screen.c
  +++ b/src/mesa/drivers/dri/i965/intel_screen.c
  @@ -1126,7 +1126,8 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
   {
  static const mesa_format formats[] = {
 MESA_FORMAT_B5G6R5_UNORM,
  -  MESA_FORMAT_B8G8R8A8_UNORM
  +  MESA_FORMAT_B8G8R8A8_UNORM,
  +  MESA_FORMAT_B8G8R8X8_UNORM
  };
 
  /* GLX_SWAP_COPY_OML is not supported due to page flipping. */
  --
  2.3.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-04-16 Thread Daniel Stone 
Hi,

On 9 April 2015 at 17:20, Kristian Høgsberg k...@bitplanet.net wrote:
 On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov emil.l.veli...@gmail.com 
 wrote:
 Hi all,

 Can we get a pair of eyes on this patch please ?

 Reviewed-by: Kristian Høgsberg k...@bitplanet.net

 Thanks for the reminder.

Mind you, this does break 75b7e1df13, which explicitly removes them in
order to 'fix' (scare quotes in original) a conformance test. That
commit also made our lives harder with
https://bugs.freedesktop.org/show_bug.cgi?id=67676 for which the
suggested fix was a separate EGL_XXX_transparent_alpha extension, but
between the two of these, it does seem like a more nuanced fix might
be in order.

Not being able to choose between XRGB and ARGB formats in the GBM
backend does actually impair our ability to hoist ARGB content to
planes, so at the very least, we'd need to duplicate ARGB
driver_configs in the EGLConfig list: one for an ARGB native visual
ID, and one for XRGB.

Any thoughts?

Cheers,
Daniel

 Kristian


 Boyan
 For the future can you please include the CC mesa-stable line in the
 commit message. It will make things a bit more obvious as I'm pursing
 through the list :-)

 Thanks
 Emil

 On 25 March 2015 at 11:36, Boyan Ding boyan.j.d...@gmail.com wrote:
 Some application, such as drm backend of weston, uses XRGB config as
 default. i965 doesn't provide this format, but before commit 65c8965d,
 the drm platform of EGL takes ARGB as XRGB. Now that commit
 65c8965d makes EGL recognize format correctly so weston won't start
 because it can't find XRGB. Add XRGB format to i965 just as
 other drivers do.

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
 Signed-off-by: Boyan Ding boyan.j.d...@gmail.com
 ---
  src/mesa/drivers/dri/i965/intel_screen.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

 diff --git a/src/mesa/drivers/dri/i965/intel_screen.c 
 b/src/mesa/drivers/dri/i965/intel_screen.c
 index 3640b67..2b82c33 100644
 --- a/src/mesa/drivers/dri/i965/intel_screen.c
 +++ b/src/mesa/drivers/dri/i965/intel_screen.c
 @@ -1126,7 +1126,8 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
  {
 static const mesa_format formats[] = {
MESA_FORMAT_B5G6R5_UNORM,
 -  MESA_FORMAT_B8G8R8A8_UNORM
 +  MESA_FORMAT_B8G8R8A8_UNORM,
 +  MESA_FORMAT_B8G8R8X8_UNORM
 };

 /* GLX_SWAP_COPY_OML is not supported due to page flipping. */
 --
 2.3.3

 ___
 mesa-stable mailing list
 mesa-sta...@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-stable
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-04-09 Thread Kristian Høgsberg 
On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov emil.l.veli...@gmail.com wrote:
 Hi all,

 Can we get a pair of eyes on this patch please ?

Reviewed-by: Kristian Høgsberg k...@bitplanet.net

Thanks for the reminder.

Kristian


 Boyan
 For the future can you please include the CC mesa-stable line in the
 commit message. It will make things a bit more obvious as I'm pursing
 through the list :-)

 Thanks
 Emil

 On 25 March 2015 at 11:36, Boyan Ding boyan.j.d...@gmail.com wrote:
 Some application, such as drm backend of weston, uses XRGB config as
 default. i965 doesn't provide this format, but before commit 65c8965d,
 the drm platform of EGL takes ARGB as XRGB. Now that commit
 65c8965d makes EGL recognize format correctly so weston won't start
 because it can't find XRGB. Add XRGB format to i965 just as
 other drivers do.

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
 Signed-off-by: Boyan Ding boyan.j.d...@gmail.com
 ---
  src/mesa/drivers/dri/i965/intel_screen.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

 diff --git a/src/mesa/drivers/dri/i965/intel_screen.c 
 b/src/mesa/drivers/dri/i965/intel_screen.c
 index 3640b67..2b82c33 100644
 --- a/src/mesa/drivers/dri/i965/intel_screen.c
 +++ b/src/mesa/drivers/dri/i965/intel_screen.c
 @@ -1126,7 +1126,8 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
  {
 static const mesa_format formats[] = {
MESA_FORMAT_B5G6R5_UNORM,
 -  MESA_FORMAT_B8G8R8A8_UNORM
 +  MESA_FORMAT_B8G8R8A8_UNORM,
 +  MESA_FORMAT_B8G8R8X8_UNORM
 };

 /* GLX_SWAP_COPY_OML is not supported due to page flipping. */
 --
 2.3.3

 ___
 mesa-stable mailing list
 mesa-sta...@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-stable
 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-04-08 Thread Emil Velikov 
Hi all,

Can we get a pair of eyes on this patch please ?

Boyan
For the future can you please include the CC mesa-stable line in the
commit message. It will make things a bit more obvious as I'm pursing
through the list :-)

Thanks
Emil

On 25 March 2015 at 11:36, Boyan Ding boyan.j.d...@gmail.com wrote:
 Some application, such as drm backend of weston, uses XRGB config as
 default. i965 doesn't provide this format, but before commit 65c8965d,
 the drm platform of EGL takes ARGB as XRGB. Now that commit
 65c8965d makes EGL recognize format correctly so weston won't start
 because it can't find XRGB. Add XRGB format to i965 just as
 other drivers do.

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
 Signed-off-by: Boyan Ding boyan.j.d...@gmail.com
 ---
  src/mesa/drivers/dri/i965/intel_screen.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

 diff --git a/src/mesa/drivers/dri/i965/intel_screen.c 
 b/src/mesa/drivers/dri/i965/intel_screen.c
 index 3640b67..2b82c33 100644
 --- a/src/mesa/drivers/dri/i965/intel_screen.c
 +++ b/src/mesa/drivers/dri/i965/intel_screen.c
 @@ -1126,7 +1126,8 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
  {
 static const mesa_format formats[] = {
MESA_FORMAT_B5G6R5_UNORM,
 -  MESA_FORMAT_B8G8R8A8_UNORM
 +  MESA_FORMAT_B8G8R8A8_UNORM,
 +  MESA_FORMAT_B8G8R8X8_UNORM
 };

 /* GLX_SWAP_COPY_OML is not supported due to page flipping. */
 --
 2.3.3

 ___
 mesa-stable mailing list
 mesa-sta...@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-stable
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev