Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: ensure RM is set
On Tue, Oct 13, 2015 at 3:25 AM, Emil Velikov wrote: > On 10 October 2015 at 07:42, Jonathan Gray wrote: >> GNU make predefines RM to rm -f but this is not required by POSIX >> so ensure that RM is set. This fixes "make clean" on OpenBSD. >> >> v2: use AC_CHECK_PROG >> > I'm ambivalent if we go the AC_CHECK_PROG vs ?= route. > > I'll let others pick their favourite, but both are > Reviewed-by: Emil Velikov I think AC_CHECK_PROG is the way to go. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: ensure RM is set
On Tue, Oct 13, 2015 at 11:25:08AM +0100, Emil Velikov wrote: > On 10 October 2015 at 07:42, Jonathan Gray wrote: > > GNU make predefines RM to rm -f but this is not required by POSIX > > so ensure that RM is set. This fixes "make clean" on OpenBSD. > > > > v2: use AC_CHECK_PROG > > > I'm ambivalent if we go the AC_CHECK_PROG vs ?= route. > > I'll let others pick their favourite, but both are > Reviewed-by: Emil Velikov > > -Emil The ?= diff was a screwup as that syntax is valid in make but not shell. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: ensure RM is set
On 10 October 2015 at 07:42, Jonathan Gray wrote: > GNU make predefines RM to rm -f but this is not required by POSIX > so ensure that RM is set. This fixes "make clean" on OpenBSD. > > v2: use AC_CHECK_PROG > I'm ambivalent if we go the AC_CHECK_PROG vs ?= route. I'll let others pick their favourite, but both are Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
