Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary
On Tue, Aug 6, 2013 at 7:51 AM, Ross Burton ross.bur...@intel.com wrote: The rules were writing files to e.g. util/u_indices_gen.py, but in an out-of-tree build this directory doesn't exist in the build directory. So, create the directories just in case. NOTE: This is a candidate for the stable branches. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Ross Burton ross.bur...@intel.com --- src/gallium/auxiliary/Makefile.am |4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/Makefile.am b/src/gallium/auxiliary/Makefile.am index f14279b..d785f5a 100644 --- a/src/gallium/auxiliary/Makefile.am +++ b/src/gallium/auxiliary/Makefile.am @@ -38,13 +38,17 @@ libgallium_la_SOURCES += \ endif indices/u_indices_gen.c: $(srcdir)/indices/u_indices_gen.py + mkdir -p indices Use $(MKDIR_P), as previously suggested (like other Makefile.ams do). ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary
On 6 August 2013 18:23, Matt Turner matts...@gmail.com wrote: Use $(MKDIR_P), as previously suggested (like other Makefile.ams do). Agreed, not sure how I forgot that variable existed. Ross ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary
The rules were writing files to e.g. util/u_indices_gen.py, but in an out-of-tree build this directory doesn't exist in the build directory. So, create the directories just in case. Note: This patch is a candidate for the 9.0 and 9.1 branches. Signed-off-by: Ross Burton ross.bur...@intel.com --- src/gallium/auxiliary/Makefile.am |4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/Makefile.am b/src/gallium/auxiliary/Makefile.am index f14279b..670e124 100644 --- a/src/gallium/auxiliary/Makefile.am +++ b/src/gallium/auxiliary/Makefile.am @@ -38,13 +38,17 @@ libgallium_la_SOURCES += \ endif indices/u_indices_gen.c: $(srcdir)/indices/u_indices_gen.py + $(MKDIR_P) indices $(AM_V_GEN) $(PYTHON2) $ $@ indices/u_unfilled_gen.c: $(srcdir)/indices/u_unfilled_gen.py + $(MKDIR_P) indices $(AM_V_GEN) $(PYTHON2) $ $@ util/u_format_srgb.c: $(srcdir)/util/u_format_srgb.py + $(MKDIR_P) util $(AM_V_GEN) $(PYTHON2) $ $@ util/u_format_table.c: $(srcdir)/util/u_format_table.py $(srcdir)/util/u_format_pack.py $(srcdir)/util/u_format_parse.py $(srcdir)/util/u_format.csv + $(MKDIR_P) util $(AM_V_GEN) $(PYTHON2) $(srcdir)/util/u_format_table.py $(srcdir)/util/u_format.csv $@ -- 1.7.10.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary
There is an open bug report about this issue: https://bugs.freedesktop.org/show_bug.cgi?id=60197 Matt, could you take a look at this? Which patch do you prefer? 2013/6/28 Ross Burton ross.bur...@intel.com The rules were writing files to e.g. util/u_indices_gen.py, but in an out-of-tree build this directory doesn't exist in the build directory. So, create the directories just in case. Note: This patch is a candidate for the 9.0 and 9.1 branches. 9.0 is still mentioned. Signed-off-by: Ross Burton ross.bur...@intel.com --- src/gallium/auxiliary/Makefile.am |4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/Makefile.am b/src/gallium/auxiliary/Makefile.am index f14279b..670e124 100644 --- a/src/gallium/auxiliary/Makefile.am +++ b/src/gallium/auxiliary/Makefile.am @@ -38,13 +38,17 @@ libgallium_la_SOURCES += \ endif indices/u_indices_gen.c: $(srcdir)/indices/u_indices_gen.py + $(MKDIR_P) indices $(AM_V_GEN) $(PYTHON2) $ $@ indices/u_unfilled_gen.c: $(srcdir)/indices/u_unfilled_gen.py + $(MKDIR_P) indices $(AM_V_GEN) $(PYTHON2) $ $@ util/u_format_srgb.c: $(srcdir)/util/u_format_srgb.py + $(MKDIR_P) util $(AM_V_GEN) $(PYTHON2) $ $@ util/u_format_table.c: $(srcdir)/util/u_format_table.py $(srcdir)/util/u_format_pack.py $(srcdir)/util/u_format_parse.py $(srcdir)/util/u_format.csv + $(MKDIR_P) util $(AM_V_GEN) $(PYTHON2) $(srcdir)/util/u_format_table.py $(srcdir)/util/u_format.csv $@ -- 1.7.10.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH][V2] build: fix out-of-tree builds in gallium/auxiliary
On 28 June 2013 14:57, Andreas Boll andreas.boll@gmail.com wrote: There is an open bug report about this issue: https://bugs.freedesktop.org/show_bug.cgi?id=60197 Matt, could you take a look at this? Which patch do you prefer? Quentin's patch is more generic as it uses $(dir), so merge that one. Ross ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
