Re: [Mesa-dev] [PATCH] [v2] i965/bxt: Production thread counts
Assuming the URB sizes mean the sensible thing (didn't we just clean that
up?):
Reviewed-by: Jason Ekstrand
I'm a little wary of the URB size since the bspec actually gives a range.
Might be better to drop it to 128 just to be safe. I guess if we find a
problem, we can always push a patch to stable to drop it to 128. Do what
you'd like.
--Jason
On Fri, Feb 12, 2016 at 9:53 PM, Ben Widawsky
wrote:
> v2: Forgot to squash in the comment removal
>
> Signed-off-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/brw_device_info.c | 19 +--
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c
> b/src/mesa/drivers/dri/i965/brw_device_info.c
> index 7ab70fe..55c4d36 100644
> --- a/src/mesa/drivers/dri/i965/brw_device_info.c
> +++ b/src/mesa/drivers/dri/i965/brw_device_info.c
> @@ -384,20 +384,19 @@ static const struct brw_device_info
> brw_device_info_bxt = {
> .gt = 1,
> .has_llc = false,
>
> - /* XXX: These are preliminary thread counts and URB sizes. */
> .num_slices = 1,
> - .max_vs_threads = 56,
> - .max_hs_threads = 56,
> - .max_ds_threads = 56,
> - .max_gs_threads = 56,
> + .max_vs_threads = 112,
> + .max_hs_threads = 112,
> + .max_ds_threads = 112,
> + .max_gs_threads = 112,
> .max_wm_threads = 64 * 3,
> - .max_cs_threads = 28,
> + .max_cs_threads = 6 * 6,
> .urb = {
> - .size = 64,
> + .size = 192,
>.min_vs_entries = 34,
> - .max_vs_entries = 640,
> - .max_hs_entries = 80,
> - .max_ds_entries = 80,
> + .max_vs_entries = 704,
> + .max_hs_entries = 256,
> + .max_ds_entries = 416,
>.max_gs_entries = 256,
> }
> };
> --
> 2.7.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] [v2] i965/bxt: Production thread counts
Reviewed-by: Mark Janes
Ben Widawsky writes:
> v2: Forgot to squash in the comment removal
>
> Signed-off-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/brw_device_info.c | 19 +--
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c
> b/src/mesa/drivers/dri/i965/brw_device_info.c
> index 7ab70fe..55c4d36 100644
> --- a/src/mesa/drivers/dri/i965/brw_device_info.c
> +++ b/src/mesa/drivers/dri/i965/brw_device_info.c
> @@ -384,20 +384,19 @@ static const struct brw_device_info brw_device_info_bxt
> = {
> .gt = 1,
> .has_llc = false,
>
> - /* XXX: These are preliminary thread counts and URB sizes. */
> .num_slices = 1,
> - .max_vs_threads = 56,
> - .max_hs_threads = 56,
> - .max_ds_threads = 56,
> - .max_gs_threads = 56,
> + .max_vs_threads = 112,
> + .max_hs_threads = 112,
> + .max_ds_threads = 112,
> + .max_gs_threads = 112,
> .max_wm_threads = 64 * 3,
> - .max_cs_threads = 28,
> + .max_cs_threads = 6 * 6,
> .urb = {
> - .size = 64,
> + .size = 192,
>.min_vs_entries = 34,
> - .max_vs_entries = 640,
> - .max_hs_entries = 80,
> - .max_ds_entries = 80,
> + .max_vs_entries = 704,
> + .max_hs_entries = 256,
> + .max_ds_entries = 416,
>.max_gs_entries = 256,
> }
> };
> --
> 2.7.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] [v2] i965/bxt: Production thread counts
v2: Forgot to squash in the comment removal
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_device_info.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c
b/src/mesa/drivers/dri/i965/brw_device_info.c
index 7ab70fe..55c4d36 100644
--- a/src/mesa/drivers/dri/i965/brw_device_info.c
+++ b/src/mesa/drivers/dri/i965/brw_device_info.c
@@ -384,20 +384,19 @@ static const struct brw_device_info brw_device_info_bxt =
{
.gt = 1,
.has_llc = false,
- /* XXX: These are preliminary thread counts and URB sizes. */
.num_slices = 1,
- .max_vs_threads = 56,
- .max_hs_threads = 56,
- .max_ds_threads = 56,
- .max_gs_threads = 56,
+ .max_vs_threads = 112,
+ .max_hs_threads = 112,
+ .max_ds_threads = 112,
+ .max_gs_threads = 112,
.max_wm_threads = 64 * 3,
- .max_cs_threads = 28,
+ .max_cs_threads = 6 * 6,
.urb = {
- .size = 64,
+ .size = 192,
.min_vs_entries = 34,
- .max_vs_entries = 640,
- .max_hs_entries = 80,
- .max_ds_entries = 80,
+ .max_vs_entries = 704,
+ .max_hs_entries = 256,
+ .max_ds_entries = 416,
.max_gs_entries = 256,
}
};
--
2.7.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
