Re: [Mesa-dev] [PATCH] Delete unused functions in format parser

2015-07-29 Thread Neil Roberts
Looks good to me.

Reviewed-by: Neil Roberts 

- Neil

Anuj Phogat  writes:

> Signed-off-by: Anuj Phogat 
> Cc: Neil Roberts 
> ---
>  src/mesa/main/format_parser.py | 7 ---
>  1 file changed, 7 deletions(-)
>
> diff --git a/src/mesa/main/format_parser.py b/src/mesa/main/format_parser.py
> index 11184f7..799b14f 100755
> --- a/src/mesa/main/format_parser.py
> +++ b/src/mesa/main/format_parser.py
> @@ -40,9 +40,6 @@ SRGB = 'srgb'
>  YUV = 'yuv'
>  ZS = 'zs'
>  
> -def is_power_of_two(x):
> -   return not bool(x & (x - 1))
> -
>  VERY_LARGE = 999
>  
>  class Channel:
> @@ -100,10 +97,6 @@ class Channel:
>else:
>   return 1
>  
> -   def is_power_of_two(self):
> -  """Returns true if the size of this channel is a power of two."""
> -  return is_power_of_two(self.size)
> -
> def datatype(self):
>"""Returns the datatype corresponding to a channel type and size"""
>return _get_datatype(self.type, self.size)
> -- 
> 1.9.3
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] Delete unused functions in format parser

2015-07-29 Thread Anuj Phogat
Signed-off-by: Anuj Phogat 
Cc: Neil Roberts 
---
 src/mesa/main/format_parser.py | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/src/mesa/main/format_parser.py b/src/mesa/main/format_parser.py
index 11184f7..799b14f 100755
--- a/src/mesa/main/format_parser.py
+++ b/src/mesa/main/format_parser.py
@@ -40,9 +40,6 @@ SRGB = 'srgb'
 YUV = 'yuv'
 ZS = 'zs'
 
-def is_power_of_two(x):
-   return not bool(x & (x - 1))
-
 VERY_LARGE = 999
 
 class Channel:
@@ -100,10 +97,6 @@ class Channel:
   else:
  return 1
 
-   def is_power_of_two(self):
-  """Returns true if the size of this channel is a power of two."""
-  return is_power_of_two(self.size)
-
def datatype(self):
   """Returns the datatype corresponding to a channel type and size"""
   return _get_datatype(self.type, self.size)
-- 
1.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev