Re: [Mesa-dev] [PATCH] anv: fix warning about unused width variable.

[Jason Ekstrand]

On Tue, Feb 16, 2016 at 6:23 PM, Dave Airlie  wrote:

> From: Dave Airlie 
>
> We don't use width outside the debug clause here.
>

Thanks


> ---
>  src/vulkan/gen_pack_header.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/vulkan/gen_pack_header.py b/src/vulkan/gen_pack_header.py
> index 3cabb58..75c4f26 100755
> --- a/src/vulkan/gen_pack_header.py
> +++ b/src/vulkan/gen_pack_header.py
> @@ -62,11 +62,10 @@ __gen_mbo(uint32_t start, uint32_t end)
>  static inline uint64_t
>  __gen_uint(uint64_t v, uint32_t start, uint32_t end)
>  {
> -   const int width = end - start + 1;
> -
> __gen_validate_value(v);
>
>  #if DEBUG
> +   const int width = end - start + 1;
> if (width < 64) {
>const uint64_t max = (1ull << width) - 1;
>assert(v <= max);
> --
> 2.5.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: fix warning about unused width variable.

[Eduardo Lima Mitev]

On 02/17/2016 03:23 AM, Dave Airlie wrote:
> From: Dave Airlie 
> 
> We don't use width outside the debug clause here.
> ---

This issue is still valid, but patch needs rebasing. There are at least
two instances of this problem in gen7_pack.h, maybe more in the rest of
pack header generators.

Eduardo

>  src/vulkan/gen_pack_header.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/vulkan/gen_pack_header.py b/src/vulkan/gen_pack_header.py
> index 3cabb58..75c4f26 100755
> --- a/src/vulkan/gen_pack_header.py
> +++ b/src/vulkan/gen_pack_header.py
> @@ -62,11 +62,10 @@ __gen_mbo(uint32_t start, uint32_t end)
>  static inline uint64_t
>  __gen_uint(uint64_t v, uint32_t start, uint32_t end)
>  {
> -   const int width = end - start + 1;
> -
> __gen_validate_value(v);
>  
>  #if DEBUG
> +   const int width = end - start + 1;
> if (width < 64) {
>const uint64_t max = (1ull << width) - 1;
>assert(v <= max);
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] anv: fix warning about unused width variable.

[Dave Airlie]

From: Dave Airlie 

We don't use width outside the debug clause here.
---
 src/vulkan/gen_pack_header.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/vulkan/gen_pack_header.py b/src/vulkan/gen_pack_header.py
index 3cabb58..75c4f26 100755
--- a/src/vulkan/gen_pack_header.py
+++ b/src/vulkan/gen_pack_header.py
@@ -62,11 +62,10 @@ __gen_mbo(uint32_t start, uint32_t end)
 static inline uint64_t
 __gen_uint(uint64_t v, uint32_t start, uint32_t end)
 {
-   const int width = end - start + 1;
-
__gen_validate_value(v);
 
 #if DEBUG
+   const int width = end - start + 1;
if (width < 64) {
   const uint64_t max = (1ull << width) - 1;
   assert(v <= max);
-- 
2.5.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev