[Mesa-dev] [PATCH] anv: vkBindImageMemory() should return VK_ERROR_OUT_OF_{HOST, DEVICE}_MEMORY on error

2017-05-04 Thread Samuel Iglesias Gonsálvez 
Fixes returned value changed by b546c9d.

Fixes: b546c9d ("anv: anv_gem_mmap() returns MAP_FAILED as mapping error")
Signed-off-by: Samuel Iglesias Gonsálvez 
Cc: "17.0 17.1" 
---
 src/intel/vulkan/anv_image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 36f5d47e1a..55402b2557 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -365,7 +365,7 @@ VkResult anv_BindImageMemory(
device->info.has_llc ? 0 : I915_MMAP_WC);
 
   if (map == MAP_FAILED)
- return vk_error(VK_ERROR_MEMORY_MAP_FAILED);
+ return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 
   memset(map, 0, image->aux_surface.isl.size);
 
-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: vkBindImageMemory() should return VK_ERROR_OUT_OF_{HOST, DEVICE}_MEMORY on error

2017-05-04 Thread Emil Velikov 
On 4 May 2017 at 11:01, Samuel Iglesias Gonsálvez  wrote:
> Fixes returned value changed by b546c9d.
>
According to the spec we get VK_ERROR_OUT_OF_HOST_MEMORY or
VK_ERROR_OUT_OF_DEVICE_MEMORY on vkBindImageMemory failure.
I should have explicitly checked it closer :-\

> Fixes: b546c9d ("anv: anv_gem_mmap() returns MAP_FAILED as mapping error")
> Signed-off-by: Samuel Iglesias Gonsálvez 
> Cc: "17.0 17.1" 
Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: vkBindImageMemory() should return VK_ERROR_OUT_OF_{HOST, DEVICE}_MEMORY on error

2017-05-04 Thread Samuel Iglesias Gonsálvez 
On Thu, 2017-05-04 at 14:03 +0100, Emil Velikov wrote:
> On 4 May 2017 at 11:01, Samuel Iglesias Gonsálvez  om> wrote:
> > Fixes returned value changed by b546c9d.
> > 
> 
> According to the spec we get VK_ERROR_OUT_OF_HOST_MEMORY or
> VK_ERROR_OUT_OF_DEVICE_MEMORY on vkBindImageMemory failure.
> I should have explicitly checked it closer :-\
> 

Yeah, I realised it after pushing it :-/

> > Fixes: b546c9d ("anv: anv_gem_mmap() returns MAP_FAILED as mapping
> > error")
> > Signed-off-by: Samuel Iglesias Gonsálvez 
> > Cc: "17.0 17.1" 
> 
> Reviewed-by: Emil Velikov 
> 

Pushed.

Thanks!

Sam

signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev