Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-27 Thread Dylan Baker 
Quoting Emil Velikov (2018-04-27 06:12:41)
> On 26 April 2018 at 19:06, Dylan Baker  wrote:
> > Quoting Emil Velikov (2018-04-26 11:04:01)
> >> On 26 April 2018 at 18:45, Dylan Baker  wrote:
> >> > I have pretty default to short, which breaks this script.
> >> >
> >> Out of curiosity: why would you do this to yourself ;-)
> >
> > Because I use tig, so all I have to do is press enter to see the entire 
> > commit,
> > log and patch :)
> >
> tig allows you to override the show/log/etc options ;-)
> 
> Regardless, having --pretty=medium is the right thing to do.
> 
> > Dylan
> >
> >>
> >> > cc: Emil Velikov 
> >> > cc: Andres Gomez 
> >> > cc: Juan A. Suarez 
> >> > Signed-off-by: Dylan Baker 
> >> > ---
> >> >  bin/get-fixes-pick-list.sh | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
> >> > index fb7ef223820..983af0983dd 100755
> >> > --- a/bin/get-fixes-pick-list.sh
> >> > +++ b/bin/get-fixes-pick-list.sh
> >> > @@ -38,7 +38,7 @@ do
> >> >
> >> > # Place every "fixes:" tag on its own line and join with the 
> >> > next word
> >> > # on its line or a later one.
> >> > -   fixes=`git show -s $sha | tr -d "\n" | sed -e 
> >> > 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> >> > 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
> >> > +   fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 
> >> > 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> >> > 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
> >> >
> >> An on a serious note - there are plenty of places that will need this
> >> kind of fix.
> >> Pretty much any git show/log instances that do not specify --pretty.
> >>
> Since you're tweaking this script, just fixup the git log --reverse
> ... instance further up as well.
> With that the patch is:
> Reviewed-by: Emil Velikov 
> 
> Addressing the other scripts can happen at a later stage.
> 
> -Emil

Good call, the same applies to get-pick-list.sh, so I'll send out a patch for
that too.

Dylan


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-27 Thread Emil Velikov 
On 26 April 2018 at 19:06, Dylan Baker  wrote:
> Quoting Emil Velikov (2018-04-26 11:04:01)
>> On 26 April 2018 at 18:45, Dylan Baker  wrote:
>> > I have pretty default to short, which breaks this script.
>> >
>> Out of curiosity: why would you do this to yourself ;-)
>
> Because I use tig, so all I have to do is press enter to see the entire 
> commit,
> log and patch :)
>
tig allows you to override the show/log/etc options ;-)

Regardless, having --pretty=medium is the right thing to do.

> Dylan
>
>>
>> > cc: Emil Velikov 
>> > cc: Andres Gomez 
>> > cc: Juan A. Suarez 
>> > Signed-off-by: Dylan Baker 
>> > ---
>> >  bin/get-fixes-pick-list.sh | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
>> > index fb7ef223820..983af0983dd 100755
>> > --- a/bin/get-fixes-pick-list.sh
>> > +++ b/bin/get-fixes-pick-list.sh
>> > @@ -38,7 +38,7 @@ do
>> >
>> > # Place every "fixes:" tag on its own line and join with the next 
>> > word
>> > # on its line or a later one.
>> > -   fixes=`git show -s $sha | tr -d "\n" | sed -e 
>> > 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
>> > 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
>> > +   fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 
>> > 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
>> > 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
>> >
>> An on a serious note - there are plenty of places that will need this
>> kind of fix.
>> Pretty much any git show/log instances that do not specify --pretty.
>>
Since you're tweaking this script, just fixup the git log --reverse
... instance further up as well.
With that the patch is:
Reviewed-by: Emil Velikov 

Addressing the other scripts can happen at a later stage.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-27 Thread Andres Gomez 
As said by Emil, this may be the case in some others scripts.

In any case, this is:

Reviewed-by: Andres Gomez 

On Thu, 2018-04-26 at 10:45 -0700, Dylan Baker wrote:
> I have pretty default to short, which breaks this script.
> 
> cc: Emil Velikov 
> cc: Andres Gomez 
> cc: Juan A. Suarez 
> Signed-off-by: Dylan Baker 
> ---
>  bin/get-fixes-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
> index fb7ef223820..983af0983dd 100755
> --- a/bin/get-fixes-pick-list.sh
> +++ b/bin/get-fixes-pick-list.sh
> @@ -38,7 +38,7 @@ do
>  
>   # Place every "fixes:" tag on its own line and join with the next word
>   # on its line or a later one.
> - fixes=`git show -s $sha | tr -d "\n" | sed -e 
> 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
> + fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 
> 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
>  
>   # For each one try to extract the tag
>   fixes_count=`echo "$fixes" | wc -l`
-- 
Br,

Andres
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-27 Thread Andres Gomez 
On Thu, 2018-04-26 at 11:06 -0700, Dylan Baker wrote:
> Quoting Emil Velikov (2018-04-26 11:04:01)
> > On 26 April 2018 at 18:45, Dylan Baker  wrote:
> > > I have pretty default to short, which breaks this script.
> > > 
> > 
> > Out of curiosity: why would you do this to yourself ;-)
> 
> Because I use tig, so all I have to do is press enter to see the entire 
> commit,
> log and patch :)

Interesting. I didn't know this tool. I will check it.

-- 
Br,

Andres
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-26 Thread Dylan Baker 
Quoting Emil Velikov (2018-04-26 11:04:01)
> On 26 April 2018 at 18:45, Dylan Baker  wrote:
> > I have pretty default to short, which breaks this script.
> >
> Out of curiosity: why would you do this to yourself ;-)

Because I use tig, so all I have to do is press enter to see the entire commit,
log and patch :)

Dylan

> 
> > cc: Emil Velikov 
> > cc: Andres Gomez 
> > cc: Juan A. Suarez 
> > Signed-off-by: Dylan Baker 
> > ---
> >  bin/get-fixes-pick-list.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
> > index fb7ef223820..983af0983dd 100755
> > --- a/bin/get-fixes-pick-list.sh
> > +++ b/bin/get-fixes-pick-list.sh
> > @@ -38,7 +38,7 @@ do
> >
> > # Place every "fixes:" tag on its own line and join with the next 
> > word
> > # on its line or a later one.
> > -   fixes=`git show -s $sha | tr -d "\n" | sed -e 
> > 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> > 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
> > +   fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 
> > 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> > 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
> >
> An on a serious note - there are plenty of places that will need this
> kind of fix.
> Pretty much any git show/log instances that do not specify --pretty.
> 
> -Emil


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-26 Thread Emil Velikov 
On 26 April 2018 at 18:45, Dylan Baker  wrote:
> I have pretty default to short, which breaks this script.
>
Out of curiosity: why would you do this to yourself ;-)

> cc: Emil Velikov 
> cc: Andres Gomez 
> cc: Juan A. Suarez 
> Signed-off-by: Dylan Baker 
> ---
>  bin/get-fixes-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
> index fb7ef223820..983af0983dd 100755
> --- a/bin/get-fixes-pick-list.sh
> +++ b/bin/get-fixes-pick-list.sh
> @@ -38,7 +38,7 @@ do
>
> # Place every "fixes:" tag on its own line and join with the next word
> # on its line or a later one.
> -   fixes=`git show -s $sha | tr -d "\n" | sed -e 
> 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
> +   fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 
> 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
> 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
>
An on a serious note - there are plenty of places that will need this
kind of fix.
Pretty much any git show/log instances that do not specify --pretty.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-26 Thread Dylan Baker 
I have pretty default to short, which breaks this script.

cc: Emil Velikov 
cc: Andres Gomez 
cc: Juan A. Suarez 
Signed-off-by: Dylan Baker 
---
 bin/get-fixes-pick-list.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
index fb7ef223820..983af0983dd 100755
--- a/bin/get-fixes-pick-list.sh
+++ b/bin/get-fixes-pick-list.sh
@@ -38,7 +38,7 @@ do
 
# Place every "fixes:" tag on its own line and join with the next word
# on its line or a later one.
-   fixes=`git show -s $sha | tr -d "\n" | sed -e 
's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
+   fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 
's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 
's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
 
# For each one try to extract the tag
fixes_count=`echo "$fixes" | wc -l`
-- 
2.17.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev