Re: [Mesa-dev] [PATCH] configure: disable shared glapi when building xlib powered glx
On 02/27/2014 11:17 AM, Brian Paul wrote: On Thu, Feb 27, 2014 at 11:03 AM, Emil Velikov emil.l.veli...@gmail.com mailto:emil.l.veli...@gmail.com wrote: With commit 0432aa064b(configure: use shared-glapi when more than one gl* API is used) we removed disable shared-glapi when building without dri hunk. In the good old days of classic mesa, dri and xlib-glx were mutually exclusive thus the hunk made sense. Currently enable-dri is used as a synonym for a range of things thus it's more appropriate to handle xlib-glx explicitly. Fixes a missing symbol '_glapi_Dispatch' in a xlib powered libGL, build using the following ./autogen.sh --enable-xlib-glx --disable-dri --with-gallium-drivers=swrast Cc: Brian Paul bri...@vmware.com mailto:bri...@vmware.com Reported-by: Brian Paul bri...@vmware.com mailto:bri...@vmware.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com mailto:emil.l.veli...@gmail.com --- Hi Brian, Can you give this patch a try, it fixes the problem on my system. Works for me here. Thanks! Do you want to commit this, Emil? -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] configure: disable shared glapi when building xlib powered glx
On 04/03/14 02:01, Brian Paul wrote: On 02/27/2014 11:17 AM, Brian Paul wrote: On Thu, Feb 27, 2014 at 11:03 AM, Emil Velikov emil.l.veli...@gmail.com mailto:emil.l.veli...@gmail.com wrote: With commit 0432aa064b(configure: use shared-glapi when more than one gl* API is used) we removed disable shared-glapi when building without dri hunk. In the good old days of classic mesa, dri and xlib-glx were mutually exclusive thus the hunk made sense. Currently enable-dri is used as a synonym for a range of things thus it's more appropriate to handle xlib-glx explicitly. Fixes a missing symbol '_glapi_Dispatch' in a xlib powered libGL, build using the following ./autogen.sh --enable-xlib-glx --disable-dri --with-gallium-drivers=swrast Cc: Brian Paul bri...@vmware.com mailto:bri...@vmware.com Reported-by: Brian Paul bri...@vmware.com mailto:bri...@vmware.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com mailto:emil.l.veli...@gmail.com --- Hi Brian, Can you give this patch a try, it fixes the problem on my system. Works for me here. Thanks! Do you want to commit this, Emil? Strange I thought I did, but it seems that a different one landed in master - dfe8cb48fc135(configure: use enable_dri_glx local variable). I'll push the fix shortly and revert dfe8cb48fc135 as it should never have been merged. Sorry about that. -Emil -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] configure: disable shared glapi when building xlib powered glx
With commit 0432aa064b(configure: use shared-glapi when more than one gl* API is used) we removed disable shared-glapi when building without dri hunk. In the good old days of classic mesa, dri and xlib-glx were mutually exclusive thus the hunk made sense. Currently enable-dri is used as a synonym for a range of things thus it's more appropriate to handle xlib-glx explicitly. Fixes a missing symbol '_glapi_Dispatch' in a xlib powered libGL, build using the following ./autogen.sh --enable-xlib-glx --disable-dri --with-gallium-drivers=swrast Cc: Brian Paul bri...@vmware.com Reported-by: Brian Paul bri...@vmware.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- Hi Brian, Can you give this patch a try, it fixes the problem on my system. FWIW I will follow up with a cleanup patch that creates a local enable-dri-glx, that should prevent issues like that from happening again. -Emil configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure.ac b/configure.ac index 0e0fd18..5e1ac65 100644 --- a/configure.ac +++ b/configure.ac @@ -743,6 +743,12 @@ x*yes*yes*) ;; esac +# Building Xlib-GLX requires shared glapi to be disabled. +if test x$enable_xlib_glx = xyes; then +AC_MSG_NOTICE([Shared GLAPI should not used with Xlib-GLX, disabling]) +enable_shared_glapi=no +fi + AM_CONDITIONAL(HAVE_SHARED_GLAPI, test x$enable_shared_glapi = xyes) dnl -- 1.9.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] configure: disable shared glapi when building xlib powered glx
On Thu, Feb 27, 2014 at 11:03 AM, Emil Velikov emil.l.veli...@gmail.comwrote: With commit 0432aa064b(configure: use shared-glapi when more than one gl* API is used) we removed disable shared-glapi when building without dri hunk. In the good old days of classic mesa, dri and xlib-glx were mutually exclusive thus the hunk made sense. Currently enable-dri is used as a synonym for a range of things thus it's more appropriate to handle xlib-glx explicitly. Fixes a missing symbol '_glapi_Dispatch' in a xlib powered libGL, build using the following ./autogen.sh --enable-xlib-glx --disable-dri --with-gallium-drivers=swrast Cc: Brian Paul bri...@vmware.com Reported-by: Brian Paul bri...@vmware.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- Hi Brian, Can you give this patch a try, it fixes the problem on my system. Works for me here. Thanks! -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
