[Mesa-dev] [PATCH] freedreno/a2xx: silence missing case 'SHADER_COMPUTE' warning (v2)

[Francesco Ansanelli]

v2: no need for break after an unreachable (Matt Turner)
Signed-off-by: Francesco Ansanelli 
---
 src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c |2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c 
b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
index f00d5d4..fc309e8 100644
--- a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
+++ b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
@@ -111,6 +111,8 @@ static void print_export_comment(uint32_t num, enum 
shader_t type)
case 0:  name = "gl_FragColor"; break;
}
break;
+   case SHADER_COMPUTE:
+   unreachable("not reached");
}
/* if we had a symbol table here, we could look
 * up the name of the varying..
-- 
1.7.9.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] freedreno/a2xx: silence missing case 'SHADER_COMPUTE' warning

[Matt Turner]

On Tue, Jul 19, 2016 at 5:06 AM, Francesco Ansanelli
 wrote:
> ---
>  src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c |3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c 
> b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
> index f00d5d4..54b3514 100644
> --- a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
> +++ b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
> @@ -111,6 +111,9 @@ static void print_export_comment(uint32_t num, enum 
> shader_t type)
> case 0:  name = "gl_FragColor"; break;
> }
> break;
> +   case SHADER_COMPUTE:
> +   unreachable("not reached");
> +   break;

There's no need for break after an unreachable().
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] freedreno/a2xx: silence missing case 'SHADER_COMPUTE' warning

[Francesco Ansanelli]

---
 src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c |3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c 
b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
index f00d5d4..54b3514 100644
--- a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
+++ b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c
@@ -111,6 +111,9 @@ static void print_export_comment(uint32_t num, enum 
shader_t type)
case 0:  name = "gl_FragColor"; break;
}
break;
+   case SHADER_COMPUTE:
+   unreachable("not reached");
+   break;
}
/* if we had a symbol table here, we could look
 * up the name of the varying..
-- 
1.7.9.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev