Re: [Mesa-dev] [PATCH] gallium/docs: fix docs wrt ARL/ARR/FLR

2015-01-29 Thread Jose Fonseca

On 29/01/15 19:40, srol...@vmware.com wrote:

From: Roland Scheidegger 

since the address reg holds integer values, ARL/ARR do an implicit float-to-int
conversion, so clarify that. Thus it is also incorrect to say that FLR really
does the same as ARL.
---
  src/gallium/docs/source/tgsi.rst | 18 --
  1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst
index ff322e8..84b0ed6 100644
--- a/src/gallium/docs/source/tgsi.rst
+++ b/src/gallium/docs/source/tgsi.rst
@@ -48,13 +48,13 @@ used.

  .. math::

-  dst.x = \lfloor src.x\rfloor
+  dst.x = (int) \lfloor src.x\rfloor

-  dst.y = \lfloor src.y\rfloor
+  dst.y = (int) \lfloor src.y\rfloor

-  dst.z = \lfloor src.z\rfloor
+  dst.z = (int) \lfloor src.z\rfloor

-  dst.w = \lfloor src.w\rfloor
+  dst.w = (int) \lfloor src.w\rfloor


  .. opcode:: MOV - Move
@@ -313,8 +313,6 @@ This instruction replicates its result.

  .. opcode:: FLR - Floor

-This is identical to :opcode:`ARL`.
-
  .. math::

dst.x = \lfloor src.x\rfloor
@@ -637,13 +635,13 @@ This instruction replicates its result.

  .. math::

-  dst.x = round(src.x)
+  dst.x = (int) round(src.x)

-  dst.y = round(src.y)
+  dst.y = (int) round(src.y)

-  dst.z = round(src.z)
+  dst.z = (int) round(src.z)

-  dst.w = round(src.w)
+  dst.w = (int) round(src.w)


  .. opcode:: SSG - Set Sign



Looks good.

Jose
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] gallium/docs: fix docs wrt ARL/ARR/FLR

2015-01-29 Thread Alex Deucher
On Thu, Jan 29, 2015 at 2:40 PM,   wrote:
> From: Roland Scheidegger 
>
> since the address reg holds integer values, ARL/ARR do an implicit 
> float-to-int
> conversion, so clarify that. Thus it is also incorrect to say that FLR really
> does the same as ARL.

Reviewed-by: Alex Deucher 

> ---
>  src/gallium/docs/source/tgsi.rst | 18 --
>  1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/src/gallium/docs/source/tgsi.rst 
> b/src/gallium/docs/source/tgsi.rst
> index ff322e8..84b0ed6 100644
> --- a/src/gallium/docs/source/tgsi.rst
> +++ b/src/gallium/docs/source/tgsi.rst
> @@ -48,13 +48,13 @@ used.
>
>  .. math::
>
> -  dst.x = \lfloor src.x\rfloor
> +  dst.x = (int) \lfloor src.x\rfloor
>
> -  dst.y = \lfloor src.y\rfloor
> +  dst.y = (int) \lfloor src.y\rfloor
>
> -  dst.z = \lfloor src.z\rfloor
> +  dst.z = (int) \lfloor src.z\rfloor
>
> -  dst.w = \lfloor src.w\rfloor
> +  dst.w = (int) \lfloor src.w\rfloor
>
>
>  .. opcode:: MOV - Move
> @@ -313,8 +313,6 @@ This instruction replicates its result.
>
>  .. opcode:: FLR - Floor
>
> -This is identical to :opcode:`ARL`.
> -
>  .. math::
>
>dst.x = \lfloor src.x\rfloor
> @@ -637,13 +635,13 @@ This instruction replicates its result.
>
>  .. math::
>
> -  dst.x = round(src.x)
> +  dst.x = (int) round(src.x)
>
> -  dst.y = round(src.y)
> +  dst.y = (int) round(src.y)
>
> -  dst.z = round(src.z)
> +  dst.z = (int) round(src.z)
>
> -  dst.w = round(src.w)
> +  dst.w = (int) round(src.w)
>
>
>  .. opcode:: SSG - Set Sign
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] gallium/docs: fix docs wrt ARL/ARR/FLR

2015-01-29 Thread sroland
From: Roland Scheidegger 

since the address reg holds integer values, ARL/ARR do an implicit float-to-int
conversion, so clarify that. Thus it is also incorrect to say that FLR really
does the same as ARL.
---
 src/gallium/docs/source/tgsi.rst | 18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst
index ff322e8..84b0ed6 100644
--- a/src/gallium/docs/source/tgsi.rst
+++ b/src/gallium/docs/source/tgsi.rst
@@ -48,13 +48,13 @@ used.
 
 .. math::
 
-  dst.x = \lfloor src.x\rfloor
+  dst.x = (int) \lfloor src.x\rfloor
 
-  dst.y = \lfloor src.y\rfloor
+  dst.y = (int) \lfloor src.y\rfloor
 
-  dst.z = \lfloor src.z\rfloor
+  dst.z = (int) \lfloor src.z\rfloor
 
-  dst.w = \lfloor src.w\rfloor
+  dst.w = (int) \lfloor src.w\rfloor
 
 
 .. opcode:: MOV - Move
@@ -313,8 +313,6 @@ This instruction replicates its result.
 
 .. opcode:: FLR - Floor
 
-This is identical to :opcode:`ARL`.
-
 .. math::
 
   dst.x = \lfloor src.x\rfloor
@@ -637,13 +635,13 @@ This instruction replicates its result.
 
 .. math::
 
-  dst.x = round(src.x)
+  dst.x = (int) round(src.x)
 
-  dst.y = round(src.y)
+  dst.y = (int) round(src.y)
 
-  dst.z = round(src.z)
+  dst.z = (int) round(src.z)
 
-  dst.w = round(src.w)
+  dst.w = (int) round(src.w)
 
 
 .. opcode:: SSG - Set Sign
-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev