Re: [Mesa-dev] [PATCH] gallium: add new double-related shader caps to all the getters

2015-02-19 Thread Dave Airlie 
On 20 February 2015 at 14:46, Ilia Mirkin imir...@alum.mit.edu wrote:
 Missed a few drivers in the earlier changes, this should fix up all the
 ones that print unknown caps or don't have a default statement.



 +++ b/src/gallium/drivers/vc4/vc4_screen.c
 @@ -318,6 +318,10 @@ vc4_screen_get_shader_param(struct pipe_screen *pscreen, 
 unsigned shader,
  return 1;
  case PIPE_SHADER_CAP_DOUBLES:
  return 0;
 +case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
 +return 0;
 +case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
 +return 0;
  case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
  case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
  return VC4_MAX_TEXTURE_SAMPLERS;

Why does vc4 no collapse them into one return 0?

Otherwise:
Reviewed-by: Dave Airlie airl...@redhat.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium: add new double-related shader caps to all the getters

2015-02-19 Thread Ilia Mirkin 
Missed a few drivers in the earlier changes, this should fix up all the
ones that print unknown caps or don't have a default statement.

Signed-off-by: Ilia Mirkin imir...@alum.mit.edu
---
 src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++
 src/gallium/drivers/i915/i915_screen.c   | 4 
 src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 6 ++
 src/gallium/drivers/nouveau/nv50/nv50_screen.c   | 4 
 src/gallium/drivers/r300/r300_screen.c   | 4 
 src/gallium/drivers/vc4/vc4_screen.c | 4 
 6 files changed, 24 insertions(+)

diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c 
b/src/gallium/drivers/freedreno/freedreno_screen.c
index 45293e4..044b1bc 100644
--- a/src/gallium/drivers/freedreno/freedreno_screen.c
+++ b/src/gallium/drivers/freedreno/freedreno_screen.c
@@ -385,6 +385,8 @@ fd_screen_get_shader_param(struct pipe_screen *pscreen, 
unsigned shader,
return 1;
case PIPE_SHADER_CAP_SUBROUTINES:
case PIPE_SHADER_CAP_DOUBLES:
+   case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
+   case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
return 0;
case PIPE_SHADER_CAP_TGSI_SQRT_SUPPORTED:
return 1;
diff --git a/src/gallium/drivers/i915/i915_screen.c 
b/src/gallium/drivers/i915/i915_screen.c
index 5fbbcf5..dc76464 100644
--- a/src/gallium/drivers/i915/i915_screen.c
+++ b/src/gallium/drivers/i915/i915_screen.c
@@ -155,6 +155,10 @@ i915_get_shader_param(struct pipe_screen *screen, unsigned 
shader, enum pipe_sha
   case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
   case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
  return I915_TEX_UNITS;
+  case PIPE_SHADER_CAP_DOUBLES:
+  case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
+  case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
+ return 0;
   default:
  debug_printf(%s: Unknown cap %u.\n, __FUNCTION__, cap);
  return 0;
diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c 
b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
index a532e53..0fca9e0 100644
--- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
+++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
@@ -247,6 +247,9 @@ nv30_screen_get_shader_param(struct pipe_screen *pscreen, 
unsigned shader,
   case PIPE_SHADER_CAP_INDIRECT_CONST_ADDR:
   case PIPE_SHADER_CAP_SUBROUTINES:
   case PIPE_SHADER_CAP_INTEGERS:
+  case PIPE_SHADER_CAP_DOUBLES:
+  case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
+  case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
  return 0;
   default:
  debug_printf(unknown vertex shader param %d\n, param);
@@ -283,6 +286,9 @@ nv30_screen_get_shader_param(struct pipe_screen *pscreen, 
unsigned shader,
   case PIPE_SHADER_CAP_INDIRECT_TEMP_ADDR:
   case PIPE_SHADER_CAP_INDIRECT_CONST_ADDR:
   case PIPE_SHADER_CAP_SUBROUTINES:
+  case PIPE_SHADER_CAP_DOUBLES:
+  case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
+  case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
  return 0;
   default:
  debug_printf(unknown fragment shader param %d\n, param);
diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c 
b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
index 95d1e6c..ed07ba4 100644
--- a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
+++ b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
@@ -286,6 +286,10 @@ nv50_screen_get_shader_param(struct pipe_screen *pscreen, 
unsigned shader,
   /* The chip could handle more sampler views than samplers */
case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
   return MIN2(32, PIPE_MAX_SAMPLERS);
+   case PIPE_SHADER_CAP_DOUBLES:
+   case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
+   case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
+  return 0;
default:
   NOUVEAU_ERR(unknown PIPE_SHADER_CAP %d\n, param);
   return 0;
diff --git a/src/gallium/drivers/r300/r300_screen.c 
b/src/gallium/drivers/r300/r300_screen.c
index 36b2996..fca8001 100644
--- a/src/gallium/drivers/r300/r300_screen.c
+++ b/src/gallium/drivers/r300/r300_screen.c
@@ -285,6 +285,8 @@ static int r300_get_shader_param(struct pipe_screen 
*pscreen, unsigned shader, e
 case PIPE_SHADER_CAP_SUBROUTINES:
 case PIPE_SHADER_CAP_INTEGERS:
 case PIPE_SHADER_CAP_DOUBLES:
+case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
+case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
 return 0;
 case PIPE_SHADER_CAP_PREFERRED_IR:
 return PIPE_SHADER_IR_TGSI;
@@ -337,6 +339,8 @@ static int r300_get_shader_param(struct pipe_screen 
*pscreen, unsigned shader, e
 case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
 case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
 case PIPE_SHADER_CAP_DOUBLES:
+case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
+case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
 return 0;
 case PIPE_SHADER_CAP_PREFERRED_IR:

Re: [Mesa-dev] [PATCH] gallium: add new double-related shader caps to all the getters

2015-02-19 Thread Ilia Mirkin 
On Thu, Feb 19, 2015 at 11:54 PM, Dave Airlie airl...@gmail.com wrote:
 On 20 February 2015 at 14:46, Ilia Mirkin imir...@alum.mit.edu wrote:
 Missed a few drivers in the earlier changes, this should fix up all the
 ones that print unknown caps or don't have a default statement.



 +++ b/src/gallium/drivers/vc4/vc4_screen.c
 @@ -318,6 +318,10 @@ vc4_screen_get_shader_param(struct pipe_screen 
 *pscreen, unsigned shader,
  return 1;
  case PIPE_SHADER_CAP_DOUBLES:
  return 0;
 +case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
 +return 0;
 +case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
 +return 0;
  case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
  case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
  return VC4_MAX_TEXTURE_SAMPLERS;

 Why does vc4 no collapse them into one return 0?

I dunno, they're mostly split up like that, I went with the flow.


 Otherwise:
 Reviewed-by: Dave Airlie airl...@redhat.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev