Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

[Marek Olšák]

On Mon, Nov 23, 2015 at 12:41 PM, Emil Velikov  wrote:
> On 23 November 2015 at 07:57, Albert Freeman  
> wrote:
>> On 23 November 2015 at 03:17, Ilia Mirkin  wrote:
>>> On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie  wrote:
 From: Dave Airlie 

 No reason not to build this, it has no external
 requirements at the moment.
>>>
>>> Not that I object, but what's the policy around these defaults? Should
>>> we also add nouveau? freedreno? vc4?
>>>
> Yes please.
>
> For those wondering about radeonsi, i915g or ilo. The first one has
> llvm dependency which we cannot enforce onto the unaware user. With
> the latter two - while I cannot comment on their quality/completeness,
> they see almost no action (dev. wise) plus having them will bring
> serious classic vs gallium confusion.

r300 also depends on LLVM. It can be worked around by modifying
configure.ac, but you can't build r300 without llvm on x86 by default.
(the reason is that some r300 IGPs don't have vertex shaders and draw
is used instead, which is terribly slow without llvm)

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

[Emil Velikov]

On 23 November 2015 at 07:57, Albert Freeman  wrote:
> On 23 November 2015 at 03:17, Ilia Mirkin  wrote:
>> On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie  wrote:
>>> From: Dave Airlie 
>>>
>>> No reason not to build this, it has no external
>>> requirements at the moment.
>>
>> Not that I object, but what's the policy around these defaults? Should
>> we also add nouveau? freedreno? vc4?
>>
Yes please.

For those wondering about radeonsi, i915g or ilo. The first one has
llvm dependency which we cannot enforce onto the unaware user. With
the latter two - while I cannot comment on their quality/completeness,
they see almost no action (dev. wise) plus having them will bring
serious classic vs gallium confusion.

>> Of course my personal preference would be to just error the build if
>> no drivers are specified... but I guess that won't work for some
>> people?
Ideal case will be to 1) select everything regardless of dependencies
or 2) select the ones that have their dependencies resolved. I'm
leaning towards the latter, although that'll need a lot churn.

> I do agree with this, it will cause some of those people to look
> through all the gallium drivers to see which ones they need (maybe
> that will result in them using more...), reduce compilation time and
> decrease used storage space. It should also prevent people from not
> including the drivers they need (only for gallium drivers). Of course
> it will break a few peoples builds (though they will also reap the
> benefits), but almost everyone uses the flag.
>
In practise most (99%?) people building mesa provide their own drivers
list. The default list covers the remaining people, which have little
to no idea what they want/need. Thus building everything * (see note
above) is the reasonable thing to do.

Once people get the feel - "I want vc4/nouveau/etc", they can tweak
the list and get compilation time/size savings.

> The only other fair alternative is to build all the drivers, which has
> a negative impact on all those points (excluding broken builds) +
> dependency issues (other broken builds (less though: some people would
> have the required dependencies)).
>>
>>>
>>> Signed-off-by: Dave Airlie 

Dave feel free to add:

Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

[Emil Velikov]

On 23 November 2015 at 11:49, Marek Olšák  wrote:
> On Mon, Nov 23, 2015 at 12:41 PM, Emil Velikov  
> wrote:
>> On 23 November 2015 at 07:57, Albert Freeman  
>> wrote:
>>> On 23 November 2015 at 03:17, Ilia Mirkin  wrote:
 On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie  wrote:
> From: Dave Airlie 
>
> No reason not to build this, it has no external
> requirements at the moment.

 Not that I object, but what's the policy around these defaults? Should
 we also add nouveau? freedreno? vc4?

>> Yes please.
>>
>> For those wondering about radeonsi, i915g or ilo. The first one has
>> llvm dependency which we cannot enforce onto the unaware user. With
>> the latter two - while I cannot comment on their quality/completeness,
>> they see almost no action (dev. wise) plus having them will bring
>> serious classic vs gallium confusion.
>
> r300 also depends on LLVM. It can be worked around by modifying
> configure.ac, but you can't build r300 without llvm on x86 by default.
> (the reason is that some r300 IGPs don't have vertex shaders and draw
> is used instead, which is terribly slow without llvm)
>
As you pointed out the r300+llvm+x86 story is slightly different.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

[Albert Freeman]

On 23 November 2015 at 03:17, Ilia Mirkin  wrote:
> On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie  wrote:
>> From: Dave Airlie 
>>
>> No reason not to build this, it has no external
>> requirements at the moment.
>
> Not that I object, but what's the policy around these defaults? Should
> we also add nouveau? freedreno? vc4?
>
> Of course my personal preference would be to just error the build if
> no drivers are specified... but I guess that won't work for some
> people?
I do agree with this, it will cause some of those people to look
through all the gallium drivers to see which ones they need (maybe
that will result in them using more...), reduce compilation time and
decrease used storage space. It should also prevent people from not
including the drivers they need (only for gallium drivers). Of course
it will break a few peoples builds (though they will also reap the
benefits), but almost everyone uses the flag.

The only other fair alternative is to build all the drivers, which has
a negative impact on all those points (excluding broken builds) +
dependency issues (other broken builds (less though: some people would
have the required dependencies)).
>
>>
>> Signed-off-by: Dave Airlie 
>> ---
>>  configure.ac | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 120c93e..5479ba6 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -861,13 +861,13 @@ AC_ARG_ENABLE([gallium-tests],
>>  # Option for Gallium drivers
>>
>>  # Keep this in sync with the --with-gallium-drivers help string default 
>> value
>> -GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast"
>> +GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast,virgl"
>>
>>  AC_ARG_WITH([gallium-drivers],
>>  [AS_HELP_STRING([--with-gallium-drivers@<:@=DIRS...@:>@],
>>  [comma delimited Gallium drivers list, e.g.
>>  
>> "i915,ilo,nouveau,r300,r600,radeonsi,freedreno,svga,swrast,vc4,virgl"
>> -@<:@default=r300,r600,svga,swrast@:>@])],
>> +@<:@default=r300,r600,svga,swrast,virgl@:>@])],
>>  [with_gallium_drivers="$withval"],
>>  [with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT"])
>>
>> --
>> 2.4.3
>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium: build virgl by default.

[Dave Airlie]

From: Dave Airlie 

No reason not to build this, it has no external
requirements at the moment.

Signed-off-by: Dave Airlie 
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 120c93e..5479ba6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -861,13 +861,13 @@ AC_ARG_ENABLE([gallium-tests],
 # Option for Gallium drivers
 
 # Keep this in sync with the --with-gallium-drivers help string default value
-GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast"
+GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast,virgl"
 
 AC_ARG_WITH([gallium-drivers],
 [AS_HELP_STRING([--with-gallium-drivers@<:@=DIRS...@:>@],
 [comma delimited Gallium drivers list, e.g.
 "i915,ilo,nouveau,r300,r600,radeonsi,freedreno,svga,swrast,vc4,virgl"
-@<:@default=r300,r600,svga,swrast@:>@])],
+@<:@default=r300,r600,svga,swrast,virgl@:>@])],
 [with_gallium_drivers="$withval"],
 [with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT"])
 
-- 
2.4.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

[Ilia Mirkin]

On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie  wrote:
> From: Dave Airlie 
>
> No reason not to build this, it has no external
> requirements at the moment.

Not that I object, but what's the policy around these defaults? Should
we also add nouveau? freedreno? vc4?

Of course my personal preference would be to just error the build if
no drivers are specified... but I guess that won't work for some
people?

>
> Signed-off-by: Dave Airlie 
> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 120c93e..5479ba6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -861,13 +861,13 @@ AC_ARG_ENABLE([gallium-tests],
>  # Option for Gallium drivers
>
>  # Keep this in sync with the --with-gallium-drivers help string default value
> -GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast"
> +GALLIUM_DRIVERS_DEFAULT="r300,r600,svga,swrast,virgl"
>
>  AC_ARG_WITH([gallium-drivers],
>  [AS_HELP_STRING([--with-gallium-drivers@<:@=DIRS...@:>@],
>  [comma delimited Gallium drivers list, e.g.
>  "i915,ilo,nouveau,r300,r600,radeonsi,freedreno,svga,swrast,vc4,virgl"
> -@<:@default=r300,r600,svga,swrast@:>@])],
> +@<:@default=r300,r600,svga,swrast,virgl@:>@])],
>  [with_gallium_drivers="$withval"],
>  [with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT"])
>
> --
> 2.4.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev