[Mesa-dev] [PATCH] gbm: export gbm_device_is_format_supported

2014-02-27 Thread Marek Chalupa
Probably depending on compiler settings, the definition can be hidden,
so undefined reference error can be encountred during linking

https://bugs.freedesktop.org/show_bug.cgi?id=75528
---
 src/gbm/main/gbm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c
index 7a4e406..b057386 100644
--- a/src/gbm/main/gbm.c
+++ b/src/gbm/main/gbm.c
@@ -81,7 +81,7 @@ gbm_device_get_backend_name(struct gbm_device *gbm)
  *
  * \sa enum gbm_bo_format for the list of formats
  */
-int
+GBM_EXPORT int
 gbm_device_is_format_supported(struct gbm_device *gbm,
uint32_t format, uint32_t usage)
 {
-- 
1.8.4.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] gbm: export gbm_device_is_format_supported

2014-02-27 Thread Emil Velikov
On 27/02/14 08:23, Marek Chalupa wrote:
 Probably depending on compiler settings, the definition can be hidden,
 so undefined reference error can be encountred during linking
 
When building with automake, the definition will be hidden if the
compiler supports visibility flags. This was done with an earlier patch
that adds them for the gbm target. The patch is only present in master
so the stable branches are safe on that regard.

This symbol fell short when I was going through the gbm api, thanks for
catching that.

Reviewed-by: Emil Velikov emil.l.veli...@gmail.com

 https://bugs.freedesktop.org/show_bug.cgi?id=75528
 ---
  src/gbm/main/gbm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c
 index 7a4e406..b057386 100644
 --- a/src/gbm/main/gbm.c
 +++ b/src/gbm/main/gbm.c
 @@ -81,7 +81,7 @@ gbm_device_get_backend_name(struct gbm_device *gbm)
   *
   * \sa enum gbm_bo_format for the list of formats
   */
 -int
 +GBM_EXPORT int
  gbm_device_is_format_supported(struct gbm_device *gbm,
 uint32_t format, uint32_t usage)
  {
 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev