Re: [Mesa-dev] [PATCH] glsl: Initialize parse-state in constructor of lower_subroutine.

[Samuel Iglesias Gonsálvez]

Reviewed-by: Samuel Iglesias Gonsálvez sigles...@igalia.com

On Wed, 2015-07-29 at 10:53 -0700, Matt Turner wrote:
 Static analysis tools don't like partial object initializations.
 ---
  src/glsl/lower_subroutine.cpp | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/src/glsl/lower_subroutine.cpp 
 b/src/glsl/lower_subroutine.cpp
 index e45ccfe..b29912a 100644
 --- a/src/glsl/lower_subroutine.cpp
 +++ b/src/glsl/lower_subroutine.cpp
 @@ -37,7 +37,8 @@ namespace {
  
  class lower_subroutine_visitor : public ir_hierarchical_visitor {
  public:
 -   lower_subroutine_visitor()
 +   lower_subroutine_visitor(struct _mesa_glsl_parse_state *state)
 +  : state(state)
 {
this-progress = false;
 }
 @@ -52,8 +53,7 @@ public:
  bool
  lower_subroutine(exec_list *instructions, struct 
 _mesa_glsl_parse_state *state)
  {
 -   lower_subroutine_visitor v;
 -   v.state = state;
 +   lower_subroutine_visitor v(state);
 visit_list_elements(v, instructions);
 return v.progress;
  }


signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Initialize parse-state in constructor of lower_subroutine.

[Matt Turner]

Static analysis tools don't like partial object initializations.
---
 src/glsl/lower_subroutine.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/glsl/lower_subroutine.cpp b/src/glsl/lower_subroutine.cpp
index e45ccfe..b29912a 100644
--- a/src/glsl/lower_subroutine.cpp
+++ b/src/glsl/lower_subroutine.cpp
@@ -37,7 +37,8 @@ namespace {
 
 class lower_subroutine_visitor : public ir_hierarchical_visitor {
 public:
-   lower_subroutine_visitor()
+   lower_subroutine_visitor(struct _mesa_glsl_parse_state *state)
+  : state(state)
{
   this-progress = false;
}
@@ -52,8 +53,7 @@ public:
 bool
 lower_subroutine(exec_list *instructions, struct _mesa_glsl_parse_state *state)
 {
-   lower_subroutine_visitor v;
-   v.state = state;
+   lower_subroutine_visitor v(state);
visit_list_elements(v, instructions);
return v.progress;
 }
-- 
2.3.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev