Re: [Mesa-dev] [PATCH] i915: Fix black buffers when importing prime fds

2014-09-10 Thread Andreas Pokorny
Could someone take a short look?
It should be possible to validate it by looking at the other similar code
paths:
i.e look at intel_from_planar and intel_create_image_from_renderbuffer and
intel_create_image_from_name
each of those contain this call...


On Wed, Aug 27, 2014 at 9:36 AM, Andreas Pokorny 
andreas.poko...@canonical.com wrote:

 Width and Height of the imported image was never initialized from the
 imported bo.

 Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com
 ---
  src/mesa/drivers/dri/i915/intel_screen.c | 2 ++
  1 file changed, 2 insertions(+)

 diff --git a/src/mesa/drivers/dri/i915/intel_screen.c
 b/src/mesa/drivers/dri/i915/intel_screen.c
 index 3aaa45f..00d8580 100644
 --- a/src/mesa/drivers/dri/i915/intel_screen.c
 +++ b/src/mesa/drivers/dri/i915/intel_screen.c
 @@ -616,6 +616,8 @@ intel_create_image_from_fds(__DRIscreen *screen,
return NULL;
 }

 +   intel_setup_image_from_dimensions(image);
 +
 image-planar_format = f;
 for (i = 0; i  f-nplanes; i++) {
index = f-planes[i].buffer_index;
 --
 2.1.0


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] i915: Fix black buffers when importing prime fds

2014-09-03 Thread Andreas Pokorny
Hi,
I have to apologize again for the wrong tag. This fix is also needed on
10.3.

regards
Andreas


On Wed, Aug 27, 2014 at 9:36 AM, Andreas Pokorny 
andreas.poko...@canonical.com wrote:

 Width and Height of the imported image was never initialized from the
 imported bo.

 Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com
 ---
  src/mesa/drivers/dri/i915/intel_screen.c | 2 ++
  1 file changed, 2 insertions(+)

 diff --git a/src/mesa/drivers/dri/i915/intel_screen.c
 b/src/mesa/drivers/dri/i915/intel_screen.c
 index 3aaa45f..00d8580 100644
 --- a/src/mesa/drivers/dri/i915/intel_screen.c
 +++ b/src/mesa/drivers/dri/i915/intel_screen.c
 @@ -616,6 +616,8 @@ intel_create_image_from_fds(__DRIscreen *screen,
return NULL;
 }

 +   intel_setup_image_from_dimensions(image);
 +
 image-planar_format = f;
 for (i = 0; i  f-nplanes; i++) {
index = f-planes[i].buffer_index;
 --
 2.1.0


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] i915: Fix black buffers when importing prime fds

2014-08-27 Thread Andreas Pokorny
Width and Height of the imported image was never initialized from the
imported bo.

Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com
---
 src/mesa/drivers/dri/i915/intel_screen.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mesa/drivers/dri/i915/intel_screen.c 
b/src/mesa/drivers/dri/i915/intel_screen.c
index 3aaa45f..00d8580 100644
--- a/src/mesa/drivers/dri/i915/intel_screen.c
+++ b/src/mesa/drivers/dri/i915/intel_screen.c
@@ -616,6 +616,8 @@ intel_create_image_from_fds(__DRIscreen *screen,
   return NULL;
}
 
+   intel_setup_image_from_dimensions(image);
+
image-planar_format = f;
for (i = 0; i  f-nplanes; i++) {
   index = f-planes[i].buffer_index;
-- 
2.1.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev