Re: [Mesa-dev] [PATCH] i965: Drop brw_context::viewport_transform_enable.

[Kristian Høgsberg]

Reviewed-by: Kristian H. Kristensen 

On Wed, May 10, 2017 at 12:01 PM, Kenneth Graunke  wrote:
> This was used by the meta fast clear code.  Now that we've switched
> back to BLORP, it's always true.
>
> We might want it back when we add a RECTLIST extension to GL, but
> that's someday in the future...
> ---
>  src/mesa/drivers/dri/i965/brw_context.c   | 1 -
>  src/mesa/drivers/dri/i965/brw_context.h   | 1 -
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>  3 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_context.c 
> b/src/mesa/drivers/dri/i965/brw_context.c
> index 1247d0355f6..5055dd76a84 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.c
> +++ b/src/mesa/drivers/dri/i965/brw_context.c
> @@ -1126,7 +1126,6 @@ brwCreateContext(gl_api api,
> brw->prim_restart.in_progress = false;
> brw->prim_restart.enable_cut_index = false;
> brw->gs.enabled = false;
> -   brw->sf.viewport_transform_enable = true;
> brw->clip.viewport_count = 1;
>
> brw->predicate.state = BRW_PREDICATE_STATE_RENDER;
> diff --git a/src/mesa/drivers/dri/i965/brw_context.h 
> b/src/mesa/drivers/dri/i965/brw_context.h
> index 100bd74f214..1fac63225f8 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.h
> +++ b/src/mesa/drivers/dri/i965/brw_context.h
> @@ -1061,7 +1061,6 @@ struct brw_context
>uint32_t prog_offset;
>uint32_t state_offset;
>uint32_t vp_offset;
> -  bool viewport_transform_enable;
> } sf;
>
> struct {
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index b949d5b448d..bc7f068d5bb 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -1345,7 +1345,7 @@ genX(upload_sf)(struct brw_context *brw)
>
> brw_batch_emit(brw, GENX(3DSTATE_SF), sf) {
>sf.StatisticsEnable = true;
> -  sf.ViewportTransformEnable = brw->sf.viewport_transform_enable;
> +  sf.ViewportTransformEnable = true;
>
>  #if GEN_GEN == 7
>/* _NEW_BUFFERS */
> --
> 2.12.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Drop brw_context::viewport_transform_enable.

[Kenneth Graunke]

This was used by the meta fast clear code.  Now that we've switched
back to BLORP, it's always true.

We might want it back when we add a RECTLIST extension to GL, but
that's someday in the future...
---
 src/mesa/drivers/dri/i965/brw_context.c   | 1 -
 src/mesa/drivers/dri/i965/brw_context.h   | 1 -
 src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_context.c 
b/src/mesa/drivers/dri/i965/brw_context.c
index 1247d0355f6..5055dd76a84 100644
--- a/src/mesa/drivers/dri/i965/brw_context.c
+++ b/src/mesa/drivers/dri/i965/brw_context.c
@@ -1126,7 +1126,6 @@ brwCreateContext(gl_api api,
brw->prim_restart.in_progress = false;
brw->prim_restart.enable_cut_index = false;
brw->gs.enabled = false;
-   brw->sf.viewport_transform_enable = true;
brw->clip.viewport_count = 1;
 
brw->predicate.state = BRW_PREDICATE_STATE_RENDER;
diff --git a/src/mesa/drivers/dri/i965/brw_context.h 
b/src/mesa/drivers/dri/i965/brw_context.h
index 100bd74f214..1fac63225f8 100644
--- a/src/mesa/drivers/dri/i965/brw_context.h
+++ b/src/mesa/drivers/dri/i965/brw_context.h
@@ -1061,7 +1061,6 @@ struct brw_context
   uint32_t prog_offset;
   uint32_t state_offset;
   uint32_t vp_offset;
-  bool viewport_transform_enable;
} sf;
 
struct {
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
b/src/mesa/drivers/dri/i965/genX_state_upload.c
index b949d5b448d..bc7f068d5bb 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -1345,7 +1345,7 @@ genX(upload_sf)(struct brw_context *brw)
 
brw_batch_emit(brw, GENX(3DSTATE_SF), sf) {
   sf.StatisticsEnable = true;
-  sf.ViewportTransformEnable = brw->sf.viewport_transform_enable;
+  sf.ViewportTransformEnable = true;
 
 #if GEN_GEN == 7
   /* _NEW_BUFFERS */
-- 
2.12.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev