Re: [Mesa-dev] [PATCH] i965: Silence signed-unsigned int comparison warning by compiler
On Wed, Jul 29, 2015 at 9:45 AM, Matt Turner matts...@gmail.com wrote: On Tue, Jul 28, 2015 at 4:45 PM, Anuj Phogat anuj.pho...@gmail.com wrote: brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index d61bba0..970d153 100644 --- a/src/mesa/drivers/dri/i965/brw_cs.cpp +++ b/src/mesa/drivers/dri/i965/brw_cs.cpp @@ -383,7 +383,7 @@ brw_upload_cs_state(struct brw_context *brw) brw-gen = 8 ? SET_FIELD(threads, GEN8_MEDIA_GPGPU_THREAD_COUNT) : SET_FIELD(threads, MEDIA_GPGPU_THREAD_COUNT); - assert(threads = brw-max_cs_threads); + assert(threads = (unsigned) brw-max_cs_threads); desc[dw++] = media_threads; A better fix would be making max_*_threads in brw_context.h unsigned. They get initialized by fields from brw_device_info.c, which are unsigned already. Yes. That's better. I'll drop this and send out a new patch. Thanks. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] i965: Silence signed-unsigned int comparison warning by compiler
On Tue, Jul 28, 2015 at 4:45 PM, Anuj Phogat anuj.pho...@gmail.com wrote: brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index d61bba0..970d153 100644 --- a/src/mesa/drivers/dri/i965/brw_cs.cpp +++ b/src/mesa/drivers/dri/i965/brw_cs.cpp @@ -383,7 +383,7 @@ brw_upload_cs_state(struct brw_context *brw) brw-gen = 8 ? SET_FIELD(threads, GEN8_MEDIA_GPGPU_THREAD_COUNT) : SET_FIELD(threads, MEDIA_GPGPU_THREAD_COUNT); - assert(threads = brw-max_cs_threads); + assert(threads = (unsigned) brw-max_cs_threads); desc[dw++] = media_threads; A better fix would be making max_*_threads in brw_context.h unsigned. They get initialized by fields from brw_device_info.c, which are unsigned already. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] i965: Silence signed-unsigned int comparison warning by compiler
brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index d61bba0..970d153 100644 --- a/src/mesa/drivers/dri/i965/brw_cs.cpp +++ b/src/mesa/drivers/dri/i965/brw_cs.cpp @@ -383,7 +383,7 @@ brw_upload_cs_state(struct brw_context *brw) brw-gen = 8 ? SET_FIELD(threads, GEN8_MEDIA_GPGPU_THREAD_COUNT) : SET_FIELD(threads, MEDIA_GPGPU_THREAD_COUNT); - assert(threads = brw-max_cs_threads); + assert(threads = (unsigned) brw-max_cs_threads); desc[dw++] = media_threads; BEGIN_BATCH(4); -- 1.9.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] i965: Silence signed-unsigned int comparison warning by compiler
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 07/29/2015 02:45 AM, Anuj Phogat wrote: brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index d61bba0..970d153 100644 --- a/src/mesa/drivers/dri/i965/brw_cs.cpp +++ b/src/mesa/drivers/dri/i965/brw_cs.cpp @@ -383,7 +383,7 @@ brw_upload_cs_state(struct brw_context *brw) brw-gen = 8 ? SET_FIELD(threads, GEN8_MEDIA_GPGPU_THREAD_COUNT) : SET_FIELD(threads, MEDIA_GPGPU_THREAD_COUNT); - assert(threads = brw-max_cs_threads); + assert(threads = (unsigned) brw-max_cs_threads); desc[dw++] = media_threads; BEGIN_BATCH(4); ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
