Re: [Mesa-dev] [PATCH] i965: Widen sampler key bitfields for 32 samplers

2014-02-26 Thread Kenneth Graunke
On 02/26/2014 10:28 AM, Chris Forbes wrote:
> Previously the `high` 16 samplers on Haswell+ would not get sampler
> workarounds applied.
> 
> Don't bother widening YUV fields, since they're ignored and going away
> soon anyway.
> 
> Signed-off-by: Chris Forbes 
> Cc: "10.1" 

Reviewed-by: Kenneth Graunke 




signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] i965: Widen sampler key bitfields for 32 samplers

2014-02-26 Thread Chris Forbes
Previously the `high` 16 samplers on Haswell+ would not get sampler
workarounds applied.

Don't bother widening YUV fields, since they're ignored and going away
soon anyway.

Signed-off-by: Chris Forbes 
Cc: "10.1" 
Cc: Kenneth Graunke 
---
 src/mesa/drivers/dri/i965/brw_program.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_program.h 
b/src/mesa/drivers/dri/i965/brw_program.h
index 59f628b..b78ca19 100644
--- a/src/mesa/drivers/dri/i965/brw_program.h
+++ b/src/mesa/drivers/dri/i965/brw_program.h
@@ -39,7 +39,7 @@ struct brw_sampler_prog_key_data {
 */
uint16_t swizzles[MAX_SAMPLERS];
 
-   uint16_t gl_clamp_mask[3];
+   uint32_t gl_clamp_mask[3];
 
/**
 * YUV conversions, needed for the GL_MESA_ycbcr extension.
@@ -50,12 +50,12 @@ struct brw_sampler_prog_key_data {
/**
 * For RG32F, gather4's channel select is broken.
 */
-   uint16_t gather_channel_quirk_mask;
+   uint32_t gather_channel_quirk_mask;
 
/**
 * Whether this sampler uses the compressed multisample surface layout.
 */
-   uint16_t compressed_multisample_layout_mask;
+   uint32_t compressed_multisample_layout_mask;
 
/**
 * For Sandybridge, which shader w/a we need for gather quirks.
-- 
1.9.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev