Re: [Mesa-dev] [PATCH] intel/eu: Set EXECUTE_1 when setting the rounding mode in cr0

[Chema Casanova]

Thanks for fixing the full overwrite of the Control Register.

Reviewed-by: Jose Maria Casanova Crespo 

El 19/05/18 a las 05:09, Jason Ekstrand escribió:
> Fixes: d6cd14f2131a5b "i965/fs: Define new shader opcode to..."
> ---
>  src/intel/compiler/brw_eu_emit.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/intel/compiler/brw_eu_emit.c 
> b/src/intel/compiler/brw_eu_emit.c
> index 6c9dced..4f51d51 100644
> --- a/src/intel/compiler/brw_eu_emit.c
> +++ b/src/intel/compiler/brw_eu_emit.c
> @@ -3716,6 +3716,7 @@ brw_rounding_mode(struct brw_codegen *p,
> if (bits != BRW_CR0_RND_MODE_MASK) {
>brw_inst *inst = brw_AND(p, brw_cr0_reg(0), brw_cr0_reg(0),
> brw_imm_ud(~BRW_CR0_RND_MODE_MASK));
> +  brw_inst_set_exec_size(p->devinfo, inst, BRW_EXECUTE_1);
>  
>/* From the Skylake PRM, Volume 7, page 760:
> *  "Implementation Restriction on Register Access: When the control
> @@ -3730,6 +3731,7 @@ brw_rounding_mode(struct brw_codegen *p,
> if (bits) {
>brw_inst *inst = brw_OR(p, brw_cr0_reg(0), brw_cr0_reg(0),
>brw_imm_ud(bits));
> +  brw_inst_set_exec_size(p->devinfo, inst, BRW_EXECUTE_1);
>brw_inst_set_thread_control(p->devinfo, inst, BRW_THREAD_SWITCH);
> }
>  }
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] intel/eu: Set EXECUTE_1 when setting the rounding mode in cr0

[Jason Ekstrand]

Fixes: d6cd14f2131a5b "i965/fs: Define new shader opcode to..."
---
 src/intel/compiler/brw_eu_emit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c
index 6c9dced..4f51d51 100644
--- a/src/intel/compiler/brw_eu_emit.c
+++ b/src/intel/compiler/brw_eu_emit.c
@@ -3716,6 +3716,7 @@ brw_rounding_mode(struct brw_codegen *p,
if (bits != BRW_CR0_RND_MODE_MASK) {
   brw_inst *inst = brw_AND(p, brw_cr0_reg(0), brw_cr0_reg(0),
brw_imm_ud(~BRW_CR0_RND_MODE_MASK));
+  brw_inst_set_exec_size(p->devinfo, inst, BRW_EXECUTE_1);
 
   /* From the Skylake PRM, Volume 7, page 760:
*  "Implementation Restriction on Register Access: When the control
@@ -3730,6 +3731,7 @@ brw_rounding_mode(struct brw_codegen *p,
if (bits) {
   brw_inst *inst = brw_OR(p, brw_cr0_reg(0), brw_cr0_reg(0),
   brw_imm_ud(bits));
+  brw_inst_set_exec_size(p->devinfo, inst, BRW_EXECUTE_1);
   brw_inst_set_thread_control(p->devinfo, inst, BRW_THREAD_SWITCH);
}
 }
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev