Re: [Mesa-dev] [PATCH] main: glGetIntegeri_v fails for GL_VERTEX_BINDING_STRIDE

2015-05-08 Thread Tapani Pälli 

That is strange, it was introduced in fb370f89d but then has gone missing ..

Reviewed-by: Tapani Pälli tapani.pa...@intel.com


On 05/07/2015 06:13 PM, Marta Lofstedt wrote:

The return type for GL_VERTEX_BINDING_STRIDE is missing,
this cause glGetIntegeri_v to fail.

Signed-off-by: Marta Lofstedt marta.lofst...@linux.intel.com
---
  src/mesa/main/get.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index 6fc0f3f..9fb8fba 100644
--- a/src/mesa/main/get.c
+++ b/src/mesa/main/get.c
@@ -1959,6 +1959,7 @@ find_value_indexed(const char *func, GLenum pname, GLuint 
index, union value *v)
if (index = ctx-Const.Program[MESA_SHADER_VERTEX].MaxAttribs)
goto invalid_value;
v-value_int = 
ctx-Array.VAO-VertexBinding[VERT_ATTRIB_GENERIC(index)].Stride;
+  return TYPE_INT;

 /* ARB_shader_image_load_store */
 case GL_IMAGE_BINDING_NAME: {


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] main: glGetIntegeri_v fails for GL_VERTEX_BINDING_STRIDE

2015-05-08 Thread Emil Velikov 
On 8 May 2015 at 11:36, Tapani Pälli tapani.pa...@intel.com wrote:
 That is strange, it was introduced in fb370f89d but then has gone missing ..

Seems like it broke shortly after it was introduced (around 10.1.0-devel)

commit 902f9df36bec7d67a2d8bc4c24d89d9d57964903
Author: Francisco Jerez curroje...@riseup.net
Date:   Mon Nov 25 10:11:59 2013 -0800

mesa: Add image parameter queries for ARB_shader_image_load_store.


The fix looks great - curious that we don't have piglits for these.

Whomever pushes this, please add

Cc: 10.4 10.5 mesa-sta...@lists.freedesktop.org
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] main: glGetIntegeri_v fails for GL_VERTEX_BINDING_STRIDE

2015-05-07 Thread Marta Lofstedt 
The return type for GL_VERTEX_BINDING_STRIDE is missing,
this cause glGetIntegeri_v to fail.

Signed-off-by: Marta Lofstedt marta.lofst...@linux.intel.com
---
 src/mesa/main/get.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index 6fc0f3f..9fb8fba 100644
--- a/src/mesa/main/get.c
+++ b/src/mesa/main/get.c
@@ -1959,6 +1959,7 @@ find_value_indexed(const char *func, GLenum pname, GLuint 
index, union value *v)
   if (index = ctx-Const.Program[MESA_SHADER_VERTEX].MaxAttribs)
   goto invalid_value;
   v-value_int = 
ctx-Array.VAO-VertexBinding[VERT_ATTRIB_GENERIC(index)].Stride;
+  return TYPE_INT;
 
/* ARB_shader_image_load_store */
case GL_IMAGE_BINDING_NAME: {
-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev