Re: [Mesa-dev] [PATCH] main: remove __FUNCTION__ defined because it is obsolete

2015-04-21 Thread Emil Velikov 
On 16/04/15 13:04, Predut, Marius wrote:
 
 -Original Message-
 From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
 Sent: Thursday, April 16, 2015 1:53 PM
 To: Predut, Marius
 Cc: ML mesa-dev
 Subject: Re: [Mesa-dev] [PATCH] main: remove __FUNCTION__ defined because it
 is obsolete

 Hi Marius,

 On 16 April 2015 at 11:36, Marius Predut marius.pre...@intel.com wrote:
 Consistently just use C99's __func__ everywhere.
 No functional changes.
 Apply this patch after radeon: replace __FUNCTION__ with __func__ patch.

 Tip: If you send the patches as series (git format-patch -2) this will
 implicitly provide/preserve the dependency chain.
 
 Ok thanks, in this case if u plan commit it , may be is better to adjust the 
 comment by removing last line.
 
Indeed that's the plan. Sorry for the delay - was pulled aside with
other things, so I've just pushed these to master.

Thanks again.

-Emil

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] main: remove __FUNCTION__ defined because it is obsolete

2015-04-16 Thread Emil Velikov 
Hi Marius,

On 16 April 2015 at 11:36, Marius Predut marius.pre...@intel.com wrote:
 Consistently just use C99's __func__ everywhere.
 No functional changes.
 Apply this patch after radeon: replace __FUNCTION__ with __func__ patch.

Tip: If you send the patches as series (git format-patch -2) this will
implicitly provide/preserve the dependency chain.

Both patches are trivial enough, plus other places of mesa have their
own redefinition of the symbol. I'll do a quick build test and push
them in the next few hours. Unless there are any objections of course
:-)

 Signed-off-by: Marius Predut marius.pre...@intel.com
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] main: remove __FUNCTION__ defined because it is obsolete

2015-04-16 Thread Marius Predut 
Consistently just use C99's __func__ everywhere.
No functional changes.
Apply this patch after radeon: replace __FUNCTION__ with __func__ patch.

Signed-off-by: Marius Predut marius.pre...@intel.com
---
 src/mesa/main/compiler.h |5 -
 1 file changed, 5 deletions(-)

diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 55152fd..93b4e6f 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -60,11 +60,6 @@ extern C {
 #endif
 
 
-/* XXX: Use standard `__func__` instead */
-#ifndef __FUNCTION__
-#  define __FUNCTION__ __func__
-#endif
-
 /**
  * Either define MESA_BIG_ENDIAN or MESA_LITTLE_ENDIAN, and CPU_TO_LE32.
  * Do not use these unless absolutely necessary!
-- 
1.7.9.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev