Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC
On 13/08/18 20:43, Dylan Baker wrote:
> This probably should have a Fixes tag?
Yes, should had, but I pushed it as soon as I got a Rb :/ Sorry
>
> Quoting Alejandro Piñeiro (2018-08-13 07:50:38)
>> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this
>> patch replaces it with unsigned.
>> ---
>>
>> Note that Im not sure if this is the usual solution. As far as I see,
>> uint is used on other source files. Having said so, just replacing for
>> unsigned seems the easier way to fix this.
>>
>> src/mesa/main/glspirv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
>> index 4fc80b72181..1c5b7dd17f3 100644
>> --- a/src/mesa/main/glspirv.c
>> +++ b/src/mesa/main/glspirv.c
>> @@ -188,7 +188,7 @@ nir_compute_double_inputs(nir_shader *shader,
>> {
>> nir_foreach_variable(var, >inputs) {
>>if (glsl_type_is_dual_slot(glsl_without_array(var->type))) {
>> - for (uint i = 0; i < glsl_count_attribute_slots(var->type, true);
>> i++) {
>> + for (unsigned i = 0; i < glsl_count_attribute_slots(var->type,
>> true); i++) {
>> uint64_t bitfield = BITFIELD64_BIT(var->data.location + i);
>> shader->info.vs.double_inputs |= bitfield;
>> }
>> --
>> 2.14.1
>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC
This probably should have a Fixes tag?
Quoting Alejandro Piñeiro (2018-08-13 07:50:38)
> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this
> patch replaces it with unsigned.
> ---
>
> Note that Im not sure if this is the usual solution. As far as I see,
> uint is used on other source files. Having said so, just replacing for
> unsigned seems the easier way to fix this.
>
> src/mesa/main/glspirv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
> index 4fc80b72181..1c5b7dd17f3 100644
> --- a/src/mesa/main/glspirv.c
> +++ b/src/mesa/main/glspirv.c
> @@ -188,7 +188,7 @@ nir_compute_double_inputs(nir_shader *shader,
> {
> nir_foreach_variable(var, >inputs) {
>if (glsl_type_is_dual_slot(glsl_without_array(var->type))) {
> - for (uint i = 0; i < glsl_count_attribute_slots(var->type, true);
> i++) {
> + for (unsigned i = 0; i < glsl_count_attribute_slots(var->type,
> true); i++) {
> uint64_t bitfield = BITFIELD64_BIT(var->data.location + i);
> shader->info.vs.double_inputs |= bitfield;
> }
> --
> 2.14.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC
Am 13.08.2018 um 16:50 schrieb Alejandro Piñeiro:
> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this
> patch replaces it with unsigned.
Reviewed-by: Roland Scheidegger
> ---
>
> Note that Im not sure if this is the usual solution. As far as I see,
> uint is used on other source files. Having said so, just replacing for
> unsigned seems the easier way to fix this.
>
> src/mesa/main/glspirv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
> index 4fc80b72181..1c5b7dd17f3 100644
> --- a/src/mesa/main/glspirv.c
> +++ b/src/mesa/main/glspirv.c
> @@ -188,7 +188,7 @@ nir_compute_double_inputs(nir_shader *shader,
> {
> nir_foreach_variable(var, >inputs) {
>if (glsl_type_is_dual_slot(glsl_without_array(var->type))) {
> - for (uint i = 0; i < glsl_count_attribute_slots(var->type, true);
> i++) {
> + for (unsigned i = 0; i < glsl_count_attribute_slots(var->type,
> true); i++) {
> uint64_t bitfield = BITFIELD64_BIT(var->data.location + i);
> shader->info.vs.double_inputs |= bitfield;
> }
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC
On 13 August 2018 at 15:56, Alejandro Piñeiro wrote: > > > On 13/08/18 16:50, Alejandro Piñeiro wrote: >> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this >> patch replaces it with unsigned. >> --- >> >> Note that Im not sure if this is the usual solution. As far as I see, >> uint is used on other source files. Having said so, just replacing for >> unsigned seems the easier way to fix this. > > Note2: I don't have a way to really test this patch on MSVC. I assume > that it would fix it, but it is a kind of blind-assumption. > The AppVeyor + github integration is as trivial as travis + github. Simply login click a few times and watch the build issues on git push. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC
On 13/08/18 16:50, Alejandro Piñeiro wrote:
> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this
> patch replaces it with unsigned.
> ---
>
> Note that Im not sure if this is the usual solution. As far as I see,
> uint is used on other source files. Having said so, just replacing for
> unsigned seems the easier way to fix this.
Note2: I don't have a way to really test this patch on MSVC. I assume
that it would fix it, but it is a kind of blind-assumption.
>
> src/mesa/main/glspirv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
> index 4fc80b72181..1c5b7dd17f3 100644
> --- a/src/mesa/main/glspirv.c
> +++ b/src/mesa/main/glspirv.c
> @@ -188,7 +188,7 @@ nir_compute_double_inputs(nir_shader *shader,
> {
> nir_foreach_variable(var, >inputs) {
>if (glsl_type_is_dual_slot(glsl_without_array(var->type))) {
> - for (uint i = 0; i < glsl_count_attribute_slots(var->type, true);
> i++) {
> + for (unsigned i = 0; i < glsl_count_attribute_slots(var->type,
> true); i++) {
> uint64_t bitfield = BITFIELD64_BIT(var->data.location + i);
> shader->info.vs.double_inputs |= bitfield;
> }
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC
From AppVeyor #8582, it seems that MSVC doesn't like uint, so this
patch replaces it with unsigned.
---
Note that Im not sure if this is the usual solution. As far as I see,
uint is used on other source files. Having said so, just replacing for
unsigned seems the easier way to fix this.
src/mesa/main/glspirv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
index 4fc80b72181..1c5b7dd17f3 100644
--- a/src/mesa/main/glspirv.c
+++ b/src/mesa/main/glspirv.c
@@ -188,7 +188,7 @@ nir_compute_double_inputs(nir_shader *shader,
{
nir_foreach_variable(var, >inputs) {
if (glsl_type_is_dual_slot(glsl_without_array(var->type))) {
- for (uint i = 0; i < glsl_count_attribute_slots(var->type, true);
i++) {
+ for (unsigned i = 0; i < glsl_count_attribute_slots(var->type, true);
i++) {
uint64_t bitfield = BITFIELD64_BIT(var->data.location + i);
shader->info.vs.double_inputs |= bitfield;
}
--
2.14.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
