[Mesa-dev] [PATCH] mesa/varray: set double arrays to non-normalised.

2015-12-09 Thread Dave Airlie
From: Dave Airlie 

Doesn't have any effect in practice I don't think, but
CTS reads back using GetVertexAttrib.

This fixes: GL41-CTS.vertex_attrib_64bit.get_vertex_attrib

Signed-off-by: Dave Airlie 
---
 src/mesa/main/varray.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index 58f376b..c71e16a 100644
--- a/src/mesa/main/varray.c
+++ b/src/mesa/main/varray.c
@@ -776,7 +776,7 @@ _mesa_VertexAttribLPointer(GLuint index, GLint size, GLenum 
type,
 
update_array(ctx, "glVertexAttribLPointer", VERT_ATTRIB_GENERIC(index),
 legalTypes, 1, 4,
-size, type, stride, GL_TRUE, GL_FALSE, GL_TRUE, ptr);
+size, type, stride, GL_FALSE, GL_FALSE, GL_TRUE, ptr);
 }
 
 
-- 
2.5.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] mesa/varray: set double arrays to non-normalised.

2015-12-09 Thread Ian Romanick
...and it matches what we do for single precision.

Reviewed-by: Ian Romanick 

Presumably this should also be a candidate for 11.0 and 11.1?

On 12/09/2015 04:37 PM, Dave Airlie wrote:
> From: Dave Airlie 
> 
> Doesn't have any effect in practice I don't think, but
> CTS reads back using GetVertexAttrib.
> 
> This fixes: GL41-CTS.vertex_attrib_64bit.get_vertex_attrib
> 
> Signed-off-by: Dave Airlie 
> ---
>  src/mesa/main/varray.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
> index 58f376b..c71e16a 100644
> --- a/src/mesa/main/varray.c
> +++ b/src/mesa/main/varray.c
> @@ -776,7 +776,7 @@ _mesa_VertexAttribLPointer(GLuint index, GLint size, 
> GLenum type,
>  
> update_array(ctx, "glVertexAttribLPointer", VERT_ATTRIB_GENERIC(index),
>  legalTypes, 1, 4,
> -size, type, stride, GL_TRUE, GL_FALSE, GL_TRUE, ptr);
> +size, type, stride, GL_FALSE, GL_FALSE, GL_TRUE, ptr);
>  }
>  
>  
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev