Re: [Mesa-dev] [PATCH] mesa: check for unchanged line width before error checking

[Matt Turner]

Reviewed-by: Matt Turner 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: check for unchanged line width before error checking

[Brian Paul]

---
 src/mesa/main/lines.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/mesa/main/lines.c b/src/mesa/main/lines.c
index c020fb3..93b80af 100644
--- a/src/mesa/main/lines.c
+++ b/src/mesa/main/lines.c
@@ -45,6 +45,10 @@ _mesa_LineWidth( GLfloat width )
if (MESA_VERBOSE & VERBOSE_API)
   _mesa_debug(ctx, "glLineWidth %f\n", width);
 
+   /* If width is unchanged, there can't be an error */
+   if (ctx->Line.Width == width)
+  return;
+
if (width <= 0.0F) {
   _mesa_error( ctx, GL_INVALID_VALUE, "glLineWidth" );
   return;
@@ -68,9 +72,6 @@ _mesa_LineWidth( GLfloat width )
   return;
}
 
-   if (ctx->Line.Width == width)
-  return;
-
FLUSH_VERTICES(ctx, _NEW_LINE);
ctx->Line.Width = width;
 
-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev