Re: [Mesa-dev] [PATCH] mesa: enable ARB_explicit_uniform_location for swrast

2016-04-11 Thread Ian Romanick
Does any driver that supports GLSL not support this extension?  Maybe we
could condition this extension and ARB_explicit_attrib_location on
ARB_vertex_shader... and delete the other two enable flags.

On 04/08/2016 05:54 PM, Timothy Arceri wrote:
> This is untested but since ARB_explicit_attrib_location is enabled
> there should be no problem enabling this also.
> ---
>  src/mesa/main/extensions.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index fa50cb6..a889902 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -132,6 +132,7 @@ _mesa_enable_sw_extensions(struct gl_context *ctx)
> ctx->Extensions.ARB_draw_elements_base_vertex = GL_TRUE;
> ctx->Extensions.ARB_draw_instanced = GL_TRUE;
> ctx->Extensions.ARB_explicit_attrib_location = GL_TRUE;
> +   ctx->Extensions.ARB_explicit_uniform_location = GL_TRUE;
> ctx->Extensions.ARB_fragment_coord_conventions = GL_TRUE;
> ctx->Extensions.ARB_fragment_program = GL_TRUE;
> ctx->Extensions.ARB_fragment_program_shadow = GL_TRUE;
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] mesa: enable ARB_explicit_uniform_location for swrast

2016-04-08 Thread Timothy Arceri
This is untested but since ARB_explicit_attrib_location is enabled
there should be no problem enabling this also.
---
 src/mesa/main/extensions.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index fa50cb6..a889902 100644
--- a/src/mesa/main/extensions.c
+++ b/src/mesa/main/extensions.c
@@ -132,6 +132,7 @@ _mesa_enable_sw_extensions(struct gl_context *ctx)
ctx->Extensions.ARB_draw_elements_base_vertex = GL_TRUE;
ctx->Extensions.ARB_draw_instanced = GL_TRUE;
ctx->Extensions.ARB_explicit_attrib_location = GL_TRUE;
+   ctx->Extensions.ARB_explicit_uniform_location = GL_TRUE;
ctx->Extensions.ARB_fragment_coord_conventions = GL_TRUE;
ctx->Extensions.ARB_fragment_program = GL_TRUE;
ctx->Extensions.ARB_fragment_program_shadow = GL_TRUE;
-- 
2.5.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev